From: Ira Weiny <ira.weiny@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Dave Chinner <david@fromorbit.com>, Jan Kara <jack@suse.cz>,
Dan Williams <dan.j.williams@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
Jeff Moyer <jmoyer@redhat.com>,
linux-ext4 <linux-ext4@vger.kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH V6 6/8] fs/xfs: Combine xfs_diflags_to_linux() and xfs_diflags_to_iflags()
Date: Thu, 9 Apr 2020 13:49:53 -0700 [thread overview]
Message-ID: <20200409204952.GB801897@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <20200409124127.GB18171@lst.de>
On Thu, Apr 09, 2020 at 02:41:27PM +0200, Christoph Hellwig wrote:
> On Wed, Apr 08, 2020 at 05:22:03PM -0700, Ira Weiny wrote:
> > > You mean something like XFS_IDONTCACHE?
> > >
> > > i.e. the functionality already exists in XFS to selectively evict an
> > > inode from cache when the last reference to it is dropped rather
> > > than let it go to the LRUs and hang around in memory.
> > >
> > > That flag can be set when changing the on disk DAX flag, and we can
> > > tweak how it works so new cache hits don't clear it (as happens
> > > now). Hence the only thing that can prevent eviction are active
> > > references.
> > >
> > > That means we'll still need to stop the application and drop_caches,
> > > because we need to close all the files and purge the dentries that
> > > hold references to the inode before it can be evicted.
> >
> > That sounds like a great idea...
> >
> > Jan? Christoph?
>
> Sounds ok. Note that we could also pretty trivially lift
> XFS_IDONTCACHE to the VFS if we need to apply the same scheme to
> ext4.
Yes I have been slowing working on ext4 in the background. So lifting
XXX_IDONTCACHE to VFS will be part of that series.
Thanks,
Ira
next prev parent reply other threads:[~2020-04-09 20:49 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 18:29 [PATCH V6 0/8] Enable per-file/per-directory DAX operations V6 ira.weiny
2020-04-07 18:29 ` [PATCH V6 1/8] fs/xfs: Remove unnecessary initialization of i_rwsem ira.weiny
2020-04-07 23:46 ` Dave Chinner
2020-04-07 18:29 ` [PATCH V6 2/8] fs: Remove unneeded IS_DAX() check ira.weiny
2020-04-09 7:31 ` Christoph Hellwig
2020-04-09 14:57 ` Ira Weiny
2020-04-07 18:29 ` [PATCH V6 3/8] fs/stat: Define DAX statx attribute ira.weiny
2020-04-07 23:47 ` Dave Chinner
2020-04-07 18:29 ` [PATCH V6 4/8] fs/xfs: Make DAX mount option a tri-state ira.weiny
2020-04-07 23:59 ` Dave Chinner
2020-04-08 0:09 ` Ira Weiny
2020-04-08 0:48 ` Dave Chinner
2020-04-09 15:03 ` Ira Weiny
2020-04-07 18:29 ` [PATCH V6 5/8] fs/xfs: Create function xfs_inode_enable_dax() ira.weiny
2020-04-08 0:05 ` Dave Chinner
2020-04-08 0:13 ` Ira Weiny
2020-04-07 18:29 ` [PATCH V6 6/8] fs/xfs: Combine xfs_diflags_to_linux() and xfs_diflags_to_iflags() ira.weiny
2020-04-08 2:08 ` Dave Chinner
2020-04-08 17:09 ` Ira Weiny
2020-04-08 21:02 ` Dave Chinner
2020-04-08 21:28 ` Dan Williams
2020-04-08 22:10 ` Ira Weiny
2020-04-08 23:58 ` Dave Chinner
2020-04-09 0:22 ` Ira Weiny
2020-04-09 12:41 ` Christoph Hellwig
2020-04-09 20:49 ` Ira Weiny [this message]
2020-04-08 22:07 ` Ira Weiny
2020-04-08 23:21 ` Dave Chinner
2020-04-09 0:12 ` Ira Weiny
2020-04-09 0:30 ` Darrick J. Wong
2020-04-09 15:29 ` Ira Weiny
2020-04-09 16:59 ` Darrick J. Wong
2020-04-09 17:17 ` Jan Kara
2020-04-09 20:54 ` Ira Weiny
2020-04-09 0:49 ` Dave Chinner
2020-04-09 12:40 ` Christoph Hellwig
2020-04-10 0:27 ` Dave Chinner
2020-04-07 18:29 ` [PATCH V6 7/8] fs/xfs: Change xfs_ioctl_setattr_dax_invalidate() to xfs_ioctl_dax_check() ira.weiny
2020-04-08 2:23 ` Dave Chinner
2020-04-08 9:58 ` Jan Kara
2020-04-08 21:09 ` Dave Chinner
2020-04-08 22:26 ` Ira Weiny
2020-04-08 23:48 ` Dave Chinner
2020-04-09 12:28 ` Christoph Hellwig
2020-04-08 15:37 ` Darrick J. Wong
2020-04-08 18:13 ` Ira Weiny
2020-04-16 5:39 ` [fs/xfs] 857c9841f8: xfstests.xfs.046.fail kernel test robot
2020-04-16 5:39 ` kernel test robot
2020-04-07 18:29 ` [PATCH V6 8/8] Documentation/dax: Update Usage section ira.weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409204952.GB801897@iweiny-DESK2.sc.intel.com \
--to=ira.weiny@intel.com \
--cc=dan.j.williams@intel.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.