From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C745C2BB86 for ; Thu, 9 Apr 2020 22:33:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D75D62072F for ; Thu, 9 Apr 2020 22:33:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aFzSLMqX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726846AbgDIWdl (ORCPT ); Thu, 9 Apr 2020 18:33:41 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:38644 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726679AbgDIWdl (ORCPT ); Thu, 9 Apr 2020 18:33:41 -0400 Received: by mail-pf1-f196.google.com with SMTP id c21so203775pfo.5; Thu, 09 Apr 2020 15:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=h6CIWptWdgEYb7MN2wQY+7B3RiKrdcdmKs6r8jKHbUQ=; b=aFzSLMqXkYUkWTXZf/+hjn33ZQ+pGbjtq3DbLoRoUzO+mOIdinxzUpOdg9Bm4l55fY 1eXpGvBqe+m/5dHjD/j6Yb2Lq+4eMXj7D7ZMxHC/gLmPV+tQiQp89Zji6AcxJ6MQS4Kp 3GqAZAgxDKro7/TC0OHa5wIAmtn13WKqpIkuuvPFqj8+WDej/0XH7IH56DqYUPHcpLo6 uWPeGitvXf/CBxkHl+YT/Y4IFvlAiJx/jfjarvUH6yZ4p7g+hi9hTICcNgZ2wggGaujt vL9W0pVDGgRjLq/fZFSU4ED0KUgsjQxky8FhSj7d7bfiCUkzSfLJ3AudquBUqBuHv6+g qPlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=h6CIWptWdgEYb7MN2wQY+7B3RiKrdcdmKs6r8jKHbUQ=; b=HOnBFvoLyjE5bVFkIVTd6JpKah5gaCenJi9tIQ0pAzh5ke6xB+rnbaVQ50uMNxUUMU 8K4L79YGmX8bUyj/e6SgOHvZVSEtij9hdr/rIww2YABHt5U42vnC4LqaTnHEEuvTiiAo 3aRvLDL5sZ1rXJK2ybT/PGgOS64/HrZx1XL+dCQv/qwDhILebB9EN6URuskQtYI6Rt3J pKfcJ38V8V0XAmFcu7cMuGmK/J8P+kna1pq31h+K4KG/3GsGFkrhstLxs/SpuUMwaPet YEDa3iH26jNZbUSCGARNe2ZAVosv8B03NJeaMqcDdnmOzg/Qfv9wDC0XspgC7BmYR4X+ qxHg== X-Gm-Message-State: AGi0PuZjabOhax1HVvppLDrwCAR+NEzx3XwabElFNdt7/5+3NTQiWtID SKMWR7pk0ZnR84ArXJc4TuI= X-Google-Smtp-Source: APiQypJaBhU/00jWtLTIagZAShLNSuuZI+wxh6wVCmQrvZ4Kdyo8ltKirou0fEd/yrEm/fYRCULOdA== X-Received: by 2002:a63:a601:: with SMTP id t1mr1618612pge.23.1586471618671; Thu, 09 Apr 2020 15:33:38 -0700 (PDT) Received: from ast-mbp.dhcp.thefacebook.com ([2620:10d:c090:400::5:dc3d]) by smtp.gmail.com with ESMTPSA id t23sm173152pjq.27.2020.04.09.15.33.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2020 15:33:37 -0700 (PDT) Date: Thu, 9 Apr 2020 15:33:35 -0700 From: Alexei Starovoitov To: Mathieu Desnoyers Cc: Thomas Gleixner , Will Deacon , akpm@linux-foundation.org, Greg Kroah-Hartman , "K . Prasad" , Masami Hiramatsu , rostedt@goodmis.org, Alexei Starovoitov , linux-kernel@vger.kernel.org, Daniel Borkmann , Ingo Molnar , bpf@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [RFC PATCH 3/9] writeback: tracing: pass global_wb_domain as tracepoint parameter Message-ID: <20200409223335.ovetfovkm2d2ca36@ast-mbp.dhcp.thefacebook.com> References: <20200409193543.18115-1-mathieu.desnoyers@efficios.com> <20200409193543.18115-4-mathieu.desnoyers@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200409193543.18115-4-mathieu.desnoyers@efficios.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 09, 2020 at 03:35:37PM -0400, Mathieu Desnoyers wrote: > if (pause < min_pause) { > - trace_balance_dirty_pages(wb, > + trace_balance_dirty_pages(&global_wb_domain, > + wb, > sdtc->thresh, > sdtc->bg_thresh, > sdtc->dirty, argh. 13 arguments to single function ?! Currently the call site looks like: trace_balance_dirty_pages(wb, sdtc->thresh, sdtc->bg_thresh, sdtc->dirty, sdtc->wb_thresh, sdtc->wb_dirty, dirty_ratelimit, task_ratelimit, pages_dirtied, period, min(pause, 0L), start_time); Just pass sdtc as a pointer instead. Then another wb argument will be fine.