From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F023C2BB55 for ; Fri, 10 Apr 2020 17:52:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EF34D207FF for ; Fri, 10 Apr 2020 17:52:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586541155; bh=NSx+Q67i//I/6xT9Q3B5BFbOJfQ/XJkYOLB7WHdRK0c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=RXFESv5V9JFUJyM/loctq6eTXTKdpObqb1IcGsxHm3UXpt/wJWZ5YreWEwf6l1fGM wmdBkedujwmggJgSfba/nRFtUqVjYHc0UH7LwnqP+yl3H7/nKHX+K74ffGyDzrNDj6 UZkI2zJwIkllGepNWfUrJS+qIVbcQ69f8oqd9ZAw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726735AbgDJRwd (ORCPT ); Fri, 10 Apr 2020 13:52:33 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:39044 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726142AbgDJRwd (ORCPT ); Fri, 10 Apr 2020 13:52:33 -0400 Received: by mail-ot1-f66.google.com with SMTP id x11so2549647otp.6; Fri, 10 Apr 2020 10:52:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Lrdln4dBvVFJR91vr9hlZjSH31XigTv0FjlsPXSoRUo=; b=LYUmBAxqOn/A6GVstNklA+s8sLWlybiYvixCZrI3SftnppuP847ZIxc0wIlqfNBEFc ynbc4VvHP0SYnPRoDFJoKJtPgscu5vGIL1ITksPSVhPWN1Hvab/jX6ud86g+ANQHzi7D zsMUKs0boR3ji4VugPOF3kiRzMS61Q1a7VfQJ5ILBL6fYUHWVXq4gKjSzlUqHPNSmtPt Job0cqfOuP96dm1rTxekPd8Wp3Sldl1Qpe9Uy7bcB8UonzEhn0EYQ8uGG7YgEybG8l6z M1kPmj02zZBeuWgFSb1hDdsnD1IN3T0vamvFztNOI4WTmwF77Q5h8pyeHjFETZRT0X/t almQ== X-Gm-Message-State: AGi0PuYuKMptGaEAfJ4asyyc71Ax20sOTV6LGKn8hZWJc5fB4hA7Kt8x Rp7kRGxOAkKi2xUxCbS+BA== X-Google-Smtp-Source: APiQypIJzpPqxAkQRlPF/5U3xRWWYMkPbwF7Wx4paxMhG5vqpFOLez8zWuPdHwN38LwnKLQ3TbUQkw== X-Received: by 2002:a9d:77cf:: with SMTP id w15mr5195937otl.158.1586541152824; Fri, 10 Apr 2020 10:52:32 -0700 (PDT) Received: from rob-hp-laptop (ip-173-126-55-226.ftwttx.spcsdns.net. [173.126.55.226]) by smtp.gmail.com with ESMTPSA id 26sm1698146oot.25.2020.04.10.10.52.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2020 10:52:32 -0700 (PDT) Received: (nullmailer pid 1070 invoked by uid 1000); Fri, 10 Apr 2020 17:52:30 -0000 Date: Fri, 10 Apr 2020 12:52:30 -0500 From: Rob Herring To: Johan Jonker Cc: heiko@sntech.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v3 2/2] ARM: dts: rockchip: fix yaml warnings for rk3288-pmu-sram compatible nodes Message-ID: <20200410175230.GA28412@bogus> References: <20200331121352.3825-1-jbx6244@gmail.com> <20200331121352.3825-2-jbx6244@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200331121352.3825-2-jbx6244@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 31, 2020 at 02:13:52PM +0200, Johan Jonker wrote: > A test with the command below gives for example these warnings: > > arch/arm/boot/dts/rk3288-evb-act8846.dt.yaml: sram@ff720000: > '#address-cells' is a required property > arch/arm/boot/dts/rk3288-evb-act8846.dt.yaml: sram@ff720000: > '#size-cells' is a required property > arch/arm/boot/dts/rk3288-evb-act8846.dt.yaml: sram@ff720000: > 'ranges' is a required property > > Fix this error by adding '#address-cells', '#size-cells' and > 'ranges' to the 'rockchip,rk3288-pmu-sram' compatible node > in rk3288.dtsi. > > make ARCH=arm dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/sram/sram.yaml > > Signed-off-by: Johan Jonker > --- > Not tested with hardware. > > Changed v2: > Fix dtsi. > --- > arch/arm/boot/dts/rk3288.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi > index 9c8741bb1..f102fec69 100644 > --- a/arch/arm/boot/dts/rk3288.dtsi > +++ b/arch/arm/boot/dts/rk3288.dtsi > @@ -730,6 +730,9 @@ > pmu_sram: sram@ff720000 { > compatible = "rockchip,rk3288-pmu-sram", "mmio-sram"; > reg = <0x0 0xff720000 0x0 0x1000>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 0x0 0xff720000 0x1000>; I think we should make these optional instead if there's no child nodes. And if there are child nodes, then these will be required. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [RFC PATCH v3 2/2] ARM: dts: rockchip: fix yaml warnings for rk3288-pmu-sram compatible nodes Date: Fri, 10 Apr 2020 12:52:30 -0500 Message-ID: <20200410175230.GA28412@bogus> References: <20200331121352.3825-1-jbx6244@gmail.com> <20200331121352.3825-2-jbx6244@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200331121352.3825-2-jbx6244-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Johan Jonker Cc: heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rockchip.vger.kernel.org On Tue, Mar 31, 2020 at 02:13:52PM +0200, Johan Jonker wrote: > A test with the command below gives for example these warnings: > > arch/arm/boot/dts/rk3288-evb-act8846.dt.yaml: sram@ff720000: > '#address-cells' is a required property > arch/arm/boot/dts/rk3288-evb-act8846.dt.yaml: sram@ff720000: > '#size-cells' is a required property > arch/arm/boot/dts/rk3288-evb-act8846.dt.yaml: sram@ff720000: > 'ranges' is a required property > > Fix this error by adding '#address-cells', '#size-cells' and > 'ranges' to the 'rockchip,rk3288-pmu-sram' compatible node > in rk3288.dtsi. > > make ARCH=arm dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/sram/sram.yaml > > Signed-off-by: Johan Jonker > --- > Not tested with hardware. > > Changed v2: > Fix dtsi. > --- > arch/arm/boot/dts/rk3288.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi > index 9c8741bb1..f102fec69 100644 > --- a/arch/arm/boot/dts/rk3288.dtsi > +++ b/arch/arm/boot/dts/rk3288.dtsi > @@ -730,6 +730,9 @@ > pmu_sram: sram@ff720000 { > compatible = "rockchip,rk3288-pmu-sram", "mmio-sram"; > reg = <0x0 0xff720000 0x0 0x1000>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 0x0 0xff720000 0x1000>; I think we should make these optional instead if there's no child nodes. And if there are child nodes, then these will be required. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3116DC2D0EC for ; Fri, 10 Apr 2020 17:52:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 072E9207FF for ; Fri, 10 Apr 2020 17:52:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sr/4dj8Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 072E9207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CukDhbd5+Gnvab5WYco8eTFV8DNueOLvrG1lJyaphuw=; b=sr/4dj8QE+c1HB cru+Yr7+wyXg5QzcmJI3LfZsSgbX+2b9s4LlmVfapPl6Q7n/Wr5kK9PvQq2GskIWRbkWq2+RmszTr JMaWyfY457se4lsrHr40YVsvVLJN2YVMJoLa12ddgd91R60uRQ8WMwgx08SuSvC24WcZuhRllSP7y Vgh0bgFpHbrMGaIok6Zj5LYjIc7tIkdgXZvS1D7c1FKZy3cig2lQUq2SGIMwMtU+BPdCmH3mvZSuR HBgsszk2bXlnyTFau91rXr/1WqSOBLu8Skd/XbXdSbni5HXaGx13yP8rAWQ/svLRCrYzujkjPPIuY IZBVZZFR+T0uGA9hUkpw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMxpV-0000zu-22; Fri, 10 Apr 2020 17:52:37 +0000 Received: from mail-ot1-f65.google.com ([209.85.210.65]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMxpR-0000zK-QZ; Fri, 10 Apr 2020 17:52:35 +0000 Received: by mail-ot1-f65.google.com with SMTP id 103so2578081otv.0; Fri, 10 Apr 2020 10:52:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Lrdln4dBvVFJR91vr9hlZjSH31XigTv0FjlsPXSoRUo=; b=dUmDm+JQqttlM2z4mUCrGKIJzyeX3JdK2IQsiNl+OwsyHO/19cM/tGeFs1/6IsSrW2 9ULm4Hrc6jABJQKGBNf/TbJrYXLuldw2+KxsDvo3X62fEe+4d/Og5EPGHPImtiDAAt0R JX/dYAMFgMW/HSXQrWa9NRp2KTxHH2TQ1G640Sp2EN0rPfksKbDU+bbQGXFT5A9CfEH+ 2Ql+PK4NUJ3kZzGplSrhEFblxE+RGglRhT9kFcI7RP3QzwcB2QHsyPYGAdzqZpuDxz3P t8foBSRjyNF2paL+f6w9/k4vLQEtV9bw6hyxKS+2HBX5SIn7H8KYCedH3bs2TihlnasA /Gzg== X-Gm-Message-State: AGi0PuZ+U74m2gifXn3xlV8Do866qWcwzvQFU4WNj4mbJud6n8W//6TG ImQTJKaRRZKzEnK5cFeDOSiUb6o= X-Google-Smtp-Source: APiQypIJzpPqxAkQRlPF/5U3xRWWYMkPbwF7Wx4paxMhG5vqpFOLez8zWuPdHwN38LwnKLQ3TbUQkw== X-Received: by 2002:a9d:77cf:: with SMTP id w15mr5195937otl.158.1586541152824; Fri, 10 Apr 2020 10:52:32 -0700 (PDT) Received: from rob-hp-laptop (ip-173-126-55-226.ftwttx.spcsdns.net. [173.126.55.226]) by smtp.gmail.com with ESMTPSA id 26sm1698146oot.25.2020.04.10.10.52.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2020 10:52:32 -0700 (PDT) Received: (nullmailer pid 1070 invoked by uid 1000); Fri, 10 Apr 2020 17:52:30 -0000 Date: Fri, 10 Apr 2020 12:52:30 -0500 From: Rob Herring To: Johan Jonker Subject: Re: [RFC PATCH v3 2/2] ARM: dts: rockchip: fix yaml warnings for rk3288-pmu-sram compatible nodes Message-ID: <20200410175230.GA28412@bogus> References: <20200331121352.3825-1-jbx6244@gmail.com> <20200331121352.3825-2-jbx6244@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200331121352.3825-2-jbx6244@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200410_105234_600787_40CBE167 X-CRM114-Status: GOOD ( 14.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, heiko@sntech.de, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 31, 2020 at 02:13:52PM +0200, Johan Jonker wrote: > A test with the command below gives for example these warnings: > > arch/arm/boot/dts/rk3288-evb-act8846.dt.yaml: sram@ff720000: > '#address-cells' is a required property > arch/arm/boot/dts/rk3288-evb-act8846.dt.yaml: sram@ff720000: > '#size-cells' is a required property > arch/arm/boot/dts/rk3288-evb-act8846.dt.yaml: sram@ff720000: > 'ranges' is a required property > > Fix this error by adding '#address-cells', '#size-cells' and > 'ranges' to the 'rockchip,rk3288-pmu-sram' compatible node > in rk3288.dtsi. > > make ARCH=arm dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/sram/sram.yaml > > Signed-off-by: Johan Jonker > --- > Not tested with hardware. > > Changed v2: > Fix dtsi. > --- > arch/arm/boot/dts/rk3288.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi > index 9c8741bb1..f102fec69 100644 > --- a/arch/arm/boot/dts/rk3288.dtsi > +++ b/arch/arm/boot/dts/rk3288.dtsi > @@ -730,6 +730,9 @@ > pmu_sram: sram@ff720000 { > compatible = "rockchip,rk3288-pmu-sram", "mmio-sram"; > reg = <0x0 0xff720000 0x0 0x1000>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 0x0 0xff720000 0x1000>; I think we should make these optional instead if there's no child nodes. And if there are child nodes, then these will be required. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel