From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD0A8C2BB85 for ; Fri, 10 Apr 2020 19:34:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 98E422084D for ; Fri, 10 Apr 2020 19:34:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="B23qFvRB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726736AbgDJTe0 (ORCPT ); Fri, 10 Apr 2020 15:34:26 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:22500 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726713AbgDJTe0 (ORCPT ); Fri, 10 Apr 2020 15:34:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586547265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dR0pnT92lTl7PiXH1/vycyqLlKqG/upjftJ1HpISkMA=; b=B23qFvRBondG0uk3w1fbnTLyduYxESk9W7GeV7pwe9WbgI6HE/bFVpdfNa3on7+sN1pK8h LcPdyQaB57XZ/zwtG8bvuKP+TO0DlkbYxav7BHuz1pp2pEmGo/vgkCFS9YbJXSYiLEqrSQ 9powbFokcNRGcMRh9lWnVZJg96aubR8= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-193-Wi6sgRpGNAupTMp_qoUZfw-1; Fri, 10 Apr 2020 15:34:23 -0400 X-MC-Unique: Wi6sgRpGNAupTMp_qoUZfw-1 Received: by mail-qv1-f71.google.com with SMTP id z14so2449978qvk.2 for ; Fri, 10 Apr 2020 12:34:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dR0pnT92lTl7PiXH1/vycyqLlKqG/upjftJ1HpISkMA=; b=Gzi0EbIrulCL2MKMn7tIVKJD5yISfqoY7lHaZhNG9EWRav+aYdhAX+o2QYFAYBnkQx /FVxG+nJS/yhspFuz/10p3AgEYRNSg1Dx84o/Voenu9naWCWNFf/X6SIgqPU6vHvRLm2 +wxssMqWZGOFExK/nmcKliYAl6laLn1XhWtSjCU9OV3G1RhH8WAPqTcElYjG3iV15ahW C13CWIQq95teWAFZ7ol0Xf0eN/ussgD7Cb8tRO7OzDkdLy7cWl610xE8hnqrxfFRyyB2 FbRYHc70QxzxD65qPuB9swpW4ZiMNHOOmouGkOA35BL0aPOIQmPpIwRtU15PkQQmNXhN 2DJg== X-Gm-Message-State: AGi0PuYR81s8REgQsZBlddlxTF9Fhj5hqcrQE7eb8IX6gcr1aiGbP67r VuzbfP78XBhw5DMJS9TJt5WlyR+NvDXCQu1ZJ2o1MH+B7fuC7CDaz6WacjV7YcyO2HFY0ZZn0Q4 idY6p+mzZAysUnA0i9oAWMeBF X-Received: by 2002:ac8:6d06:: with SMTP id o6mr768737qtt.165.1586547263228; Fri, 10 Apr 2020 12:34:23 -0700 (PDT) X-Google-Smtp-Source: APiQypKE+9gdKAAzqM7E075abKl7yEhzpSisddiPAFgdbjLHprLwAVDEdymEnBo0qMB8GT4NFqVJjg== X-Received: by 2002:ac8:6d06:: with SMTP id o6mr768725qtt.165.1586547263017; Fri, 10 Apr 2020 12:34:23 -0700 (PDT) Received: from xz-x1 ([2607:9880:19c0:32::2]) by smtp.gmail.com with ESMTPSA id m11sm2214328qkg.130.2020.04.10.12.34.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2020 12:34:22 -0700 (PDT) Date: Fri, 10 Apr 2020 15:34:19 -0400 From: Peter Xu To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-doc@vger.kernel.org, Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , "David S . Miller" , Thomas Gleixner , Ingo Molnar , Dave Hansen , Jonathan Corbet , Longpeng , Christophe Leroy , Mina Almasry , Andrew Morton Subject: Re: [PATCH v2 3/4] hugetlbfs: remove hugetlb_add_hstate() warning for existing hstate Message-ID: <20200410193419.GF3172@xz-x1> References: <20200401183819.20647-1-mike.kravetz@oracle.com> <20200401183819.20647-4-mike.kravetz@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200401183819.20647-4-mike.kravetz@oracle.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 01, 2020 at 11:38:18AM -0700, Mike Kravetz wrote: [...] > @@ -3255,7 +3254,6 @@ void __init hugetlb_add_hstate(unsigned int order) > unsigned long i; > > if (size_to_hstate(PAGE_SIZE << order)) { > - pr_warn("hugepagesz= specified twice, ignoring\n"); > return; > } Nitpick: I think the brackets need to be removed to follow linux coding style. With that: Reviewed-by: Peter Xu -- Peter Xu From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Xu Date: Fri, 10 Apr 2020 19:34:19 +0000 Subject: Re: [PATCH v2 3/4] hugetlbfs: remove hugetlb_add_hstate() warning for existing hstate Message-Id: <20200410193419.GF3172@xz-x1> List-Id: References: <20200401183819.20647-1-mike.kravetz@oracle.com> <20200401183819.20647-4-mike.kravetz@oracle.com> In-Reply-To: <20200401183819.20647-4-mike.kravetz@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mike Kravetz Cc: linux-doc@vger.kernel.org, Catalin Marinas , Dave Hansen , Heiko Carstens , linux-mm@kvack.org, Paul Mackerras , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Will Deacon , Mina Almasry , linux-s390@vger.kernel.org, Jonathan Corbet , Christian Borntraeger , Ingo Molnar , Benjamin Herrenschmidt , Longpeng , Albert Ou , Vasily Gorbik , Paul Walmsley , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Christophe Leroy , linux-kernel@vger.kernel.org, Palmer Dabbelt , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" On Wed, Apr 01, 2020 at 11:38:18AM -0700, Mike Kravetz wrote: [...] > @@ -3255,7 +3254,6 @@ void __init hugetlb_add_hstate(unsigned int order) > unsigned long i; > > if (size_to_hstate(PAGE_SIZE << order)) { > - pr_warn("hugepagesz= specified twice, ignoring\n"); > return; > } Nitpick: I think the brackets need to be removed to follow linux coding style. With that: Reviewed-by: Peter Xu -- Peter Xu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5600AC2D0EC for ; Fri, 10 Apr 2020 19:34:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C6AA206C1 for ; Fri, 10 Apr 2020 19:34:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ny++SZ5X"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HTjtrTCP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C6AA206C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pSDLH5WsDUY0Ls+Yi5DMpK6wFwspuCJoAo5jQ7V/Ijc=; b=Ny++SZ5XtA6FpA gLN5WLs+0rxT4gAgOxnb5Kx0KEng0O0l4u/vzbxwMJTHS6FkpvJvnE70bxVzOG/kDfcmv9qbbzNgG 2zvE6liHx05isgqyNn3HkiuPja537QPcjm7tGcX0Z3zRwDZKUngMvfuYs/VpPG5NaGM3GvtxpfDwJ k9mOyB/R2MlHoI7rdGOGckVsfDKXmkhL+yUSxVvZdonYMFAHIzM62W02lNlxWMQILiz7rmvT9iZOf uN/t19Pe/OsLhbyoI47zPlVwDi3H45XqZzKFFF/H22tF29E81Jsx578ly3jC7iXDduGnb/B8URG8E om30yVWeFlMdkyXp4Gzw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMzQ6-0002nI-Uh; Fri, 10 Apr 2020 19:34:30 +0000 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120] helo=us-smtp-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMzQ3-0002ls-8w for linux-riscv@lists.infradead.org; Fri, 10 Apr 2020 19:34:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586547265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pSDLH5WsDUY0Ls+Yi5DMpK6wFwspuCJoAo5jQ7V/Ijc=; b=HTjtrTCPCtqlucaZeYXO9hdRWKKNAckT7ekZDJXF4mJhpipaNA9I2CNaZ2kSj9hZ8JMDfd x8O+SqhSx6dStv8V30+AeWP2e15nVJrSHFhqsats/yWfEKX2i5V8jL8upV5bG1UT+dmM/5 7kohKTXNMLmKBR1LDF3Ev3cAOymTgN8= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-350-PlY-P95PPnqEMV4gQshsIQ-1; Fri, 10 Apr 2020 15:34:23 -0400 X-MC-Unique: PlY-P95PPnqEMV4gQshsIQ-1 Received: by mail-qv1-f72.google.com with SMTP id z16so2438874qvo.4 for ; Fri, 10 Apr 2020 12:34:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dR0pnT92lTl7PiXH1/vycyqLlKqG/upjftJ1HpISkMA=; b=lyIDLtkRgC25lXIqoINg4HM+ww+3svH+KAOnpfSJMhUVM9FuQYDoqu1dTzFwh5yz6K VK3C4WyqnhVYRqg+45oYgaJPoPFKx44JkA49BODI7YywYsGIR8fNVkOJR4qO9u2EzoX3 qJVl+FelQ1NAgwo5X0mGQUly/fsbxGJhHn/CUUxBml+/as+ty9ckG3aASODne9BHhYLo hGw0vcVXif99gdCLP1qb552kJnMZe8tJ4RraTsU51wkpPyXySeOzgcys8QChRVTNpdvc 0zFyhdSrUM1t/R5qxTnuQ0f/IOQ9VmoAVDtSG2FkNc0SemMeNrH/Imr5ruZMTPnTh5Mo k2cg== X-Gm-Message-State: AGi0PuaRFUXFnckH4dOzM4HUHLyhKFMulw6UT+sbXif7nlTzBX50bLTk EKFLj4NZI0qd2PAcG3TXX9pX6eWOfiF0bN7ZKCIZknURvqLMNBtzmFJauVANolSCvAvLvz2mJwx uLjUMvDuss9VshfFEDYnbTRX2F27G X-Received: by 2002:ac8:6d06:: with SMTP id o6mr768751qtt.165.1586547263230; Fri, 10 Apr 2020 12:34:23 -0700 (PDT) X-Google-Smtp-Source: APiQypKE+9gdKAAzqM7E075abKl7yEhzpSisddiPAFgdbjLHprLwAVDEdymEnBo0qMB8GT4NFqVJjg== X-Received: by 2002:ac8:6d06:: with SMTP id o6mr768725qtt.165.1586547263017; Fri, 10 Apr 2020 12:34:23 -0700 (PDT) Received: from xz-x1 ([2607:9880:19c0:32::2]) by smtp.gmail.com with ESMTPSA id m11sm2214328qkg.130.2020.04.10.12.34.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2020 12:34:22 -0700 (PDT) Date: Fri, 10 Apr 2020 15:34:19 -0400 From: Peter Xu To: Mike Kravetz Subject: Re: [PATCH v2 3/4] hugetlbfs: remove hugetlb_add_hstate() warning for existing hstate Message-ID: <20200410193419.GF3172@xz-x1> References: <20200401183819.20647-1-mike.kravetz@oracle.com> <20200401183819.20647-4-mike.kravetz@oracle.com> MIME-Version: 1.0 In-Reply-To: <20200401183819.20647-4-mike.kravetz@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200410_123427_388129_9DDC6C35 X-CRM114-Status: UNSURE ( 7.86 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-doc@vger.kernel.org, Catalin Marinas , Dave Hansen , Heiko Carstens , linux-mm@kvack.org, Paul Mackerras , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Will Deacon , Mina Almasry , linux-s390@vger.kernel.org, Jonathan Corbet , Christian Borntraeger , Ingo Molnar , Benjamin Herrenschmidt , Longpeng , Albert Ou , Vasily Gorbik , Paul Walmsley , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Christophe Leroy , linux-kernel@vger.kernel.org, Palmer Dabbelt , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, Apr 01, 2020 at 11:38:18AM -0700, Mike Kravetz wrote: [...] > @@ -3255,7 +3254,6 @@ void __init hugetlb_add_hstate(unsigned int order) > =09unsigned long i; > =20 > =09if (size_to_hstate(PAGE_SIZE << order)) { > -=09=09pr_warn("hugepagesz=3D specified twice, ignoring\n"); > =09=09return; > =09} Nitpick: I think the brackets need to be removed to follow linux coding style. With that: Reviewed-by: Peter Xu --=20 Peter Xu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAAAFC2BB86 for ; Fri, 10 Apr 2020 19:36:58 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6803A2145D for ; Fri, 10 Apr 2020 19:36:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HTjtrTCP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6803A2145D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48zSvC3glVzDr9y for ; Sat, 11 Apr 2020 05:36:55 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=207.211.31.81; helo=us-smtp-delivery-1.mimecast.com; envelope-from=peterx@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HTjtrTCP; dkim-atps=neutral Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48zSrP5xpNzDqQk for ; Sat, 11 Apr 2020 05:34:28 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586547265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pSDLH5WsDUY0Ls+Yi5DMpK6wFwspuCJoAo5jQ7V/Ijc=; b=HTjtrTCPCtqlucaZeYXO9hdRWKKNAckT7ekZDJXF4mJhpipaNA9I2CNaZ2kSj9hZ8JMDfd x8O+SqhSx6dStv8V30+AeWP2e15nVJrSHFhqsats/yWfEKX2i5V8jL8upV5bG1UT+dmM/5 7kohKTXNMLmKBR1LDF3Ev3cAOymTgN8= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-505-pV80qt3VOUSnsS_Rw6OHXw-1; Fri, 10 Apr 2020 15:34:23 -0400 X-MC-Unique: pV80qt3VOUSnsS_Rw6OHXw-1 Received: by mail-qk1-f197.google.com with SMTP id w21so2898663qkj.18 for ; Fri, 10 Apr 2020 12:34:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dR0pnT92lTl7PiXH1/vycyqLlKqG/upjftJ1HpISkMA=; b=e5n612HzCtLX0ff95bO59RnYaF3dnfWTLKhYJqiVnhxIhkuY6vBcIn8PdEg39VqWNc we9uccQyg4P1LT71qJ4LzPJp/Rj15lQr3wkWxxLcrsZM47C8D3WPgd5gIAuWC4r2rk+c eAz0kzRzD706KkkLL1j5AvasbIrwUYBKt1Kt9sacskLRBMR+h7+N6y6ygb9DPclqVcY2 y95yIvVcowT3HgJTBqW9WTPLzTFQr6uwX5MPasFnm5WTEjlqiCSAX98M0hIr+M8rB6SU 4aNqMutnm6bqJw1rks4PSfqcTK7XnPO/R8aaVxg0JLUBNkfg9KrPYzOtZTq0QVYbOIYT PboQ== X-Gm-Message-State: AGi0PuY6ffXfviNZJgYNvh2q0QhM/ZfeD3DoIPx/PMpcK3bvssH3fE+1 +X2NMG3rFwiCujqDLY1hgBKgGPqIQJ3fOdQ4Ohy55fMHjktt59uQIuteXdqOqLJBlY9PmBm86F8 4yl7nxL2kbryWSXt/6kxjzUMhWw== X-Received: by 2002:ac8:6d06:: with SMTP id o6mr768745qtt.165.1586547263230; Fri, 10 Apr 2020 12:34:23 -0700 (PDT) X-Google-Smtp-Source: APiQypKE+9gdKAAzqM7E075abKl7yEhzpSisddiPAFgdbjLHprLwAVDEdymEnBo0qMB8GT4NFqVJjg== X-Received: by 2002:ac8:6d06:: with SMTP id o6mr768725qtt.165.1586547263017; Fri, 10 Apr 2020 12:34:23 -0700 (PDT) Received: from xz-x1 ([2607:9880:19c0:32::2]) by smtp.gmail.com with ESMTPSA id m11sm2214328qkg.130.2020.04.10.12.34.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2020 12:34:22 -0700 (PDT) Date: Fri, 10 Apr 2020 15:34:19 -0400 From: Peter Xu To: Mike Kravetz Subject: Re: [PATCH v2 3/4] hugetlbfs: remove hugetlb_add_hstate() warning for existing hstate Message-ID: <20200410193419.GF3172@xz-x1> References: <20200401183819.20647-1-mike.kravetz@oracle.com> <20200401183819.20647-4-mike.kravetz@oracle.com> MIME-Version: 1.0 In-Reply-To: <20200401183819.20647-4-mike.kravetz@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-doc@vger.kernel.org, Catalin Marinas , Dave Hansen , Heiko Carstens , linux-mm@kvack.org, Paul Mackerras , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Will Deacon , Mina Almasry , linux-s390@vger.kernel.org, Jonathan Corbet , Christian Borntraeger , Ingo Molnar , Longpeng , Albert Ou , Vasily Gorbik , Paul Walmsley , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Apr 01, 2020 at 11:38:18AM -0700, Mike Kravetz wrote: [...] > @@ -3255,7 +3254,6 @@ void __init hugetlb_add_hstate(unsigned int order) > =09unsigned long i; > =20 > =09if (size_to_hstate(PAGE_SIZE << order)) { > -=09=09pr_warn("hugepagesz=3D specified twice, ignoring\n"); > =09=09return; > =09} Nitpick: I think the brackets need to be removed to follow linux coding style. With that: Reviewed-by: Peter Xu --=20 Peter Xu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1B18C2BB55 for ; Fri, 10 Apr 2020 19:34:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 72D2D206C1 for ; Fri, 10 Apr 2020 19:34:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EBPKWMug"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HTjtrTCP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 72D2D206C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ynJr1I2k6Qk617HngD4XXqhs9Q1aImTmIXMfJI5S4ck=; b=EBPKWMugeJVAzp qIwnrGIWWGaVj07dfZ11oaqDzfs5T8HoMyDrd1CzU54YRUrAha4YtKlonJcMdkozXrtXtHdZdwyOn U6Rw8L2x8i8o1RzCphfYhtDf9JmED9sNPMF7pfMd4F/5+KnznP9Z37Eyqr/w70shO6rwJMFP2XsP8 DbIhP8Px6ilKZRxyxD7+5FbdrRDaKRi4+I6n5F6WlCxv8KFoxXJJ4Xa3ZZxkLNyjI33GDYKQqiily 9U/7gQ3iwAmOw+m0qj3ezAHyt/Ds2+2OsM/M067AhPCO2iY2+oYBqLnGLFiuoMT1UnxxC1mjcIimC E5AKdO1RuKuHy/CokTyg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMzQ8-0002pC-Gq; Fri, 10 Apr 2020 19:34:32 +0000 Received: from us-smtp-1.mimecast.com ([207.211.31.81] helo=us-smtp-delivery-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMzQ5-0002lu-8a for linux-arm-kernel@lists.infradead.org; Fri, 10 Apr 2020 19:34:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586547265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pSDLH5WsDUY0Ls+Yi5DMpK6wFwspuCJoAo5jQ7V/Ijc=; b=HTjtrTCPCtqlucaZeYXO9hdRWKKNAckT7ekZDJXF4mJhpipaNA9I2CNaZ2kSj9hZ8JMDfd x8O+SqhSx6dStv8V30+AeWP2e15nVJrSHFhqsats/yWfEKX2i5V8jL8upV5bG1UT+dmM/5 7kohKTXNMLmKBR1LDF3Ev3cAOymTgN8= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-505-VPqh-TJFPLits0HAweB96w-1; Fri, 10 Apr 2020 15:34:23 -0400 X-MC-Unique: VPqh-TJFPLits0HAweB96w-1 Received: by mail-qt1-f199.google.com with SMTP id x7so2670314qtv.23 for ; Fri, 10 Apr 2020 12:34:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dR0pnT92lTl7PiXH1/vycyqLlKqG/upjftJ1HpISkMA=; b=i4oGko1NpxFOR4Cx58pNQQbVHOF1ykJRO/W5sEkHtjDuQ4tPzOGGJhufkaQunhMOxU U2CD0cnb1FpdEwf2XwuJP/kLkeGhqI5TUVhARdewkhVTnA+j7jJNNqVOgdGvgImTEuNj jzvNQeIgOynicjylie3zoqgg1wffoUg3Xca0eJNR2z17Rj0Cbi6iuTi1fXxVt8+8eQwS 5NzmU7SImqc0u7CQTpIT1xUvHAIecjtOmsaZy1jEbD1vLZWNXgjNskek+8h+yE/7y+bz FHwiZj701++3+GpUZylwwFiXHHmcmzGF8+FB8+B5xCOLSRLtGgG9q/egIDBLbRIOVrKV SDlw== X-Gm-Message-State: AGi0PuanJkDBn5cKkJOPIH84D1UCbW7Hu3mlzHZhUpPGa6g/VzLslbkG av7ZlDr6kEy1vGhwbW54IE4nfrzl/4/QJHpfL86fsJZZoHAr7TCvzKoytARz48Fuw3ChvDnpxq2 CcpTwhG/C6FjGO97BT30rCTj+QllKj2JGcTo= X-Received: by 2002:ac8:6d06:: with SMTP id o6mr768750qtt.165.1586547263230; Fri, 10 Apr 2020 12:34:23 -0700 (PDT) X-Google-Smtp-Source: APiQypKE+9gdKAAzqM7E075abKl7yEhzpSisddiPAFgdbjLHprLwAVDEdymEnBo0qMB8GT4NFqVJjg== X-Received: by 2002:ac8:6d06:: with SMTP id o6mr768725qtt.165.1586547263017; Fri, 10 Apr 2020 12:34:23 -0700 (PDT) Received: from xz-x1 ([2607:9880:19c0:32::2]) by smtp.gmail.com with ESMTPSA id m11sm2214328qkg.130.2020.04.10.12.34.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2020 12:34:22 -0700 (PDT) Date: Fri, 10 Apr 2020 15:34:19 -0400 From: Peter Xu To: Mike Kravetz Subject: Re: [PATCH v2 3/4] hugetlbfs: remove hugetlb_add_hstate() warning for existing hstate Message-ID: <20200410193419.GF3172@xz-x1> References: <20200401183819.20647-1-mike.kravetz@oracle.com> <20200401183819.20647-4-mike.kravetz@oracle.com> MIME-Version: 1.0 In-Reply-To: <20200401183819.20647-4-mike.kravetz@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200410_123429_376056_0A242380 X-CRM114-Status: UNSURE ( 9.30 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-doc@vger.kernel.org, Catalin Marinas , Dave Hansen , Heiko Carstens , linux-mm@kvack.org, Paul Mackerras , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Will Deacon , Mina Almasry , linux-s390@vger.kernel.org, Jonathan Corbet , Christian Borntraeger , Ingo Molnar , Benjamin Herrenschmidt , Longpeng , Albert Ou , Vasily Gorbik , Paul Walmsley , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Christophe Leroy , linux-kernel@vger.kernel.org, Palmer Dabbelt , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 01, 2020 at 11:38:18AM -0700, Mike Kravetz wrote: [...] > @@ -3255,7 +3254,6 @@ void __init hugetlb_add_hstate(unsigned int order) > unsigned long i; > > if (size_to_hstate(PAGE_SIZE << order)) { > - pr_warn("hugepagesz= specified twice, ignoring\n"); > return; > } Nitpick: I think the brackets need to be removed to follow linux coding style. With that: Reviewed-by: Peter Xu -- Peter Xu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel