From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9B5DC2BB85 for ; Sat, 11 Apr 2020 12:18:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 842A720692 for ; Sat, 11 Apr 2020 12:18:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586607518; bh=TbektKIgaerYCMWhEVnLN4HE7XH2Tyju6LGW1nFAOAg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=uMEl2QFwK4Un7XdXW/DYrQPvOdN/lsf9EMD4+g7LT2qxsmgWY0zWA6Vo0kZFG2SMj SWsgVx0ZxvSH7sXUmqmO7YDJ0rHjag9lzDxdpwSNxnSCeTmhRa5HzV8M73TVQ6BGI4 bL1u+u3P2iZSl+BWcANL7GqJv2QtwraCUsK5Ga5M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728640AbgDKMSg (ORCPT ); Sat, 11 Apr 2020 08:18:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:53544 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728637AbgDKMSc (ORCPT ); Sat, 11 Apr 2020 08:18:32 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7743C20644; Sat, 11 Apr 2020 12:18:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586607512; bh=TbektKIgaerYCMWhEVnLN4HE7XH2Tyju6LGW1nFAOAg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BwZjrzXixptJuZTNR+ZoShMXmCXSgqFVp5QgRCLHpZh0Yq89+3guqoNiBnpf7WZbP knLbXaS3UBNiQHTcL9YewdOzip85fDGYY+I2hHgXLnFeFKQjqfp9U1W0+kzDVwChWi 5mDH94wJwkq9qH/PYJ5bLkYKmR55XB8dNFLId3H8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Herat Ramani , Rahul Lakkireddy , "David S. Miller" Subject: [PATCH 5.5 01/44] cxgb4: fix MPS index overwrite when setting MAC address Date: Sat, 11 Apr 2020 14:09:21 +0200 Message-Id: <20200411115457.049224792@linuxfoundation.org> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200411115456.934174282@linuxfoundation.org> References: <20200411115456.934174282@linuxfoundation.org> User-Agent: quilt/0.66 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Herat Ramani [ Upstream commit 41aa8561ca3fc5748391f08cc5f3e561923da52c ] cxgb4_update_mac_filt() earlier requests firmware to add a new MAC address into MPS TCAM. The MPS TCAM index returned by firmware is stored in pi->xact_addr_filt. However, the saved MPS TCAM index gets overwritten again with the return value of cxgb4_update_mac_filt(), which is wrong. When trying to update to another MAC address later, the wrong MPS TCAM index is sent to firmware, which causes firmware to return error, because it's not the same MPS TCAM index that firmware had sent earlier to driver. So, fix by removing the wrong overwrite being done after call to cxgb4_update_mac_filt(). Fixes: 3f8cfd0d95e6 ("cxgb4/cxgb4vf: Program hash region for {t4/t4vf}_change_mac()") Signed-off-by: Herat Ramani Signed-off-by: Rahul Lakkireddy Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c @@ -3110,7 +3110,6 @@ static int cxgb_set_mac_addr(struct net_ return ret; memcpy(dev->dev_addr, addr->sa_data, dev->addr_len); - pi->xact_addr_filt = ret; return 0; }