From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91546C2BBC7 for ; Sat, 11 Apr 2020 12:22:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B5E620644 for ; Sat, 11 Apr 2020 12:22:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586607740; bh=datS3IKUZA9bgjNevrozUDfBcVDSvmpXzGjOJIW+x4A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=2vkprSpWbT2Y3aKGScnMO1KeCevUXDGuyx460NAiDcKErsf7/mqU2dtLdGYC1CCSU SU4YGqi4TDFtxBPMXH1wzJ8ONAYVjcINK2GTWBRewLqfkzDaP4OBgqseG9e6sUlmqp euTc4YUxOL+7V9bF64swiRCsPKGmG+tcj2AXypAc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728217AbgDKMWS (ORCPT ); Sat, 11 Apr 2020 08:22:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:57758 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728953AbgDKMV2 (ORCPT ); Sat, 11 Apr 2020 08:21:28 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7243820644; Sat, 11 Apr 2020 12:21:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586607687; bh=datS3IKUZA9bgjNevrozUDfBcVDSvmpXzGjOJIW+x4A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=M31vO071URnDQyCs4bae2rQbCVSGfZQvqO1Ko+8v+s825Ejv9euU2nahwQ6pNbgSY gL+CNeFIk6nss+C0ff/unzHtqd4JpBDskykvXLM3be2+Sh8e+4kDUhYpbdwx8Gd5uF OwVZJvv4AKns9dOQprrbIIryhPdZMzDCp3cMhaI0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+8325e509a1bf83ec741d@syzkaller.appspotmail.com, Jamal Hadi Salim , Jiri Pirko , "Paul E. McKenney" , Cong Wang , "David S. Miller" Subject: [PATCH 5.6 08/38] net_sched: fix a missing refcnt in tcindex_init() Date: Sat, 11 Apr 2020 14:09:45 +0200 Message-Id: <20200411115500.208523742@linuxfoundation.org> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200411115459.324496182@linuxfoundation.org> References: <20200411115459.324496182@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Cong Wang [ Upstream commit a8eab6d35e22f4f21471f16147be79529cd6aaf7 ] The initial refcnt of struct tcindex_data should be 1, it is clear that I forgot to set it to 1 in tcindex_init(). This leads to a dec-after-zero warning. Reported-by: syzbot+8325e509a1bf83ec741d@syzkaller.appspotmail.com Fixes: 304e024216a8 ("net_sched: add a temporary refcnt for struct tcindex_data") Cc: Jamal Hadi Salim Cc: Jiri Pirko Cc: Paul E. McKenney Signed-off-by: Cong Wang Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/sched/cls_tcindex.c | 1 + 1 file changed, 1 insertion(+) --- a/net/sched/cls_tcindex.c +++ b/net/sched/cls_tcindex.c @@ -151,6 +151,7 @@ static int tcindex_init(struct tcf_proto p->mask = 0xffff; p->hash = DEFAULT_HASH_SIZE; p->fall_through = 1; + refcount_set(&p->refcnt, 1); /* Paired with tcindex_destroy_work() */ rcu_assign_pointer(tp->root, p); return 0;