Re: [RFC PATCH bpf-next 5/8] bpf: add support for BPF_OBJ_GET_INFO_BY_FD for bpf_link

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3199 bytes --]

Hi Andrii,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on bpf-next/master]
[also build test ERROR on bpf/master cgroup/for-next net/master net-next/master next-20200410]
[cannot apply to ipvs/master v5.6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Andrii-Nakryiko/bpf_link-observability-APIs/20200405-051753
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: arm-randconfig-a001-20200410 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 7149bb70681a91de5d490b4bb0714d9e55a05bcc)
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER=clang make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   arm-linux-gnueabi-ld: section .data VMA [0000000000808000,0000000000864f3f] overlaps section .rodata VMA [00000000005c1000,0000000000a95aaf]
   arm-linux-gnueabi-ld: kernel/bpf/syscall.o: in function `bpf_raw_tp_link_fill_link_info':
>> kernel/bpf/syscall.c:2569: undefined reference to `__get_user_bad'

vim +2569 kernel/bpf/syscall.c

  2553	
  2554	static int bpf_raw_tp_link_fill_link_info(const struct bpf_link *link,
  2555						  struct bpf_link_info *info,
  2556						  const struct bpf_link_info *uinfo,
  2557						  u32 info_len)
  2558	{
  2559		struct bpf_raw_tp_link *raw_tp_link =
  2560			container_of(link, struct bpf_raw_tp_link, link);
  2561		u64 ubuf_ptr;
  2562		char __user *ubuf = u64_to_user_ptr(uinfo->raw_tracepoint.tp_name);
  2563		const char *tp_name = raw_tp_link->btp->tp->name;
  2564		size_t tp_len;
  2565		u32 ulen;
  2566	
  2567		if (get_user(ulen, &uinfo->raw_tracepoint.tp_name_len))
  2568			return -EFAULT;
> 2569		if (get_user(ubuf_ptr, &uinfo->raw_tracepoint.tp_name))
  2570			return -EFAULT;
  2571		ubuf = u64_to_user_ptr(ubuf_ptr);
  2572	
  2573		if (ulen && !ubuf)
  2574			return -EINVAL;
  2575		if (!ubuf)
  2576			return 0;
  2577	
  2578		tp_len = strlen(raw_tp_link->btp->tp->name);
  2579		info->raw_tracepoint.tp_name_len = tp_len + 1;
  2580		info->raw_tracepoint.tp_name = (u64)(unsigned long)ubuf;
  2581	
  2582		if (ulen >= tp_len + 1) {
  2583			if (copy_to_user(ubuf, tp_name, tp_len + 1))
  2584				return -EFAULT;
  2585		} else {
  2586			char zero = '\0';
  2587	
  2588			if (copy_to_user(ubuf, tp_name, ulen - 1))
  2589				return -EFAULT;
  2590			if (put_user(zero, ubuf + ulen - 1))
  2591				return -EFAULT;
  2592			return -ENOSPC;
  2593		}
  2594	
  2595		return 0;
  2596	}
  2597	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 27586 bytes --]