From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00DA3C2BB86 for ; Sat, 11 Apr 2020 23:20:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C578D206E9 for ; Sat, 11 Apr 2020 23:20:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586647220; bh=jWoyqSUU07sYEU1UjFNbY1H68a7iDoGPS5E7M05h0mk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=pgYPQrAD1spgt0+EbWiysQNGJ75IiI2YEUg35lQ9iLCP5GV6d48vnnPp2RAw0nAlY uZXA0V/qR3D36J8u4IgSts3jkH1kvhN25o0/QUOKocoaapXsPqV4zh6I8E5yijz84q /1uu++jKt46upbpDlTkrA/hT31CB18sry2wSAw8U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730006AbgDKXUT (ORCPT ); Sat, 11 Apr 2020 19:20:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:55028 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730538AbgDKXNm (ORCPT ); Sat, 11 Apr 2020 19:13:42 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3D1C221744; Sat, 11 Apr 2020 23:13:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586646823; bh=jWoyqSUU07sYEU1UjFNbY1H68a7iDoGPS5E7M05h0mk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y1dcQqzQdzknzpjMzbrPlnFd36pBCO1OLBCVtvGt7A+eK+QnmjxBhqvOAmpAXYfbk GQdITemwO3UPDQjGIkxFSK8uMBHhHT8FG/DSemRw+uhrX02hQSeHgh4rzWraJsTrmW 1XT8edeHLyTCuAZYhHt/hroTvYKYqsVsXOOLTU7c= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Vlad Buslov , Roi Dayan , Sasha Levin , netdev@vger.kernel.org, linux-rdma@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 13/37] net/mlx5e: Init ethtool steering for representors Date: Sat, 11 Apr 2020 19:13:02 -0400 Message-Id: <20200411231327.26550-13-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200411231327.26550-1-sashal@kernel.org> References: <20200411231327.26550-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Vlad Buslov [ Upstream commit 6783e8b29f636383af293a55336f036bc7ad5619 ] During transition to uplink representors the code responsible for initializing ethtool steering functionality wasn't added to representor init rx routine. This causes NULL pointer dereference during configuration of network flow classification rule with ethtool (only possible to reproduce with next commit in this series which registers necessary ethtool callbacks). Signed-off-by: Vlad Buslov Reviewed-by: Roi Dayan Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c index e69674d38f167..1d04280b775f0 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c @@ -893,6 +893,8 @@ static int mlx5e_init_rep_rx(struct mlx5e_priv *priv) if (err) goto err_del_flow_rule; + mlx5e_ethtool_init_steering(priv); + return 0; err_del_flow_rule: -- 2.20.1