From: "Frédéric Pierret (fepitre)" <frederic.pierret@qubes-os.org>
To: boris.ostrovsky@oracle.com, jgross@suse.com,
sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, x86@kernel.org, hpa@zytor.com,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: "Frédéric Pierret (fepitre)" <frederic.pierret@qubes-os.org>
Subject: [PATCH v2] xen x86: fix early boot crash with gcc-10
Date: Mon, 13 Apr 2020 17:03:14 +0200 [thread overview]
Message-ID: <20200413150314.13974-1-frederic.pierret@qubes-os.org> (raw)
In-Reply-To: <20200413142051.GC3772@zn.tnic>
The change fixes boot failure on VM where kernel (at least v5.4 and v5.6)
is built with gcc-10 and STACKPROTECTOR_STRONG enabled:
```
Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: cpu_bringup_and_idle+0x93/0xa0
CPU: 1 PID: 0 Comm: swapper/1 Not tainted 5.4.31-1.qubes.x86_64 #1
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.12.0-1 04/01/2014
Call Trace:
dump_stack+0x64/0x88
panic+0x10b/0x2ed
? cpu_bringup_and_idle+0x93/0xa0
__stack_chk_fail+0x15/0x20
cpu_bringup_and_idle+0x93/0xa
```
The change makes successfully booting the VM. The VM is hosted by
KVM hypervisor and is running Xen into.
Based on work done by Sergei Trofimovich: https://lkml.org/lkml/2020/3/26/1133
Signed-off-by: Frédéric Pierret (fepitre) <frederic.pierret@qubes-os.org>
---
arch/x86/xen/smp_pv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/xen/smp_pv.c b/arch/x86/xen/smp_pv.c
index 8fb8a50a28b4..5c8ee4a5bb0c 100644
--- a/arch/x86/xen/smp_pv.c
+++ b/arch/x86/xen/smp_pv.c
@@ -88,7 +88,7 @@ static void cpu_bringup(void)
local_irq_enable();
}
-asmlinkage __visible void cpu_bringup_and_idle(void)
+asmlinkage __visible void __no_stack_protector cpu_bringup_and_idle(void)
{
cpu_bringup();
boot_init_stack_canary();
--
2.25.2
next prev parent reply other threads:[~2020-04-13 15:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 12:35 [PATCH] xen x86: fix early boot crash with gcc-10 Frédéric Pierret (fepitre)
2020-04-13 14:20 ` Borislav Petkov
2020-04-13 14:20 ` Borislav Petkov
2020-04-13 15:03 ` Frédéric Pierret (fepitre) [this message]
2020-04-13 17:41 ` [PATCH v2] " Borislav Petkov
2020-04-13 17:41 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413150314.13974-1-frederic.pierret@qubes-os.org \
--to=frederic.pierret@qubes-os.org \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.