All of lore.kernel.org
 help / color / mirror / Atom feed
From: "José Roberto de Souza" <jose.souza@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH v4 5/9] drm/i915/tc: Skip ref held check for TC legacy aux power wells
Date: Mon, 13 Apr 2020 09:45:11 -0700	[thread overview]
Message-ID: <20200413164515.13355-5-jose.souza@intel.com> (raw)
In-Reply-To: <20200413164515.13355-1-jose.souza@intel.com>

As part of ICL TC cold exit sequences we need to request aux power
well before lock the access to TC ports, so skiping the
intel_tc_port_ref_held() check for TC legacy ports.

Reviewed-by: Imre Deak <imre.deak@intel.com>
Tested-by: You-Sheng Yang <vicamo.yang@canonical.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_power.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index e2dddaf1051b..50bed2d1dd13 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -560,6 +560,9 @@ static void icl_tc_port_assert_ref_held(struct drm_i915_private *dev_priv,
 	if (drm_WARN_ON(&dev_priv->drm, !dig_port))
 		return;
 
+	if (INTEL_GEN(dev_priv) == 11 && dig_port->tc_legacy_port)
+		return;
+
 	drm_WARN_ON(&dev_priv->drm, !intel_tc_port_ref_held(dig_port));
 }
 
-- 
2.26.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2020-04-13 16:43 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-13 16:45 [Intel-gfx] [PATCH v4 1/9] drm/i915/display: Move out code to return the digital_port of the aux ch José Roberto de Souza
2020-04-13 16:45 ` [Intel-gfx] [PATCH v4 2/9] drm/i915/display: Add intel_legacy_aux_to_power_domain() José Roberto de Souza
2020-04-13 16:45 ` [Intel-gfx] [PATCH v4 3/9] drm/i915/display: Split hsw_power_well_enable() into two José Roberto de Souza
2020-04-13 16:45 ` [Intel-gfx] [PATCH v4 4/9] drm/i915/tc/icl: Implement TC cold sequences José Roberto de Souza
2020-04-14 17:31   ` Imre Deak
2020-04-13 16:45 ` José Roberto de Souza [this message]
2020-04-13 16:45 ` [Intel-gfx] [PATCH v4 6/9] drm/i915/tc/tgl: " José Roberto de Souza
2020-04-14 17:39   ` Imre Deak
2020-04-14 17:41     ` Souza, Jose
2020-04-14 19:02       ` Imre Deak
2020-04-13 16:45 ` [Intel-gfx] [PATCH v4 7/9] drm/i915/tc: Catch TC users accessing FIA registers without enable aux José Roberto de Souza
2020-04-13 16:45 ` [Intel-gfx] [PATCH v4 8/9] drm/i915/tc: Do not warn when aux power well of static TC ports timeout José Roberto de Souza
2020-04-14 17:47   ` Imre Deak
2020-04-14 18:05     ` Souza, Jose
2020-04-13 16:45 ` [Intel-gfx] [PATCH v4 9/9] drm/i915: Add missing deinitialization cases of load failure José Roberto de Souza
2020-04-14 18:29   ` Imre Deak
2020-04-14 20:50     ` Souza, Jose
2020-04-14 20:01 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v4,1/9] drm/i915/display: Move out code to return the digital_port of the aux ch Patchwork
2020-04-14 20:21 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2020-04-14 20:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-04-15 12:05 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200413164515.13355-5-jose.souza@intel.com \
    --to=jose.souza@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.