From: Matt Roper <matthew.d.roper@intel.com>
To: Matt Atwood <matthew.s.atwood@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/ehl: extended Wa_2006604312 to ehl
Date: Mon, 13 Apr 2020 13:58:02 -0700 [thread overview]
Message-ID: <20200413205802.GE2630258@mdroper-desk1.amr.corp.intel.com> (raw)
In-Reply-To: <20200413175322.12162-1-matthew.s.atwood@intel.com>
On Mon, Apr 13, 2020 at 01:53:22PM -0400, Matt Atwood wrote:
> Reflect recent bspec changes.
>
> Bspec: 33451
>
> Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
Matches the updated spec.
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 70ec301fe6e3..415d1fff0362 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -525,7 +525,7 @@ skl_wa_827(struct drm_i915_private *dev_priv, enum pipe pipe, bool enable)
> intel_de_read(dev_priv, CLKGATE_DIS_PSL(pipe)) & ~(DUPS1_GATING_DIS | DUPS2_GATING_DIS));
> }
>
> -/* Wa_2006604312:icl */
> +/* Wa_2006604312:icl,ehl */
> static void
> icl_wa_scalerclkgating(struct drm_i915_private *dev_priv, enum pipe pipe,
> bool enable)
> @@ -6438,8 +6438,8 @@ static bool needs_scalerclk_wa(const struct intel_crtc_state *crtc_state)
> {
> struct drm_i915_private *dev_priv = to_i915(crtc_state->uapi.crtc->dev);
>
> - /* Wa_2006604312:icl */
> - if (crtc_state->scaler_state.scaler_users > 0 && IS_ICELAKE(dev_priv))
> + /* Wa_2006604312:icl,ehl */
> + if (crtc_state->scaler_state.scaler_users > 0 && IS_GEN(dev_priv, 11))
> return true;
>
> return false;
> @@ -6509,7 +6509,7 @@ static void intel_pre_plane_update(struct intel_atomic_state *state,
> needs_nv12_wa(new_crtc_state))
> skl_wa_827(dev_priv, pipe, true);
>
> - /* Wa_2006604312:icl */
> + /* Wa_2006604312:icl,ehl */
> if (!needs_scalerclk_wa(old_crtc_state) &&
> needs_scalerclk_wa(new_crtc_state))
> icl_wa_scalerclkgating(dev_priv, pipe, true);
> --
> 2.21.1
>
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-04-13 20:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 17:53 [Intel-gfx] [PATCH] drm/i915/ehl: extended Wa_2006604312 to ehl Matt Atwood
2020-04-13 20:58 ` Matt Roper [this message]
2020-04-14 21:15 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
2020-04-14 21:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-04-15 12:19 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-04-15 20:36 ` Matt Roper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413205802.GE2630258@mdroper-desk1.amr.corp.intel.com \
--to=matthew.d.roper@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.s.atwood@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.