From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28ABEC2BA19 for ; Tue, 14 Apr 2020 11:30:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0AE120768 for ; Tue, 14 Apr 2020 11:30:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Wd48rBg/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439168AbgDNLab (ORCPT ); Tue, 14 Apr 2020 07:30:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2439160AbgDNLaJ (ORCPT ); Tue, 14 Apr 2020 07:30:09 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 910D4C061A0C; Tue, 14 Apr 2020 04:30:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CIUrbcmj1xhW3MOaPe81Ur6/xKrEzd9msEFn9mkphaA=; b=Wd48rBg/0x0CXzD+KRzC20Aj12 3q2vCAAoyKJtZiWfj5RrnksBszf30fdP56w1lVxUfY9YPrnTeS/YjMCJugR973FvGBfuiVREliaIL 57LVWXx9aZe5HuOQXnM5IZDfSHk0hzE+FdIeGN8pdWuPS91xnQelXWvJBSg4FeIK9v7dEhcqcGedC 2zkwbFgR3ncFRlY1SKieVy8LZ6B/vl2XoN8uY3LuMC5pE4V6zm0YgBfzhP9DrMCnDjr8bv09aXaFY 4Q5SJh8O3X8Tf3TvMkKyDHDpiz5bYmBGjv3VyJ2nQrluSqUEae2vjDHDRz6GIV5Njcups4z/408PZ t3uzYQng==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOJlY-0001Eu-J2; Tue, 14 Apr 2020 11:30:08 +0000 Date: Tue, 14 Apr 2020 04:30:08 -0700 From: "hch@infradead.org" To: Johannes Thumshirn Cc: "hch@infradead.org" , Jens Axboe , linux-block , Damien Le Moal , Keith Busch , "linux-scsi @ vger . kernel . org" , "Martin K . Petersen" , "linux-fsdevel @ vger . kernel . org" Subject: Re: [PATCH v5 07/10] scsi: sd_zbc: emulate ZONE_APPEND commands Message-ID: <20200414113008.GB26599@infradead.org> References: <20200409165352.2126-1-johannes.thumshirn@wdc.com> <20200409165352.2126-8-johannes.thumshirn@wdc.com> <20200410061822.GB4791@infradead.org> <20200410063855.GC4791@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Apr 14, 2020 at 11:09:41AM +0000, Johannes Thumshirn wrote: > On 10/04/2020 08:39, Christoph Hellwig wrote: > > Looking more the situation seems even worse. If scsi_mq_prep_fn > > isn't successfull we never seem to free the sgtables, even for fatal > > errors. So I think we need a real bug fix here in front of the series > > If I'm not missing something all that needs to be done to fix it is: Looks sensible.