All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philipp Puschmann <p.puschmann@pironex.de>
To: broonie@kernel.org
Cc: alsa-devel@alsa-project.org, cernekee@chromium.org,
	lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
	nhuck@google.com, p.puschmann@pironex.de, tglx@linutronix.de
Subject: Re: Re: [PATCH] ASoC: tas571x: disable regulators on failed probe
Date: Tue, 14 Apr 2020 14:25:40 +0200	[thread overview]
Message-ID: <20200414122540.3367658-1-p.puschmann@pironex.de> (raw)
In-Reply-To: <20200414113635.GD5412@sirena.org.uk>

>> If probe fails after enabling the regulators regulator_put is called for
>> each supply without having them disabled before. This produces some
>> warnings like
>>=20
>> WARNING: CPU: 0 PID: 90 at drivers/regulator/core.c:2044 _regulator_put.part.0+0x154/0x15c
>> [<c010f7a8>] (unwind_backtrace) from [<c010c544>] (show_stack+0x10/0x14)
>> [<c010c544>] (show_stack) from [<c012b640>] (__warn+0xd0/0xf4)
>> [<c012b640>] (__warn) from [<c012b9b4>] (warn_slowpath_fmt+0x64/0xc4)
>> [<c012b9b4>] (warn_slowpath_fmt) from [<c04c4064>] (_regulator_put.part.0+0x154/0x15c)
>
>Please think hard before including complete backtraces in upstream
>reports, they are very large and contain almost no useful information
>relative to their size so often obscure the relevant content in your
>message. If part of the backtrace is usefully illustrative (it often is
>for search engines if nothing else) then it's usually better to pull out
>the relevant sections.

You are right. I will take care next time.

Regards,
Philipp

WARNING: multiple messages have this Message-ID
From: Philipp Puschmann <p.puschmann@pironex.de>
To: broonie@kernel.org
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	lgirdwood@gmail.com, nhuck@google.com, p.puschmann@pironex.de,
	tglx@linutronix.de, cernekee@chromium.org
Subject: Re: Re: [PATCH] ASoC: tas571x: disable regulators on failed probe
Date: Tue, 14 Apr 2020 14:25:40 +0200	[thread overview]
Message-ID: <20200414122540.3367658-1-p.puschmann@pironex.de> (raw)
In-Reply-To: <20200414113635.GD5412@sirena.org.uk>

>> If probe fails after enabling the regulators regulator_put is called for
>> each supply without having them disabled before. This produces some
>> warnings like
>>=20
>> WARNING: CPU: 0 PID: 90 at drivers/regulator/core.c:2044 _regulator_put.part.0+0x154/0x15c
>> [<c010f7a8>] (unwind_backtrace) from [<c010c544>] (show_stack+0x10/0x14)
>> [<c010c544>] (show_stack) from [<c012b640>] (__warn+0xd0/0xf4)
>> [<c012b640>] (__warn) from [<c012b9b4>] (warn_slowpath_fmt+0x64/0xc4)
>> [<c012b9b4>] (warn_slowpath_fmt) from [<c04c4064>] (_regulator_put.part.0+0x154/0x15c)
>
>Please think hard before including complete backtraces in upstream
>reports, they are very large and contain almost no useful information
>relative to their size so often obscure the relevant content in your
>message. If part of the backtrace is usefully illustrative (it often is
>for search engines if nothing else) then it's usually better to pull out
>the relevant sections.

You are right. I will take care next time.

Regards,
Philipp

  reply	other threads:[~2020-04-14 12:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14 11:27 Philipp Puschmann
2020-04-14 11:36 ` Mark Brown
2020-04-14 11:36   ` Mark Brown
2020-04-14 12:25   ` Philipp Puschmann [this message]
2020-04-14 12:25     ` Philipp Puschmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200414122540.3367658-1-p.puschmann@pironex.de \
    --to=p.puschmann@pironex.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=cernekee@chromium.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nhuck@google.com \
    --cc=tglx@linutronix.de \
    --subject='Re: Re: [PATCH] ASoC: tas571x: disable regulators on failed probe' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.