From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,LOTS_OF_MONEY,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8AE7C2BA19 for ; Tue, 14 Apr 2020 13:06:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B138A2087E for ; Tue, 14 Apr 2020 13:06:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730286AbgDNNGL (ORCPT ); Tue, 14 Apr 2020 09:06:11 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:47487 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2502549AbgDNNF2 (ORCPT ); Tue, 14 Apr 2020 09:05:28 -0400 Received: from mail-wr1-f72.google.com ([209.85.221.72]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jOLFk-0003iN-Et for linux-kernel@vger.kernel.org; Tue, 14 Apr 2020 13:05:24 +0000 Received: by mail-wr1-f72.google.com with SMTP id f2so199715wrm.9 for ; Tue, 14 Apr 2020 06:05:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+KnW4LJj0j2KwQVBjToQQXs5Y7CG2Nx5bqAdyxNE0Dw=; b=j4B6y33Mis3vKnwaMo2F9lNwy26rrkJZfvYsGh0JxFTZl6+4V3vE4z+1iQNeA/k+xc 0sD5qx1Ut8vi2+U21nvtR9gmh2gN2KklqAZmZx58SwPX7aOlhMN/A8KYkZf1wW/f/YVT Shsp1G6VOaIk+KgoTOiRcPien4yPhukcruk4YPpkjRlDcPiA91iA791gwXXiCyg4ouqz AbWg5Vv1Zk/YxF++1emF/IysC6wVlOs96YVbUlOchnn/jJrU7tzmQWvn2Y3XEhRhPA47 nJt1clO2qUWCjQNFy3e1GeKSA59zVIVUB426iEX3yVdOLSYgSWGkjyjgKxlINTvct5vi sjKw== X-Gm-Message-State: AGi0Pua1xzLpLX/gRgN+XO+L5ac3/2vSBiz+4W8SvJunfnO+M0Z3BOu+ 4RdnExOvEphNLspCy9v7lefk1uwvkunX3z34tJEBoRqLK44tasmlnXXSBw6zgkJi+MBf4Y3OdXA xcTpFrnLDOYoCEtvlES1m4ldZI8/HpC2heTeKwecrMA== X-Received: by 2002:adf:ea02:: with SMTP id q2mr6710189wrm.31.1586869523776; Tue, 14 Apr 2020 06:05:23 -0700 (PDT) X-Google-Smtp-Source: APiQypLb6P5gGJzAmIBulAT/+s6AnCdCcFWFOfWJdOzchWdVYExDBrlH3FfJ60yekarz85p6KoXxog== X-Received: by 2002:adf:ea02:: with SMTP id q2mr6710150wrm.31.1586869523195; Tue, 14 Apr 2020 06:05:23 -0700 (PDT) Received: from localhost (host123-127-dynamic.36-79-r.retail.telecomitalia.it. [79.36.127.123]) by smtp.gmail.com with ESMTPSA id i17sm9114359wru.39.2020.04.14.06.05.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 06:05:22 -0700 (PDT) Date: Tue, 14 Apr 2020 15:05:20 +0200 From: Andrea Righi To: "Huang, Ying" Cc: Andrew Morton , Minchan Kim , Anchal Agarwal , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm: swap: use fixed-size readahead during swapoff Message-ID: <20200414130520.GF810380@xps-13> References: <20200413111810.GA801367@xps-13> <87a73f7d71.fsf@yhuang-dev.intel.com> <20200413133150.GA810380@xps-13> <87wo6i6efn.fsf@yhuang-dev.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87wo6i6efn.fsf@yhuang-dev.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 14, 2020 at 09:31:24AM +0800, Huang, Ying wrote: > Andrea Righi writes: > > > On Mon, Apr 13, 2020 at 09:00:34PM +0800, Huang, Ying wrote: > >> Andrea Righi writes: > >> > >> [snip] > >> > >> > diff --git a/mm/swap_state.c b/mm/swap_state.c > >> > index ebed37bbf7a3..c71abc8df304 100644 > >> > --- a/mm/swap_state.c > >> > +++ b/mm/swap_state.c > >> > @@ -20,6 +20,7 @@ > >> > #include > >> > #include > >> > #include > >> > +#include > >> > #include > >> > > >> > #include > >> > @@ -507,6 +508,14 @@ static unsigned long swapin_nr_pages(unsigned long offset) > >> > max_pages = 1 << READ_ONCE(page_cluster); > >> > if (max_pages <= 1) > >> > return 1; > >> > + /* > >> > + * If current task is using too much memory or swapoff is running > >> > + * simply use the max readahead size. Since we likely want to load a > >> > + * lot of pages back into memory, using a fixed-size max readhaead can > >> > + * give better performance in this case. > >> > + */ > >> > + if (oom_task_origin(current)) > >> > + return max_pages; > >> > > >> > hits = atomic_xchg(&swapin_readahead_hits, 0); > >> > pages = __swapin_nr_pages(prev_offset, offset, hits, max_pages, > >> > >> Thinks this again. If my understanding were correct, the accessing > >> pattern during swapoff is sequential, why swap readahead doesn't work? > >> If so, can you root cause that firstly? > > > > Theoretically if the pattern is sequential the current heuristic should > > already select a big readahead size, but apparently it's not doing that. > > > > I'll repeat my tests tracing the readahead size during swapoff to see > > exactly what's going on here. > > I haven't verify it. It may be helpful to call lookup_swap_cache() > before swapin_readahead() in unuse_pte_range(). The theory behind it is > to update the swap readahead statistics via lookup_swap_cache(). I did more tests trying to collect some useful information. In particular I've been focusing at tracing the distribution of the values returned by swapin_nr_pages() in different scenarios. To do so I made swapin_nr_pages() trace-able and I used the following bcc command to measure the distrubution of the returned values: # argdist-bpfcc -c -C 'r::swapin_nr_pages(unsigned long offset):unsigned long:$retval' I've collected this metric in the following scenarios: - 5.6 vanilla - 5.6 + lookup_swap_cache() before swapin_readahead() in unuse_pte_range() - 5.6 + atomic_inc(&swapin_readahead_hits) before swapin_readahead() in unuse_pte_range() - 5.6 + swapin_readahead_hits=last_readahead_pages (in the atomic way) before swapin_readahead() in unuse_pte_range() Each kernel has been tested both with swappiness=0 and swappiness=60. Results are pretty much identical changing the swappiness, so I'm just reporting the default case here (w/ swappiness=60). Result ====== = swapoff performance (elapsed time) = vanilla 22.09s lookup_swap_cache() 23.87s hits++ 16.10s hits=last_ra_pages 8.81s = swapin_nr_pages() $retval distribution = 5.6 vanilla: r::swapin_nr_pages(unsigned long offset):unsigned long:$retval COUNT EVENT 36948 $retval = 8 44151 $retval = 4 49290 $retval = 1 527771 $retval = 2 5.6 lookup_swap_cache() before swapin_readahead(): r::swapin_nr_pages(unsigned long offset):unsigned long:$retval COUNT EVENT 13093 $retval = 1 56703 $retval = 8 123067 $retval = 2 366118 $retval = 4 5.6 atomic_inc(&swapin_readahead_hits) before swapin_readahead(): r::swapin_nr_pages(unsigned long offset):unsigned long:$retval COUNT EVENT 2589 $retval = 1 8016 $retval = 2 40021 $retval = 8 566038 $retval = 4 5.6 swapin_readahead_hits=last_readahead_pages before swapin_readahead(): r::swapin_nr_pages(unsigned long offset):unsigned long:$retval COUNT EVENT 785 $retval = 2 1072 $retval = 1 21844 $retval = 4 644168 $retval = 8 In the vanilla case, the readahead heuristic seems to choose 2 pages most of the time. This is because we are not properly considering the hits (hits are always 0 in the swapoff code path) and, as you correctly pointed out, we can fix this by calling lookup_swap_cache() in unuse_pte_range() before calling swapin_readahead(). With this change the distribution of the readahead size moves more toward 4 pages, but we still have some 2s. That looks good, however it doesn't seem to speed up swapoff very much... maybe because calling lookup_swap_cache() introduces a small overhead? (still need to investigate about this theory). In the next test I've tried to always increment hits by 1 before calling swapin_readahead() in unuse_pte_range(). This is basically cheating, because I'm faking the hit ratio, forcing the heuristic to use a larger readahead size; in fact, the readahead size moves even more toward 4 pages and swapoff performance are a little better now. Pushing even more the "cheating" I can pretend that the previous readahead was all hits (swapin_readahead_hits=last_readahead_pages), so I'm forcing the heuristic to move toward the max size and keep using it. The result here is pretty much identical to my fixed-size patch, because swapin_nr_pages() returns the max readahead size pretty much all the time during swapoff (8 pages or, more in general, vm.page-cluster). Personally I don't like very much forcing the heuristic in this way, it'd be nice if it would just work by accounting the proper hit ratio (so just by adding lookup_swap_cache() as you correctly suggested), but this solution doesn't seem to improve performance in reality. For this reason I still think we should consider the swapoff scenario like a special one and somehow bypass the readahead heuristic and always return the max readahead size. Looking at the hits of the previous step in the swapoff case just doesn't work, because we may have some misses, but they will become hits very soon, since we are reading all the swapped out pages back into memory. This is why using the max readahead size gives better swapoff performance. What do you think? Thanks, -Andrea