From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D799C2BA19 for ; Tue, 14 Apr 2020 14:32:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6FC52076B for ; Tue, 14 Apr 2020 14:32:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390935AbgDNOc0 (ORCPT ); Tue, 14 Apr 2020 10:32:26 -0400 Received: from foss.arm.com ([217.140.110.172]:56984 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390932AbgDNOcX (ORCPT ); Tue, 14 Apr 2020 10:32:23 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B553E30E; Tue, 14 Apr 2020 07:32:22 -0700 (PDT) Received: from red-moon.cambridge.arm.com (unknown [10.57.27.66]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A55293F73D; Tue, 14 Apr 2020 07:32:18 -0700 (PDT) Date: Tue, 14 Apr 2020 15:32:11 +0100 From: Lorenzo Pieralisi To: Laurentiu Tudor Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, robin.murphy@arm.com, ard.biesheuvel@linaro.org, ioana.ciornei@nxp.com, diana.craciun@oss.nxp.com, maz@kernel.org, jon@solid-run.com, pankaj.bansal@nxp.com, makarand.pawagi@nxp.com, calvin.johnson@nxp.com, V.Sethi@nxp.com, cristian.sovaiala@nxp.com, Stuart.Yoder@arm.com, jeremy.linton@arm.com, joro@8bytes.org, tglx@linutronix.de, jason@lakedaemon.net Subject: Re: [RFC PATCH 1/4] bus: fsl-mc: add custom .dma_configure implementation Message-ID: <20200414143211.GA14905@red-moon.cambridge.arm.com> References: <20200227100542.13819-1-laurentiu.tudor@nxp.com> <20200325125109.GA5430@red-moon.cambridge.arm.com> <499fbf9a-416f-d7c7-0655-881d92138a6c@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <499fbf9a-416f-d7c7-0655-881d92138a6c@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Wed, Mar 25, 2020 at 06:48:55PM +0200, Laurentiu Tudor wrote: > Hi Lorenzo, > > On 3/25/2020 2:51 PM, Lorenzo Pieralisi wrote: > > On Thu, Feb 27, 2020 at 12:05:39PM +0200, laurentiu.tudor@nxp.com wrote: > >> From: Laurentiu Tudor > >> > >> The devices on this bus are not discovered by way of device tree > >> but by queries to the firmware. It makes little sense to trick the > >> generic of layer into thinking that these devices are of related so > >> that we can get our dma configuration. Instead of doing that, add > >> our custom dma configuration implementation. > >> > >> Signed-off-by: Laurentiu Tudor > >> --- > >> drivers/bus/fsl-mc/fsl-mc-bus.c | 31 ++++++++++++++++++++++++++++++- > >> 1 file changed, 30 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c > >> index 36eb25f82c8e..eafaa0e0b906 100644 > >> --- a/drivers/bus/fsl-mc/fsl-mc-bus.c > >> +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c > >> @@ -132,11 +132,40 @@ static int fsl_mc_bus_uevent(struct device *dev, struct kobj_uevent_env *env) > >> static int fsl_mc_dma_configure(struct device *dev) > >> { > >> struct device *dma_dev = dev; > >> + struct iommu_fwspec *fwspec; > >> + const struct iommu_ops *iommu_ops; > >> + struct fsl_mc_device *mc_dev = to_fsl_mc_device(dev); > >> + int ret; > >> + u32 icid; > >> > >> while (dev_is_fsl_mc(dma_dev)) > >> dma_dev = dma_dev->parent; > >> > >> - return of_dma_configure(dev, dma_dev->of_node, 0); > >> + fwspec = dev_iommu_fwspec_get(dma_dev); > >> + if (!fwspec) > >> + return -ENODEV; > >> + iommu_ops = iommu_ops_from_fwnode(fwspec->iommu_fwnode); > >> + if (!iommu_ops) > >> + return -ENODEV; > >> + > >> + ret = iommu_fwspec_init(dev, fwspec->iommu_fwnode, iommu_ops); > >> + if (ret) > >> + return ret; > >> + > >> + icid = mc_dev->icid; > >> + ret = iommu_fwspec_add_ids(dev, &icid, 1); > > > > I see. So with this patch we would use the MC named component only to > > retrieve the iommu_ops > > Right. I'd also add that the implementation tries to follow the existing > standard .dma_configure implementations, e.g. of_dma_configure + > of_iommu_configure. I'd also note that similarly to the ACPI case, this > MC FW device is probed as a platform device in the DT scenario, binding > here [1]. > A similar approach is used for the retrieval of the msi irq domain, see > following patch. > > > - the streamid are injected directly here bypassing OF/IORT bindings translations altogether. > > Actually I've submitted a v2 [2] that calls into .of_xlate() to allow > the smmu driver to do some processing on the raw streamid coming from > the firmware. I have not yet tested this with ACPI but expect it to > work, however, it's debatable how valid is this approach in the context > of ACPI. Actually, what I think you need is of_map_rid() (and an IORT equivalent, that I am going to write - generalizing iort_msi_map_rid()). Would that be enough to enable IORT "normal" mappings in the MC bus named components ? Thanks, Lorenzo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2088DC38A29 for ; Tue, 14 Apr 2020 14:32:29 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EEB8320775 for ; Tue, 14 Apr 2020 14:32:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEB8320775 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id E3E75204E9; Tue, 14 Apr 2020 14:32:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 76fN4oDSRKQn; Tue, 14 Apr 2020 14:32:26 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id EF978203A4; Tue, 14 Apr 2020 14:32:25 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A2E73C089E; Tue, 14 Apr 2020 14:32:25 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 9E425C0172 for ; Tue, 14 Apr 2020 14:32:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 85ADD84C29 for ; Tue, 14 Apr 2020 14:32:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bcKr_skiG3PS for ; Tue, 14 Apr 2020 14:32:23 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by fraxinus.osuosl.org (Postfix) with ESMTP id 80A5B847A7 for ; Tue, 14 Apr 2020 14:32:23 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B553E30E; Tue, 14 Apr 2020 07:32:22 -0700 (PDT) Received: from red-moon.cambridge.arm.com (unknown [10.57.27.66]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A55293F73D; Tue, 14 Apr 2020 07:32:18 -0700 (PDT) Date: Tue, 14 Apr 2020 15:32:11 +0100 From: Lorenzo Pieralisi To: Laurentiu Tudor Subject: Re: [RFC PATCH 1/4] bus: fsl-mc: add custom .dma_configure implementation Message-ID: <20200414143211.GA14905@red-moon.cambridge.arm.com> References: <20200227100542.13819-1-laurentiu.tudor@nxp.com> <20200325125109.GA5430@red-moon.cambridge.arm.com> <499fbf9a-416f-d7c7-0655-881d92138a6c@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <499fbf9a-416f-d7c7-0655-881d92138a6c@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) Cc: jason@lakedaemon.net, calvin.johnson@nxp.com, ard.biesheuvel@linaro.org, maz@kernel.org, pankaj.bansal@nxp.com, diana.craciun@oss.nxp.com, jon@solid-run.com, linux-kernel@vger.kernel.org, jeremy.linton@arm.com, linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org, cristian.sovaiala@nxp.com, tglx@linutronix.de, makarand.pawagi@nxp.com, ioana.ciornei@nxp.com, Stuart.Yoder@arm.com, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org, V.Sethi@nxp.com X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Wed, Mar 25, 2020 at 06:48:55PM +0200, Laurentiu Tudor wrote: > Hi Lorenzo, > > On 3/25/2020 2:51 PM, Lorenzo Pieralisi wrote: > > On Thu, Feb 27, 2020 at 12:05:39PM +0200, laurentiu.tudor@nxp.com wrote: > >> From: Laurentiu Tudor > >> > >> The devices on this bus are not discovered by way of device tree > >> but by queries to the firmware. It makes little sense to trick the > >> generic of layer into thinking that these devices are of related so > >> that we can get our dma configuration. Instead of doing that, add > >> our custom dma configuration implementation. > >> > >> Signed-off-by: Laurentiu Tudor > >> --- > >> drivers/bus/fsl-mc/fsl-mc-bus.c | 31 ++++++++++++++++++++++++++++++- > >> 1 file changed, 30 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c > >> index 36eb25f82c8e..eafaa0e0b906 100644 > >> --- a/drivers/bus/fsl-mc/fsl-mc-bus.c > >> +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c > >> @@ -132,11 +132,40 @@ static int fsl_mc_bus_uevent(struct device *dev, struct kobj_uevent_env *env) > >> static int fsl_mc_dma_configure(struct device *dev) > >> { > >> struct device *dma_dev = dev; > >> + struct iommu_fwspec *fwspec; > >> + const struct iommu_ops *iommu_ops; > >> + struct fsl_mc_device *mc_dev = to_fsl_mc_device(dev); > >> + int ret; > >> + u32 icid; > >> > >> while (dev_is_fsl_mc(dma_dev)) > >> dma_dev = dma_dev->parent; > >> > >> - return of_dma_configure(dev, dma_dev->of_node, 0); > >> + fwspec = dev_iommu_fwspec_get(dma_dev); > >> + if (!fwspec) > >> + return -ENODEV; > >> + iommu_ops = iommu_ops_from_fwnode(fwspec->iommu_fwnode); > >> + if (!iommu_ops) > >> + return -ENODEV; > >> + > >> + ret = iommu_fwspec_init(dev, fwspec->iommu_fwnode, iommu_ops); > >> + if (ret) > >> + return ret; > >> + > >> + icid = mc_dev->icid; > >> + ret = iommu_fwspec_add_ids(dev, &icid, 1); > > > > I see. So with this patch we would use the MC named component only to > > retrieve the iommu_ops > > Right. I'd also add that the implementation tries to follow the existing > standard .dma_configure implementations, e.g. of_dma_configure + > of_iommu_configure. I'd also note that similarly to the ACPI case, this > MC FW device is probed as a platform device in the DT scenario, binding > here [1]. > A similar approach is used for the retrieval of the msi irq domain, see > following patch. > > > - the streamid are injected directly here bypassing OF/IORT bindings translations altogether. > > Actually I've submitted a v2 [2] that calls into .of_xlate() to allow > the smmu driver to do some processing on the raw streamid coming from > the firmware. I have not yet tested this with ACPI but expect it to > work, however, it's debatable how valid is this approach in the context > of ACPI. Actually, what I think you need is of_map_rid() (and an IORT equivalent, that I am going to write - generalizing iort_msi_map_rid()). Would that be enough to enable IORT "normal" mappings in the MC bus named components ? Thanks, Lorenzo _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63D0FC38A29 for ; Tue, 14 Apr 2020 14:32:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 395642064A for ; Tue, 14 Apr 2020 14:32:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pJhPnilW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 395642064A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dzu4t1MWSWrcrcd/JkaaNw5hW/y4gmFjxFzahfxU1kA=; b=pJhPnilWcRtggy I/blgqsdUI3xifg8hwYdSDRw0lW86sII0XNnaQvdOhr4U5+vuz78em6bPELGpwKCAskiN0kQNp00N XE3PZh4Z891+GvPtjoUoSctNxqkeGTKT30hIxXYFIZty5wnTGUg/Af4HwpDlQIhTYIl7HbJxhRZZC BFPPPy4QLC5EOFzFhT9+P7zd1KJl0FNqAtCQ9V0O1trg6FO4GK0LBkb/4TNivPdJYqCYL3W0AUoQA EeqCs9H7QZlJ0mKTM+Z9IxC8qL1lI7gl85BVJjbsdtXJnRDmOhkh23dfRszXMT1448V4L5PsnVME5 Ialv1ezkmiPL44LS+eDw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOMc2-0001qU-5x; Tue, 14 Apr 2020 14:32:30 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOMbz-0001q4-He for linux-arm-kernel@lists.infradead.org; Tue, 14 Apr 2020 14:32:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B553E30E; Tue, 14 Apr 2020 07:32:22 -0700 (PDT) Received: from red-moon.cambridge.arm.com (unknown [10.57.27.66]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A55293F73D; Tue, 14 Apr 2020 07:32:18 -0700 (PDT) Date: Tue, 14 Apr 2020 15:32:11 +0100 From: Lorenzo Pieralisi To: Laurentiu Tudor Subject: Re: [RFC PATCH 1/4] bus: fsl-mc: add custom .dma_configure implementation Message-ID: <20200414143211.GA14905@red-moon.cambridge.arm.com> References: <20200227100542.13819-1-laurentiu.tudor@nxp.com> <20200325125109.GA5430@red-moon.cambridge.arm.com> <499fbf9a-416f-d7c7-0655-881d92138a6c@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <499fbf9a-416f-d7c7-0655-881d92138a6c@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200414_073227_671981_1771B194 X-CRM114-Status: GOOD ( 23.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jason@lakedaemon.net, calvin.johnson@nxp.com, ard.biesheuvel@linaro.org, maz@kernel.org, pankaj.bansal@nxp.com, diana.craciun@oss.nxp.com, jon@solid-run.com, linux-kernel@vger.kernel.org, jeremy.linton@arm.com, linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org, cristian.sovaiala@nxp.com, tglx@linutronix.de, makarand.pawagi@nxp.com, ioana.ciornei@nxp.com, Stuart.Yoder@arm.com, robin.murphy@arm.com, joro@8bytes.org, linux-arm-kernel@lists.infradead.org, V.Sethi@nxp.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 25, 2020 at 06:48:55PM +0200, Laurentiu Tudor wrote: > Hi Lorenzo, > > On 3/25/2020 2:51 PM, Lorenzo Pieralisi wrote: > > On Thu, Feb 27, 2020 at 12:05:39PM +0200, laurentiu.tudor@nxp.com wrote: > >> From: Laurentiu Tudor > >> > >> The devices on this bus are not discovered by way of device tree > >> but by queries to the firmware. It makes little sense to trick the > >> generic of layer into thinking that these devices are of related so > >> that we can get our dma configuration. Instead of doing that, add > >> our custom dma configuration implementation. > >> > >> Signed-off-by: Laurentiu Tudor > >> --- > >> drivers/bus/fsl-mc/fsl-mc-bus.c | 31 ++++++++++++++++++++++++++++++- > >> 1 file changed, 30 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c > >> index 36eb25f82c8e..eafaa0e0b906 100644 > >> --- a/drivers/bus/fsl-mc/fsl-mc-bus.c > >> +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c > >> @@ -132,11 +132,40 @@ static int fsl_mc_bus_uevent(struct device *dev, struct kobj_uevent_env *env) > >> static int fsl_mc_dma_configure(struct device *dev) > >> { > >> struct device *dma_dev = dev; > >> + struct iommu_fwspec *fwspec; > >> + const struct iommu_ops *iommu_ops; > >> + struct fsl_mc_device *mc_dev = to_fsl_mc_device(dev); > >> + int ret; > >> + u32 icid; > >> > >> while (dev_is_fsl_mc(dma_dev)) > >> dma_dev = dma_dev->parent; > >> > >> - return of_dma_configure(dev, dma_dev->of_node, 0); > >> + fwspec = dev_iommu_fwspec_get(dma_dev); > >> + if (!fwspec) > >> + return -ENODEV; > >> + iommu_ops = iommu_ops_from_fwnode(fwspec->iommu_fwnode); > >> + if (!iommu_ops) > >> + return -ENODEV; > >> + > >> + ret = iommu_fwspec_init(dev, fwspec->iommu_fwnode, iommu_ops); > >> + if (ret) > >> + return ret; > >> + > >> + icid = mc_dev->icid; > >> + ret = iommu_fwspec_add_ids(dev, &icid, 1); > > > > I see. So with this patch we would use the MC named component only to > > retrieve the iommu_ops > > Right. I'd also add that the implementation tries to follow the existing > standard .dma_configure implementations, e.g. of_dma_configure + > of_iommu_configure. I'd also note that similarly to the ACPI case, this > MC FW device is probed as a platform device in the DT scenario, binding > here [1]. > A similar approach is used for the retrieval of the msi irq domain, see > following patch. > > > - the streamid are injected directly here bypassing OF/IORT bindings translations altogether. > > Actually I've submitted a v2 [2] that calls into .of_xlate() to allow > the smmu driver to do some processing on the raw streamid coming from > the firmware. I have not yet tested this with ACPI but expect it to > work, however, it's debatable how valid is this approach in the context > of ACPI. Actually, what I think you need is of_map_rid() (and an IORT equivalent, that I am going to write - generalizing iort_msi_map_rid()). Would that be enough to enable IORT "normal" mappings in the MC bus named components ? Thanks, Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel