From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0800EC2BA19 for ; Tue, 14 Apr 2020 15:22:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6FA42064A for ; Tue, 14 Apr 2020 15:22:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QNAmyDcg"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="cJkUEFjZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6FA42064A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yNk1dgr+0DIxxsKeChsHyN7B0HzyEDzYHqcPQL9LX4E=; b=QNAmyDcgOuAJKx b1cdmUsGRWm2hCWsh5xXbclE6SW6/rSdczlVsvPKZTQ8/LTkB2LYPwtwm6MB8Ffi+S1wW3uY9Alrs L2x1yhiKfYixh68ta+Dc6M7cxUQEnY+nY1uu/Dsf3SOEK+bxxMR/HkabvFPEEpA9mbcv22V+DYMYK edOP+6pyFEbHOBaxoJIYRywCalYkFI/M5ChDS79W/7LT9Ku7VV6R4RSXHeluiVSb1NiDblQajJOT2 QA1N4Ioxdz+NgtQo6c7v6ajKgH8+gcWWHod5heemZ//EXeyJh4rDc5OO27EUPCkZvN02AwTdHa82w VhcwVe0eTkbZWgYbVLfA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jONO7-0007pU-79; Tue, 14 Apr 2020 15:22:11 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jONN0-0006aw-Ix for linux-arm-kernel@lists.infradead.org; Tue, 14 Apr 2020 15:21:03 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 269B42064A; Tue, 14 Apr 2020 15:21:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586877662; bh=eKcXar86I/pa4E4aKZKfLA/UxrYvfXXHvUDwmTnMxOA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cJkUEFjZrRNamI3APb4T+HvpkVMZErGNOCnXC9Z0j5E8TzzOugH8FG6iHLe+gjtDo EVXIClSTlX/9x3iS/qQc+4CyBrxOOf0YeizyJv+gNOdTDrQ8LK6/qU2EwIAk910lGI BN0JCVzlaofP7oUl3u6A/RyJZsOgwM5gyg/XBnt4= Date: Tue, 14 Apr 2020 16:20:58 +0100 From: Will Deacon To: Mark Rutland Subject: Re: [PATCH 0/5] arm64: vdso: cleanups Message-ID: <20200414152057.GB30288@willie-the-truck> References: <20200414104252.16061-1-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200414104252.16061-1-mark.rutland@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200414_082102_661872_F73F5240 X-CRM114-Status: GOOD ( 15.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, vincenzo.frascino@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 14, 2020 at 11:42:47AM +0100, Mark Rutland wrote: > While attempting to review an arm64 vdso patch, I noticed some of the existing > code was somewhat baroque, making it harder than necessary to understand and > extend. These patches attempt to improve this by making the code more > consistent and avoiding unnecessary duplication. > > The first patch in the series fixes a bug in a boot time error path. This bug > was made obvious during the refactoring but I've moved it to the start so that > it can be backported more easily. > > The series is based on v5.7-rc1 and can be found in my arm64/vdso-cleanup > branch [1]. Cheers, this looks really good to me. The only thing I'm slightly confused by is that we still have something like this in __vdso_init(): /* Allocate the vDSO pagelist, plus a page for the data. */ vdso_pagelist = kcalloc(vdso_lookup[arch_index].vdso_pages + 1, sizeof(struct page *), GFP_KERNEL); But I don't see why this needs to be dynamic, and don't we leak the allocation on failure? Not a big deal, but seems silly if we could just have a couple of static page * arrays. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel