From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A09B5C352BE for ; Tue, 14 Apr 2020 17:20:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8194F206A2 for ; Tue, 14 Apr 2020 17:20:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407583AbgDNRUE (ORCPT ); Tue, 14 Apr 2020 13:20:04 -0400 Received: from mga04.intel.com ([192.55.52.120]:9695 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407532AbgDNRUD (ORCPT ); Tue, 14 Apr 2020 13:20:03 -0400 IronPort-SDR: sVE+xiTS5fVD1BUMEJDa+v3O50weHdYWq7KNSCdpF67gAcssIdUB8uRa5DZmZKGh4XEkDYe/QK 46uI0lt2c2Jw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2020 10:20:03 -0700 IronPort-SDR: bSS1Nmn6QIYvVt6eG1P31MxIMX8W8f8wtxfvg+5BLrp+IUu5zPjMkka5UlDxHaLD17LH95cidT Jx54Onedqa9g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,383,1580803200"; d="scan'208";a="271463800" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002.jf.intel.com with ESMTP; 14 Apr 2020 10:19:59 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jOPEA-000Zpr-0r; Tue, 14 Apr 2020 20:20:02 +0300 Date: Tue, 14 Apr 2020 20:20:02 +0300 From: Andy Shevchenko To: Pierre-Louis Bossart Cc: alsa-devel@alsa-project.org, tiwai@suse.de, broonie@kernel.org, Daniel Matuschek , Matthias Reichl , Hui Wang , linux-gpio@vger.kernel.org, Linus Walleij , Bartosz Golaszewski , linux-clk@vger.kernel.org, Michael Turquette , Stephen Boyd , Rob Herring Subject: Re: [RFC PATCH 04/16] ASoC: Intel: sof-pcm512x: detect Hifiberry DAC+ PRO Message-ID: <20200414172002.GD34613@smile.fi.intel.com> References: <20200409195841.18901-1-pierre-louis.bossart@linux.intel.com> <20200409195841.18901-5-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200409195841.18901-5-pierre-louis.bossart@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Apr 09, 2020 at 02:58:29PM -0500, Pierre-Louis Bossart wrote: > Try to detect HifiBerry 44.1 and 48kHz oscillators on codec init ... > + ctx->sclk = devm_clk_get(rtd->card->dev, "sclk"); Is this in the bindings? > + if (IS_ERR(ctx->sclk)) { > + dev_info(dev, "Could not get SCLK, will operate in SOC master mode\n"); Sounds like devm_clk_get_optional(). > + goto skip_dacpro; > + } -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D96FC2BA19 for ; Tue, 14 Apr 2020 17:21:10 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CAC0920678 for ; Tue, 14 Apr 2020 17:21:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="r7OkaEO/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAC0920678 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2B181168C; Tue, 14 Apr 2020 19:20:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2B181168C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1586884868; bh=8WyLkdTf7Vus9l1tDgM2yZD55eWTM36zJzqT2Lk/T7c=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=r7OkaEO/79YMyUXofv5jXu2GvvBxD6th2RH2xm+8EGgbxVKkaaSQSwgPUfGnsSeaM FSAs12PRUVfAbWOSarCXe+v2XSkJXXFVTQ9lSQz6drot48B9cMXS9k//YtTO7zPrm0 BE9A0I1bdITwyYetzvvm9p9Q+vcjsr4hLKsajN+w= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B9B93F80126; Tue, 14 Apr 2020 19:20:17 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C434FF8013D; Tue, 14 Apr 2020 19:20:15 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D401CF800F5 for ; Tue, 14 Apr 2020 19:20:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D401CF800F5 IronPort-SDR: g7p+DyhWJQ2Fdu3eCmozEY8CT2uEo1mnMDVy6XNMUYw6KW1RZzmWSZKSudGcigH1Rx6ROJoMhj K4rcVNHbSCXQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2020 10:20:03 -0700 IronPort-SDR: bSS1Nmn6QIYvVt6eG1P31MxIMX8W8f8wtxfvg+5BLrp+IUu5zPjMkka5UlDxHaLD17LH95cidT Jx54Onedqa9g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,383,1580803200"; d="scan'208";a="271463800" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002.jf.intel.com with ESMTP; 14 Apr 2020 10:19:59 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jOPEA-000Zpr-0r; Tue, 14 Apr 2020 20:20:02 +0300 Date: Tue, 14 Apr 2020 20:20:02 +0300 From: Andy Shevchenko To: Pierre-Louis Bossart Subject: Re: [RFC PATCH 04/16] ASoC: Intel: sof-pcm512x: detect Hifiberry DAC+ PRO Message-ID: <20200414172002.GD34613@smile.fi.intel.com> References: <20200409195841.18901-1-pierre-louis.bossart@linux.intel.com> <20200409195841.18901-5-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200409195841.18901-5-pierre-louis.bossart@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Cc: alsa-devel@alsa-project.org, Rob Herring , linux-gpio@vger.kernel.org, tiwai@suse.de, Linus Walleij , Stephen Boyd , Daniel Matuschek , Hui Wang , Matthias Reichl , broonie@kernel.org, Bartosz Golaszewski , Michael Turquette , linux-clk@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Apr 09, 2020 at 02:58:29PM -0500, Pierre-Louis Bossart wrote: > Try to detect HifiBerry 44.1 and 48kHz oscillators on codec init ... > + ctx->sclk = devm_clk_get(rtd->card->dev, "sclk"); Is this in the bindings? > + if (IS_ERR(ctx->sclk)) { > + dev_info(dev, "Could not get SCLK, will operate in SOC master mode\n"); Sounds like devm_clk_get_optional(). > + goto skip_dacpro; > + } -- With Best Regards, Andy Shevchenko