From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 865D3C352BE for ; Tue, 14 Apr 2020 20:09:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D33920656 for ; Tue, 14 Apr 2020 20:09:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="a5FhvHPS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D33920656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jORs6-0002l5-EZ for qemu-devel@archiver.kernel.org; Tue, 14 Apr 2020 16:09:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44522) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jORpW-00064A-KY for qemu-devel@nongnu.org; Tue, 14 Apr 2020 16:06:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jORpV-0005xT-MO for qemu-devel@nongnu.org; Tue, 14 Apr 2020 16:06:46 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:39582) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jORpV-0005x7-G5 for qemu-devel@nongnu.org; Tue, 14 Apr 2020 16:06:45 -0400 Received: by mail-wm1-x335.google.com with SMTP id y24so15738120wma.4 for ; Tue, 14 Apr 2020 13:06:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+FYvvrpeRy/LpnKiPLY9U4dRrQSytS7+4553ef7RHis=; b=a5FhvHPSnbz49vwvqN6tg0HjcRVazxSCvzlxcb2fT5PfmNhJ01yiF/0YSJE9araXze g/JrrvOAHvsGA5RM7weOKqHY8eSwUN8vC/wSp4soJJJusOWVYvqlL7JvRoqfvFZiAVSM hxgK02WJa2TsSXm5ohzqopiTnj9wSxjL5qQUVC8FsEDk5ydc4MlSd+32NILb0tAPiBlT ULFOwAJGZlqaWETvzWI1QnkXqkenbUEhD7+sgauJxS9+NusEugSzburpKDpeStb+CE+1 SMTUQCJos1KABaGitA0Humma4cGqqQunPMmxsDIE9xFX/NCvXUaJVdRWv4K2MZ3NP5p7 SCBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+FYvvrpeRy/LpnKiPLY9U4dRrQSytS7+4553ef7RHis=; b=LEo9iI92Frapdjg4mz0foaJ+t007w9sWtaI+U9qADDDqKIQJTtB5+kUoYfvd3BbvjC NC8ZywYKwNn0lJbpkac5MakK6E8P/a9PgoYRGa8O0xJGAwlcacP/FnUg9TPJuocXx5GU giE++DlZM47JvGSllNixYBvg5YTH0rgrIOETZH0b41yG0Pneaxh7TKE2/KdOf26X3uCo f903qy1OWKaUTrwlkayvPNBlJrlzyt+taXwLaj53vmuLC9O67lR2tbrJtKGDEF4LTUq/ 8o0MivI2Qu4nJqfnN1ldmGxbrf7fDNGy/Jbb5rmV28IQkeSUyTEcQIQJe8gEz8p9sD4H REtQ== X-Gm-Message-State: AGi0PuaMwxb0SWlm2047rxiQyoT27y/eWwIFaqNtD6iERqFInlTxTu/U Q5N8+s8Pk/A7uDs2+wJ3ql2h5g== X-Google-Smtp-Source: APiQypLf9BTLqA40ujGrcRWGd9c0MJ5tOnig9BWpiNQKtirkJXY5Lntam7VSivb9V+yA0gJ3Fc1r3g== X-Received: by 2002:a1c:bc02:: with SMTP id m2mr1485187wmf.60.1586894804495; Tue, 14 Apr 2020 13:06:44 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id d133sm21285043wmc.27.2020.04.14.13.06.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 13:06:36 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id D53081FF96; Tue, 14 Apr 2020 21:06:32 +0100 (BST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v2 08/17] configure: disable PIE for Windows builds Date: Tue, 14 Apr 2020 21:06:22 +0100 Message-Id: <20200414200631.12799-9-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200414200631.12799-1-alex.bennee@linaro.org> References: <20200414200631.12799-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::335 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bug 1871798 <1871798@bugs.launchpad.net>, Richard Henderson , =?UTF-8?q?Alex=20Benn=C3=A9e?= , James Le Cuirot , Howard Spoelstra , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" It seems on some compilers the test can pass but still give you broken binaries. Fixes: d2cd29e30736 Fixes: https://bugs.launchpad.net/qemu/+bug/1871798 Cc: Bug 1871798 <1871798@bugs.launchpad.net> Signed-off-by: Alex Bennée Tested-by: Howard Spoelstra Tested-by: James Le Cuirot Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 25f7d915720..23b5e93752b 100755 --- a/configure +++ b/configure @@ -807,6 +807,7 @@ MINGW32*) audio_drv_list="" fi supported_os="yes" + pie="no" ;; GNU/kFreeBSD) bsd="yes" -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B43FC2BB1D for ; Tue, 14 Apr 2020 20:21:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1885A206E9 for ; Tue, 14 Apr 2020 20:21:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1885A206E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38686 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOS3X-0001U1-8J for qemu-devel@archiver.kernel.org; Tue, 14 Apr 2020 16:21:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45844) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jORyb-0003kR-0o for qemu-devel@nongnu.org; Tue, 14 Apr 2020 16:16:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jORyZ-0001eE-LA for qemu-devel@nongnu.org; Tue, 14 Apr 2020 16:16:08 -0400 Received: from indium.canonical.com ([91.189.90.7]:59316) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jORyZ-0001do-Fq for qemu-devel@nongnu.org; Tue, 14 Apr 2020 16:16:07 -0400 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.86_2 #2 (Debian)) id 1jORyY-0007NP-1V for ; Tue, 14 Apr 2020 20:16:06 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id 9F99A2E8109 for ; Tue, 14 Apr 2020 20:16:05 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Date: Tue, 14 Apr 2020 20:06:22 -0000 From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org X-Launchpad-Notification-Type: bug X-Launchpad-Bug: product=qemu; status=Incomplete; importance=Undecided; assignee=None; X-Launchpad-Bug-Tags: configure pie windows X-Launchpad-Bug-Information-Type: Public X-Launchpad-Bug-Private: no X-Launchpad-Bug-Security-Vulnerability: no X-Launchpad-Bug-Commenters: ajbennee cat-7 chewi philmd X-Launchpad-Bug-Reporter: James Le Cuirot (chewi) X-Launchpad-Bug-Modifier: =?utf-8?q?Alex_Benn=C3=A9e_=28ajbennee=29?= References: <158642182265.5805.199845175533907355.malonedeb@chaenomeles.canonical.com> Message-Id: <20200414200631.12799-9-alex.bennee@linaro.org> Subject: [Bug 1871798] [PATCH v2 08/17] configure: disable PIE for Windows builds X-Launchpad-Message-Rationale: Subscriber (QEMU) @qemu-devel-ml X-Launchpad-Message-For: qemu-devel-ml Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="2e26c9bbd21cdca248baaea29aeffb920afcc32a"; Instance="production-secrets-lazr.conf" X-Launchpad-Hash: cf03406da7a4da75e3485e0fb6e6be999289372a X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 91.189.90.7 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Bug 1871798 <1871798@bugs.launchpad.net> Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20200414200622.XG0-98VCLdeb5BaZdBKvIbpmPjLuySKnTyMH5v6h-c8@z> It seems on some compilers the test can pass but still give you broken binaries. Fixes: d2cd29e30736 Fixes: https://bugs.launchpad.net/qemu/+bug/1871798 Cc: Bug 1871798 <1871798@bugs.launchpad.net> Signed-off-by: Alex Benn=C3=A9e Tested-by: Howard Spoelstra Tested-by: James Le Cuirot Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 25f7d915720..23b5e93752b 100755 --- a/configure +++ b/configure @@ -807,6 +807,7 @@ MINGW32*) audio_drv_list=3D"" fi supported_os=3D"yes" + pie=3D"no" ;; GNU/kFreeBSD) bsd=3D"yes" -- = 2.20.1 -- = You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1871798 Title: Fails to start on Windows host without explicit --disable-pie Status in QEMU: Incomplete Bug description: Since commit d2cd29e30736afd4a1e8cac3cf4da360bbc65978, which removed the x86 conditional around PIE, QEMU completely fails to start on a Windows host unless --disable-pie is explicitly given at build time. Even just requesting the help text doesn't work. To make testing easier, this can be replicated with Wine. To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1871798/+subscriptions