From: Jerry Snitselaar <jsnitsel@redhat.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Roberto Sassu <roberto.sassu@huawei.com>,
Tianjia Zhang <tianjia.zhang@linux.alibaba.com>,
"peterhuewe@gmx.de" <peterhuewe@gmx.de>,
"jgg@ziepe.ca" <jgg@ziepe.ca>, "arnd@arndb.de" <arnd@arndb.de>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"zhang.jia@linux.alibaba.com" <zhang.jia@linux.alibaba.com>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Silviu Vlasceanu <Silviu.Vlasceanu@huawei.com>
Subject: Re: [PATCH] tpm: fix wrong return value in tpm_pcr_extend
Date: Tue, 14 Apr 2020 13:26:15 -0700 [thread overview]
Message-ID: <20200414202615.stnurisucqxblenj@cantor> (raw)
In-Reply-To: <20200414193542.GB13000@linux.intel.com>
On Tue Apr 14 20, Jarkko Sakkinen wrote:
>On Tue, Apr 14, 2020 at 11:55:43AM +0000, Roberto Sassu wrote:
>> > -----Original Message-----
>> > From: linux-integrity-owner@vger.kernel.org [mailto:linux-integrity-
>> > owner@vger.kernel.org] On Behalf Of Tianjia Zhang
>> > Sent: Tuesday, April 14, 2020 1:42 PM
>> > To: peterhuewe@gmx.de; jarkko.sakkinen@linux.intel.com; jgg@ziepe.ca;
>> > arnd@arndb.de; gregkh@linuxfoundation.org; zhang.jia@linux.alibaba.com
>> > Cc: linux-integrity@vger.kernel.org; linux-kernel@vger.kernel.org;
>> > tianjia.zhang@linux.alibaba.com
>> > Subject: [PATCH] tpm: fix wrong return value in tpm_pcr_extend
>> >
>> > For the algorithm that does not match the bank, a positive
>> > value EINVAL is returned here. I think this is a typo error.
>> > It is necessary to return an error value.
>>
>> Yes, thanks.
>>
>> Reviewed-by: Roberto Sassu <roberto.sassu@huawei.com>
>
>Happen to have the commit ID at hand for fixes?
>
>Thanks.
>
>/Jarkko
>
9f75c8224631 ("KEYS: trusted: correctly initialize digests and fix locking issue")
next prev parent reply other threads:[~2020-04-14 20:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 11:42 [PATCH] tpm: fix wrong return value in tpm_pcr_extend Tianjia Zhang
2020-04-14 11:55 ` Roberto Sassu
2020-04-14 19:35 ` Jarkko Sakkinen
2020-04-14 20:26 ` Jerry Snitselaar [this message]
2020-04-16 16:11 ` Jarkko Sakkinen
2020-04-14 20:26 ` Jerry Snitselaar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414202615.stnurisucqxblenj@cantor \
--to=jsnitsel@redhat.com \
--cc=Silviu.Vlasceanu@huawei.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=roberto.sassu@huawei.com \
--cc=tianjia.zhang@linux.alibaba.com \
--cc=zhang.jia@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.