From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DCCCC2BA19 for ; Wed, 15 Apr 2020 08:50:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED88E206F9 for ; Wed, 15 Apr 2020 08:50:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="DQcmntl7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2895084AbgDOIuU (ORCPT ); Wed, 15 Apr 2020 04:50:20 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:57739 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2895072AbgDOIuQ (ORCPT ); Wed, 15 Apr 2020 04:50:16 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1586940615; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=auWezVjogQxMcK0gEJGFK4CBiymKmdxiKLZPjLM9pjI=; b=DQcmntl7LNdimiKgwowJ1mXDa8/3veYRSz2AdSsmDADthrOEWCDlvxlVIxdx2DVoxAYmhX5Y YP3+HSH3bxRm5BwsQ3jFirdq3XBbzoXZEm7HWsEweb3vxJ4MnxOOYMm18uHMy3eA+6Fy1obr kC0LN1jPIScG3MHGQIp1t0wmZHI= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e96cabc.7f3eed1643b0-smtp-out-n01; Wed, 15 Apr 2020 08:50:04 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 62E45C433F2; Wed, 15 Apr 2020 08:50:03 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6AD8FC433CB; Wed, 15 Apr 2020 08:50:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6AD8FC433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ipw2x00: make ipw_setup_deferred_work() void From: Kalle Valo In-Reply-To: <20200414120251.35869-1-yanaijie@huawei.com> References: <20200414120251.35869-1-yanaijie@huawei.com> To: Jason Yan Cc: , , , , , Jason Yan User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20200415085003.62E45C433F2@smtp.codeaurora.org> Date: Wed, 15 Apr 2020 08:50:03 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Jason Yan wrote: > This function actually needs no return value. So remove the unneeded > variable 'ret' and make it void. > > This also fixes the following coccicheck warning: > > drivers/net/wireless/intel/ipw2x00/ipw2200.c:10648:5-8: Unneeded > variable: "ret". Return "0" on line 10684 > > Signed-off-by: Jason Yan Patch applied to wireless-drivers-next.git, thanks. 5a652b49b41b ipw2x00: make ipw_setup_deferred_work() void -- https://patchwork.kernel.org/patch/11487287/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches