From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24365C3815B for ; Wed, 15 Apr 2020 10:00:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0FBE920784 for ; Wed, 15 Apr 2020 10:00:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2896085AbgDOKAc (ORCPT ); Wed, 15 Apr 2020 06:00:32 -0400 Received: from mga14.intel.com ([192.55.52.115]:60203 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2895955AbgDOKAb (ORCPT ); Wed, 15 Apr 2020 06:00:31 -0400 IronPort-SDR: 5JgyYJ26YInuRCAkHNAJRsE3lY9OvcL5Ns7/xU1zzid/4je+PU0KUCD4XFjY019wfNmCr78b0B lzjGmRtOboQA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2020 03:00:27 -0700 IronPort-SDR: Ar2EFutLqMhbsnWlBemUKP4XSSJ8a0f6fMvHaHDtIvtZ1DSoJ94PMS483/QAZD0YIhxFj5TQHM 112+e9iRo6AA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,386,1580803200"; d="scan'208";a="400264550" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga004.jf.intel.com with ESMTP; 15 Apr 2020 03:00:22 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jOeqG-000kI3-Bw; Wed, 15 Apr 2020 13:00:24 +0300 Date: Wed, 15 Apr 2020 13:00:24 +0300 From: Andy Shevchenko To: Pierre-Louis Bossart Cc: alsa-devel@alsa-project.org, Rob Herring , linux-gpio@vger.kernel.org, tiwai@suse.de, DigitalDreamtime , Linus Walleij , Stephen Boyd , Daniel Matuschek , Hui Wang , Matthias Reichl , broonie@kernel.org, Bartosz Golaszewski , Michael Turquette , linux-clk@vger.kernel.org Subject: Re: [RFC PATCH 07/16] clk: hifiberry-dacpro: initial import Message-ID: <20200415100024.GQ34613@smile.fi.intel.com> References: <20200409195841.18901-1-pierre-louis.bossart@linux.intel.com> <20200409195841.18901-8-pierre-louis.bossart@linux.intel.com> <20200414173110.GG34613@smile.fi.intel.com> <1483c322-66b9-d68e-c8e9-81f826b01108@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483c322-66b9-d68e-c8e9-81f826b01108@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Apr 14, 2020 at 01:09:28PM -0500, Pierre-Louis Bossart wrote: > On 4/14/20 12:31 PM, Andy Shevchenko wrote: > > On Thu, Apr 09, 2020 at 02:58:32PM -0500, Pierre-Louis Bossart wrote: > > > From: Daniel Matuschek > > > > > > This patch imports the clock code from the Raspberry v5.5-y tree. The > > > ASoC machine driver initially present in this patch was dropped. The > > > comments are also dropped but all sign-offs are kept below. The patch > > > authorship was modified with explicit permission from Daniel Matuschek > > > to make sure it matches the Signed-off tag. > > > > > > This patch generates a lot of checkpatch.pl warnings that are > > > corrected in follow-up patches. > > > > I guess it will be waste of time to review this part without squashing it first. > > I wasn't sure if squashing was desired, so kept all my changes separate. At the end, yes. It's a new contribution that can be at least cleaned before hands to more-or-less acceptable point. With so many subtle issues it's not good that we dump an ugly code outside of drivers/staging. > There are some changes from the legacy clk to the clk_hw parts plus > introduction of ACPI support that are easier to review if kept separate. Yes, for review purposes it's okay. You always can put your name as a SoB + Co-developed-by tag or give credits to other people in the commit message differently (depending to amount of work they do vs. yours). > Maybe I should have squashed the cosmetic parts in patch8, and kept the > functional changes as separate patches. Use a common sense, you know your work better than me :-) Just explain this in cover letter (like you do for this version). -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88B90C2BA19 for ; Wed, 15 Apr 2020 10:01:39 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0FC8A20768 for ; Wed, 15 Apr 2020 10:01:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="FpPY1J+Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FC8A20768 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 71D5F950; Wed, 15 Apr 2020 12:00:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 71D5F950 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1586944897; bh=LFemcOdm1Ppq1Vmy/M2H8Ve4zSk/HlnpiwyMGUVy/9U=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=FpPY1J+ZYH27WxWqsIfNXTQdpPNBgnzGRpX4TVkI0N7WSDMZrsXyDHIUozarYAD4i xqrHiw3Z1GOYhVhvsx8NNdfNe3X4U3EzXZOPJ2SN5jL3UAXFQInq2qUjOJf8FPH+hw WMlaCOYiRXuxO9PDqxV/gqUCqlUlyx/HSrYjqqkw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 14348F80245; Wed, 15 Apr 2020 12:00:47 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 49E65F8026A; Wed, 15 Apr 2020 12:00:33 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7B282F80229 for ; Wed, 15 Apr 2020 12:00:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7B282F80229 IronPort-SDR: c3mty3RBgDT2Vq7ZhHT3AqlwtQ5uWOMdFDreapnLQLHDPtS1qMYAZnyH/VRI7763iDOwhvZKmn aPlhatOXb0rw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2020 03:00:27 -0700 IronPort-SDR: Ar2EFutLqMhbsnWlBemUKP4XSSJ8a0f6fMvHaHDtIvtZ1DSoJ94PMS483/QAZD0YIhxFj5TQHM 112+e9iRo6AA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,386,1580803200"; d="scan'208";a="400264550" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga004.jf.intel.com with ESMTP; 15 Apr 2020 03:00:22 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jOeqG-000kI3-Bw; Wed, 15 Apr 2020 13:00:24 +0300 Date: Wed, 15 Apr 2020 13:00:24 +0300 From: Andy Shevchenko To: Pierre-Louis Bossart Subject: Re: [RFC PATCH 07/16] clk: hifiberry-dacpro: initial import Message-ID: <20200415100024.GQ34613@smile.fi.intel.com> References: <20200409195841.18901-1-pierre-louis.bossart@linux.intel.com> <20200409195841.18901-8-pierre-louis.bossart@linux.intel.com> <20200414173110.GG34613@smile.fi.intel.com> <1483c322-66b9-d68e-c8e9-81f826b01108@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483c322-66b9-d68e-c8e9-81f826b01108@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Cc: alsa-devel@alsa-project.org, Matthias Reichl , tiwai@suse.de, DigitalDreamtime , Linus Walleij , Stephen Boyd , Daniel Matuschek , linux-clk@vger.kernel.org, Hui Wang , linux-gpio@vger.kernel.org, Rob Herring , broonie@kernel.org, Bartosz Golaszewski , Michael Turquette X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Apr 14, 2020 at 01:09:28PM -0500, Pierre-Louis Bossart wrote: > On 4/14/20 12:31 PM, Andy Shevchenko wrote: > > On Thu, Apr 09, 2020 at 02:58:32PM -0500, Pierre-Louis Bossart wrote: > > > From: Daniel Matuschek > > > > > > This patch imports the clock code from the Raspberry v5.5-y tree. The > > > ASoC machine driver initially present in this patch was dropped. The > > > comments are also dropped but all sign-offs are kept below. The patch > > > authorship was modified with explicit permission from Daniel Matuschek > > > to make sure it matches the Signed-off tag. > > > > > > This patch generates a lot of checkpatch.pl warnings that are > > > corrected in follow-up patches. > > > > I guess it will be waste of time to review this part without squashing it first. > > I wasn't sure if squashing was desired, so kept all my changes separate. At the end, yes. It's a new contribution that can be at least cleaned before hands to more-or-less acceptable point. With so many subtle issues it's not good that we dump an ugly code outside of drivers/staging. > There are some changes from the legacy clk to the clk_hw parts plus > introduction of ACPI support that are easier to review if kept separate. Yes, for review purposes it's okay. You always can put your name as a SoB + Co-developed-by tag or give credits to other people in the commit message differently (depending to amount of work they do vs. yours). > Maybe I should have squashed the cosmetic parts in patch8, and kept the > functional changes as separate patches. Use a common sense, you know your work better than me :-) Just explain this in cover letter (like you do for this version). -- With Best Regards, Andy Shevchenko