From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2510C2BA19 for ; Wed, 15 Apr 2020 12:28:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89EC8208FE for ; Wed, 15 Apr 2020 12:28:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S369354AbgDOM2f (ORCPT ); Wed, 15 Apr 2020 08:28:35 -0400 Received: from foss.arm.com ([217.140.110.172]:44224 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S369306AbgDOM2B (ORCPT ); Wed, 15 Apr 2020 08:28:01 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B1FAA1063; Wed, 15 Apr 2020 05:28:00 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 10F593F68F; Wed, 15 Apr 2020 05:27:58 -0700 (PDT) Date: Wed, 15 Apr 2020 13:27:31 +0100 From: Mark Rutland To: Vincenzo Frascino Cc: Andrei Vagin , linux-arm-kernel@lists.infradead.org, LKML , Thomas Gleixner , Dmitry Safonov Subject: Re: [PATCH v2 3/6] arm64/vdso: Add time napespace page Message-ID: <20200415122731.GA27539@C02TD0UTHF1T.local> References: <20200225073731.465270-1-avagin@gmail.com> <20200225073731.465270-4-avagin@gmail.com> <20200414172014.GA6705@C02TD0UTHF1T.local> <20200415100539.GA27339@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 15, 2020 at 11:16:00AM +0100, Vincenzo Frascino wrote: > Hi Mark, > > On 4/15/20 11:05 AM, Mark Rutland wrote: > > It's a shame we're not using OPTIMIZER_HIDE_VAR() for that, as it can > > generate slightly better code and is easier to read than bare asm. > > We are not because I was not aware when I wrote this code that such a macro > existed :) > > But you are right it clearly makes the code more readable. To make up for it, I > am happy to make the effort to introduce it for both the cases and replace the > assembler once this patch series gets merged. Sounds good to me! Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 884A2C38A29 for ; Wed, 15 Apr 2020 12:28:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C6472137B for ; Wed, 15 Apr 2020 12:28:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bV8yafvv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C6472137B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c7CmRzOEfpX1hRPxuAFG8y4ta6Ff4I2tHl6PpOL/CvE=; b=bV8yafvvnR5NnQ nsUbE1vn2YVLNrq3+457i2hwjrQ4t2UeaHzFmtcZFumTWowskHDf+KBj8Tcid6aQorrAAe+ShtIiD Twh0gshE2ffUqEjiDtq9c+90Dj2DxU+2odq+7iyXDrrknpsjaSN+mGO5xMCawvuaos1cJ26uSsRf9 3XJwevTRJlJSUwiu/VUZZfXD97tleSODp+jYvdO21+1BWD4S8AABk57csqixwVqdgYuu8Hrb+8Ixp sx1WHX2RdbdO+jgsgB8DMrZGB3pVZczymEhMTymbTSgBm+PWOHlmDQYugcgTJuWbgn9SKP/mK7gSu pL7nb+ftLjTxwJ5ZKONw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOh9B-0004XE-ME; Wed, 15 Apr 2020 12:28:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOh98-0004WU-Hp for linux-arm-kernel@lists.infradead.org; Wed, 15 Apr 2020 12:28:04 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B1FAA1063; Wed, 15 Apr 2020 05:28:00 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 10F593F68F; Wed, 15 Apr 2020 05:27:58 -0700 (PDT) Date: Wed, 15 Apr 2020 13:27:31 +0100 From: Mark Rutland To: Vincenzo Frascino Subject: Re: [PATCH v2 3/6] arm64/vdso: Add time napespace page Message-ID: <20200415122731.GA27539@C02TD0UTHF1T.local> References: <20200225073731.465270-1-avagin@gmail.com> <20200225073731.465270-4-avagin@gmail.com> <20200414172014.GA6705@C02TD0UTHF1T.local> <20200415100539.GA27339@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200415_052803_143246_2DAB62C3 X-CRM114-Status: GOOD ( 12.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Gleixner , Andrei Vagin , LKML , linux-arm-kernel@lists.infradead.org, Dmitry Safonov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 15, 2020 at 11:16:00AM +0100, Vincenzo Frascino wrote: > Hi Mark, > > On 4/15/20 11:05 AM, Mark Rutland wrote: > > It's a shame we're not using OPTIMIZER_HIDE_VAR() for that, as it can > > generate slightly better code and is easier to read than bare asm. > > We are not because I was not aware when I wrote this code that such a macro > existed :) > > But you are right it clearly makes the code more readable. To make up for it, I > am happy to make the effort to introduce it for both the cases and replace the > assembler once this patch series gets merged. Sounds good to me! Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel