From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A000C2D0EF for ; Thu, 16 Apr 2020 09:51:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 00EBF21D7B for ; Thu, 16 Apr 2020 09:51:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="De4+WC6n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2504257AbgDPJv1 (ORCPT ); Thu, 16 Apr 2020 05:51:27 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:33308 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2504220AbgDPJvL (ORCPT ); Thu, 16 Apr 2020 05:51:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587030669; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qJZaml1bqYlNYy3uVGFrdxuVDCwUh58QATaaa/ks2z4=; b=De4+WC6nsaiTe9dkqWo2HlHeMMFWBNut6LidGolEvli9cR/EL9PNJOirj/xu+UKDjEkPIw XNUE2Rteji0vFyDtBPRBgfQAaE96QdDf1Z/6DEEnk/iG49gjFRAYhuor5tia01vSNZXu+7 FcKg58ZzPdF1cY0vs2Lx6Wghd1mT+pk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-253-gRKUCZnoOIOKd_NVLHZeQw-1; Thu, 16 Apr 2020 05:51:04 -0400 X-MC-Unique: gRKUCZnoOIOKd_NVLHZeQw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E1758DB60; Thu, 16 Apr 2020 09:51:00 +0000 (UTC) Received: from krava (unknown [10.40.195.119]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B91946EF91; Thu, 16 Apr 2020 09:50:53 +0000 (UTC) Date: Thu, 16 Apr 2020 11:50:50 +0200 From: Jiri Olsa To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Namhyung Kim , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Yonghong Song , Andrii Nakryiko , Greg Kroah-Hartman , Thomas Gleixner , Igor Lubashev , Alexey Budankov , Florian Fainelli , Adrian Hunter , Andi Kleen , Jiwei Sun , yuzhoujian , Kan Liang , Jin Yao , Leo Yan , John Garry , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, Stephane Eranian Subject: Re: [PATCH v9 4/4] perf tools: add support for libpfm4 Message-ID: <20200416095050.GB369437@krava> References: <20200416063551.47637-1-irogers@google.com> <20200416063551.47637-5-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200416063551.47637-5-irogers@google.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 15, 2020 at 11:35:51PM -0700, Ian Rogers wrote: SNIP > diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config > index 12a8204d63c6..26167ad38a47 100644 > --- a/tools/perf/Makefile.config > +++ b/tools/perf/Makefile.config > @@ -1012,6 +1012,18 @@ ifdef LIBCLANGLLVM > endif > endif > > +ifndef NO_LIBPFM4 > + ifeq ($(feature-libpfm4), 1) > + CFLAGS += -DHAVE_LIBPFM > + EXTLIBS += -lpfm > + ASCIIDOC_EXTRA = -aHAVE_LIBPFM=1 > + $(call detected,CONFIG_LIBPFM4) > + else > + msg := $(warning libpfm4 not found, disables libpfm4 support. Please install libpfm4-dev); > + NO_LIBPFM4 := 1 > + endif > +endif now when it's in FEATURE_TESTS_EXTRA it will not get detected, unless you add the change below.. I wonder how come it was still being detected for you.. might be bug in feature detection stuff jirka --- diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config index 26167ad38a47..b45c5d370b42 100644 --- a/tools/perf/Makefile.config +++ b/tools/perf/Makefile.config @@ -1013,6 +1013,7 @@ ifdef LIBCLANGLLVM endif ifndef NO_LIBPFM4 + $(call feature_check,libpfm4) ifeq ($(feature-libpfm4), 1) CFLAGS += -DHAVE_LIBPFM EXTLIBS += -lpfm From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Olsa Subject: Re: [PATCH v9 4/4] perf tools: add support for libpfm4 Date: Thu, 16 Apr 2020 11:50:50 +0200 Message-ID: <20200416095050.GB369437@krava> References: <20200416063551.47637-1-irogers@google.com> <20200416063551.47637-5-irogers@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200416063551.47637-5-irogers@google.com> Sender: netdev-owner@vger.kernel.org To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Namhyung Kim , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Yonghong Song , Andrii Nakryiko , Greg Kroah-Hartman , Thomas Gleixner , Igor Lubashev , Alexey Budankov , Florian Fainelli , Adrian Hunter , Andi Kleen , Jiwei Sun , yuzhouji List-Id: linux-perf-users.vger.kernel.org On Wed, Apr 15, 2020 at 11:35:51PM -0700, Ian Rogers wrote: SNIP > diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config > index 12a8204d63c6..26167ad38a47 100644 > --- a/tools/perf/Makefile.config > +++ b/tools/perf/Makefile.config > @@ -1012,6 +1012,18 @@ ifdef LIBCLANGLLVM > endif > endif > > +ifndef NO_LIBPFM4 > + ifeq ($(feature-libpfm4), 1) > + CFLAGS += -DHAVE_LIBPFM > + EXTLIBS += -lpfm > + ASCIIDOC_EXTRA = -aHAVE_LIBPFM=1 > + $(call detected,CONFIG_LIBPFM4) > + else > + msg := $(warning libpfm4 not found, disables libpfm4 support. Please install libpfm4-dev); > + NO_LIBPFM4 := 1 > + endif > +endif now when it's in FEATURE_TESTS_EXTRA it will not get detected, unless you add the change below.. I wonder how come it was still being detected for you.. might be bug in feature detection stuff jirka --- diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config index 26167ad38a47..b45c5d370b42 100644 --- a/tools/perf/Makefile.config +++ b/tools/perf/Makefile.config @@ -1013,6 +1013,7 @@ ifdef LIBCLANGLLVM endif ifndef NO_LIBPFM4 + $(call feature_check,libpfm4) ifeq ($(feature-libpfm4), 1) CFLAGS += -DHAVE_LIBPFM EXTLIBS += -lpfm