From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3ECFC2D0EF for ; Thu, 16 Apr 2020 09:56:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3FF22078B for ; Thu, 16 Apr 2020 09:56:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MYvkiXit" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2504519AbgDPJ4N (ORCPT ); Thu, 16 Apr 2020 05:56:13 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:53878 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2504485AbgDPJ4H (ORCPT ); Thu, 16 Apr 2020 05:56:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587030966; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Lc+yq/vS8URFnXpc64MoW39Z5tJ2hW9F4KCw+f7L+9Y=; b=MYvkiXit4vyOFBpwCtXamuRL+nF4hnyC71La6wca05DoRk4e8cTLF8F7tJ+sPHJXjqR7Ap GL2r60Wj3svOdwsmIXVuherpwLPFdVd38t5pPjIliwmuonxBoWWPZoMg6OlhDvQpc3dvPQ 0Fj8G6oYZX/lZF+EpJdTVbFEDiR7gqQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-360-e75isgY2Mlqqj38w2wFCoA-1; Thu, 16 Apr 2020 05:56:00 -0400 X-MC-Unique: e75isgY2Mlqqj38w2wFCoA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5B5238018A3; Thu, 16 Apr 2020 09:55:57 +0000 (UTC) Received: from krava (unknown [10.40.195.119]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 206AE60BF3; Thu, 16 Apr 2020 09:55:50 +0000 (UTC) Date: Thu, 16 Apr 2020 11:55:48 +0200 From: Jiri Olsa To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Namhyung Kim , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Yonghong Song , Andrii Nakryiko , Greg Kroah-Hartman , Thomas Gleixner , Igor Lubashev , Alexey Budankov , Florian Fainelli , Adrian Hunter , Andi Kleen , Jiwei Sun , yuzhoujian , Kan Liang , Jin Yao , Leo Yan , John Garry , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, Stephane Eranian Subject: Re: [PATCH v9 4/4] perf tools: add support for libpfm4 Message-ID: <20200416095548.GD369437@krava> References: <20200416063551.47637-1-irogers@google.com> <20200416063551.47637-5-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200416063551.47637-5-irogers@google.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 15, 2020 at 11:35:51PM -0700, Ian Rogers wrote: SNIP > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c > index 1ab349abe904..80ac598f125b 100644 > --- a/tools/perf/builtin-record.c > +++ b/tools/perf/builtin-record.c > @@ -43,6 +43,7 @@ > #include "util/time-utils.h" > #include "util/units.h" > #include "util/bpf-event.h" > +#include "util/pfm.h" > #include "asm/bug.h" > #include "perf.h" > > @@ -64,6 +65,9 @@ > #include > #include > > + > + > + extra new lines.. jirka > struct switch_output { > bool enabled; > bool signal; > @@ -2421,6 +2425,11 @@ static struct option __record_options[] = { > #endif > OPT_CALLBACK(0, "max-size", &record.output_max_size, > "size", "Limit the maximum size of the output file", parse_output_max_size), > +#ifdef HAVE_LIBPFM > + OPT_CALLBACK(0, "pfm-events", &record.evlist, "event", > + "libpfm4 event selector. use 'perf list' to list available events", > + parse_libpfm_events_option), > +#endif > OPT_END() > }; SNIP From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Olsa Subject: Re: [PATCH v9 4/4] perf tools: add support for libpfm4 Date: Thu, 16 Apr 2020 11:55:48 +0200 Message-ID: <20200416095548.GD369437@krava> References: <20200416063551.47637-1-irogers@google.com> <20200416063551.47637-5-irogers@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200416063551.47637-5-irogers@google.com> Sender: netdev-owner@vger.kernel.org To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Namhyung Kim , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Yonghong Song , Andrii Nakryiko , Greg Kroah-Hartman , Thomas Gleixner , Igor Lubashev , Alexey Budankov , Florian Fainelli , Adrian Hunter , Andi Kleen , Jiwei Sun , yuzhouji List-Id: linux-perf-users.vger.kernel.org On Wed, Apr 15, 2020 at 11:35:51PM -0700, Ian Rogers wrote: SNIP > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c > index 1ab349abe904..80ac598f125b 100644 > --- a/tools/perf/builtin-record.c > +++ b/tools/perf/builtin-record.c > @@ -43,6 +43,7 @@ > #include "util/time-utils.h" > #include "util/units.h" > #include "util/bpf-event.h" > +#include "util/pfm.h" > #include "asm/bug.h" > #include "perf.h" > > @@ -64,6 +65,9 @@ > #include > #include > > + > + > + extra new lines.. jirka > struct switch_output { > bool enabled; > bool signal; > @@ -2421,6 +2425,11 @@ static struct option __record_options[] = { > #endif > OPT_CALLBACK(0, "max-size", &record.output_max_size, > "size", "Limit the maximum size of the output file", parse_output_max_size), > +#ifdef HAVE_LIBPFM > + OPT_CALLBACK(0, "pfm-events", &record.evlist, "event", > + "libpfm4 event selector. use 'perf list' to list available events", > + parse_libpfm_events_option), > +#endif > OPT_END() > }; SNIP