From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B10DC2BB55 for ; Thu, 16 Apr 2020 15:37:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 589AC21D91 for ; Thu, 16 Apr 2020 15:37:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587051443; bh=zIhIZGj24O1o982in8b2nseAv+Soag+2J7fvks+6GeU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=nOLftjxj4deel2kZxCvp6Wf5f+3Yz4Ol30wCztQrh9Y9Zgyh1Mb1zF1iJCJnsfz5z aRubby3kFP4Z4d8twM+t0YXgkegH+jI4puiQPFACwxk0OVHAFXe33b31RBuROZJCM+ 1R42SjDEdbrutgwkGqp1IvcHPjFT/lkYEla4K9/A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2633202AbgDPPhU (ORCPT ); Thu, 16 Apr 2020 11:37:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:51840 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2897967AbgDPNj2 (ORCPT ); Thu, 16 Apr 2020 09:39:28 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 84C3F206E9; Thu, 16 Apr 2020 13:39:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587044368; bh=zIhIZGj24O1o982in8b2nseAv+Soag+2J7fvks+6GeU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=e+1g8qq4YcddGkuWO2ZEIAGb5NxPQeae9IJkO2MM2SfE+gEsjPu6PCZPL8VhRKaKm cz/sYnZLH//hWjT94kg1QcrOMLPxyDgFVaH/rzvyK0HSK/Z799CsbmajAlZ16Nq6ax hvmL6Zm9BvcuwKQjFaMtGGEIpv+W3eLYdpRmt1PA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Qu Wenruo , Josef Bacik , David Sterba Subject: [PATCH 5.5 162/257] btrfs: drop block from cache on error in relocation Date: Thu, 16 Apr 2020 15:23:33 +0200 Message-Id: <20200416131346.804076413@linuxfoundation.org> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200416131325.891903893@linuxfoundation.org> References: <20200416131325.891903893@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Josef Bacik commit 8e19c9732ad1d127b5575a10f4fbcacf740500ff upstream. If we have an error while building the backref tree in relocation we'll process all the pending edges and then free the node. However if we integrated some edges into the cache we'll lose our link to those edges by simply freeing this node, which means we'll leak memory and references to any roots that we've found. Instead we need to use remove_backref_node(), which walks through all of the edges that are still linked to this node and free's them up and drops any root references we may be holding. CC: stable@vger.kernel.org # 4.9+ Reviewed-by: Qu Wenruo Signed-off-by: Josef Bacik Reviewed-by: David Sterba Signed-off-by: David Sterba Signed-off-by: Greg Kroah-Hartman --- fs/btrfs/relocation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/btrfs/relocation.c +++ b/fs/btrfs/relocation.c @@ -1186,7 +1186,7 @@ out: free_backref_node(cache, lower); } - free_backref_node(cache, node); + remove_backref_node(cache, node); return ERR_PTR(err); } ASSERT(!node || !node->detached);