From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CED0C2BB85 for ; Thu, 16 Apr 2020 15:37:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C29421D91 for ; Thu, 16 Apr 2020 15:37:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587051421; bh=cIOg4crpwTP9ciJe671gs1El4Wkf8mdK+l18SkpVrV8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=VcunTYdTTYWDDJi1cvT7t0Xuv3VNEj9DpRCUAglLFCjjXY78ZZIYK6ialc8GsHURV Sab79g3ATA14rZStkMLqFJcv4v1G8UiB47O7Pr//VG8OPhcueykmukrr/jQ4q7lPv2 AcOrMSYxcW50zgva24PJutBAdB8GMXXHsnIy5MVY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2505236AbgDPPg6 (ORCPT ); Thu, 16 Apr 2020 11:36:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:52140 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2896932AbgDPNjn (ORCPT ); Thu, 16 Apr 2020 09:39:43 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3278620732; Thu, 16 Apr 2020 13:39:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587044382; bh=cIOg4crpwTP9ciJe671gs1El4Wkf8mdK+l18SkpVrV8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ncisuMbiK2Q73P4OfGYuJbFLVWmffx04ai7BBwINvptpv9VvcU8vgLklzduT4Fr8f C6t0KK/EwFqLxAucu77zhAK1et/y4KtnL/aQ7O/Kbnzl9Wkbtqree70V5QPUtbomVB CCFZgpAYYEhiF0CFtXAnTZ7xDxTqfJnQKaDM2X94= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Gilad Ben-Yossef , Geert Uytterhoeven , Herbert Xu Subject: [PATCH 5.5 194/257] crypto: ccree - dec auth tag size from cryptlen map Date: Thu, 16 Apr 2020 15:24:05 +0200 Message-Id: <20200416131350.460464378@linuxfoundation.org> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200416131325.891903893@linuxfoundation.org> References: <20200416131325.891903893@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gilad Ben-Yossef commit 8962c6d2c2b8ca51b0f188109015b15fc5f4da44 upstream. Remove the auth tag size from cryptlen before mapping the destination in out-of-place AEAD decryption thus resolving a crash with extended testmgr tests. Signed-off-by: Gilad Ben-Yossef Reported-by: Geert Uytterhoeven Cc: stable@vger.kernel.org # v4.19+ Tested-by: Geert Uytterhoeven Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- drivers/crypto/ccree/cc_buffer_mgr.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) --- a/drivers/crypto/ccree/cc_buffer_mgr.c +++ b/drivers/crypto/ccree/cc_buffer_mgr.c @@ -894,8 +894,12 @@ static int cc_aead_chain_data(struct cc_ if (req->src != req->dst) { size_for_map = areq_ctx->assoclen + req->cryptlen; - size_for_map += (direct == DRV_CRYPTO_DIRECTION_ENCRYPT) ? - authsize : 0; + + if (direct == DRV_CRYPTO_DIRECTION_ENCRYPT) + size_for_map += authsize; + else + size_for_map -= authsize; + if (is_gcm4543) size_for_map += crypto_aead_ivsize(tfm);