From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77D77C3815B for ; Thu, 16 Apr 2020 14:55:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5786A22241 for ; Thu, 16 Apr 2020 14:55:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="ysjTGYvQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394807AbgDPOza (ORCPT ); Thu, 16 Apr 2020 10:55:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2394717AbgDPOz2 (ORCPT ); Thu, 16 Apr 2020 10:55:28 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97C95C061A0C; Thu, 16 Apr 2020 07:55:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=2TAsDZORjN9WETPN/SBIZUHlfbmQGXgSEDTiH1aJP70=; b=ysjTGYvQYx1oDZ1Dqr3mKAJqV 3jM/obm2sGWYLsMebRCDuJPjat1kN4gV6S8xFS2Qke6kp404r6xAjPwZ8d3UOu0BIbEKZf1ZZWNg4 Z8pdruWP4dvREPUk0M9zfx9EpclAK5Imj6jdkvTmES4lYu8ZpCMHdfebIN9Ny8d0hnVlRZUTUQwqo FTyiUfo1WfcED5aWEtzaW8iwEmFjEHNWBkEp7Pq3ltiOGsITZGm4Xn+lh4tKnOwaIJyE+MeKUn/9i sgt6jQnl6fUol8d6ApW4baOsOkzTuhhkHo68rte+Zp0+wQ0laHKAy9m5cB1LHMedQsNMV/vkcIDKH 2tyt6zyFw==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:39236) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jP5vC-0004m8-3u; Thu, 16 Apr 2020 15:55:18 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jP5vB-0001yW-A8; Thu, 16 Apr 2020 15:55:17 +0100 Date: Thu, 16 Apr 2020 15:55:17 +0100 From: Russell King - ARM Linux admin To: Robin Murphy Cc: Andrew Lunn , Linus Walleij , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jason Cooper , "open list:GPIO SUBSYSTEM" , Gregory Clement , linux-pwm@vger.kernel.org, Bartosz Golaszewski , Rob Herring , Thierry Reding , Uwe Kleine-Konig , Linux ARM , Sebastian Hesselbarth Subject: Re: [PATCH RFC 0/6] PWM fan support on Clearfog gt8k Message-ID: <20200416145517.GK25745@shell.armlinux.org.uk> References: <20200329104549.GX25745@shell.armlinux.org.uk> <20200416135039.GL657811@lunn.ch> <5c7cb0ff-bf49-640a-3c4a-ef71495af7b7@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5c7cb0ff-bf49-640a-3c4a-ef71495af7b7@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Apr 16, 2020 at 03:37:40PM +0100, Robin Murphy wrote: > On 2020-04-16 2:50 pm, Andrew Lunn wrote: > [...] > > Clocking with Marvell devices has always been interesting. Core IP > > like this gets reused between different generations of SoCs. The > > original Orion5x had no clock control at all. Latter SoCs have had > > more and more complex clock trees. So care has to be taken to not > > change old behaviour when adding support for new clocks. > > FWIW, that sounds like a good argument for encoding the clock requirements > of each variant in the of_match_data, so the driver doesn't have to simply > trust the DT and hope. Please read my patches. This is exactly what I'm doing. I'm preserving as closely as possible the current driver behaviour while adding support for the Armada 8040 PWM while keeping compatibility with older DT. And I'm doing that by keying off the match data, exactly as you're suggesting above. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux admin Subject: Re: [PATCH RFC 0/6] PWM fan support on Clearfog gt8k Date: Thu, 16 Apr 2020 15:55:17 +0100 Message-ID: <20200416145517.GK25745@shell.armlinux.org.uk> References: <20200329104549.GX25745@shell.armlinux.org.uk> <20200416135039.GL657811@lunn.ch> <5c7cb0ff-bf49-640a-3c4a-ef71495af7b7@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <5c7cb0ff-bf49-640a-3c4a-ef71495af7b7@arm.com> Sender: linux-gpio-owner@vger.kernel.org To: Robin Murphy Cc: Andrew Lunn , Linus Walleij , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jason Cooper , "open list:GPIO SUBSYSTEM" , Gregory Clement , linux-pwm@vger.kernel.org, Bartosz Golaszewski , Rob Herring , Thierry Reding , Uwe Kleine-Konig , Linux ARM , Sebastian Hesselbarth List-Id: linux-pwm@vger.kernel.org On Thu, Apr 16, 2020 at 03:37:40PM +0100, Robin Murphy wrote: > On 2020-04-16 2:50 pm, Andrew Lunn wrote: > [...] > > Clocking with Marvell devices has always been interesting. Core IP > > like this gets reused between different generations of SoCs. The > > original Orion5x had no clock control at all. Latter SoCs have had > > more and more complex clock trees. So care has to be taken to not > > change old behaviour when adding support for new clocks. > > FWIW, that sounds like a good argument for encoding the clock requirements > of each variant in the of_match_data, so the driver doesn't have to simply > trust the DT and hope. Please read my patches. This is exactly what I'm doing. I'm preserving as closely as possible the current driver behaviour while adding support for the Armada 8040 PWM while keeping compatibility with older DT. And I'm doing that by keying off the match data, exactly as you're suggesting above. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8655C2BB55 for ; Thu, 16 Apr 2020 14:55:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B13C206A2 for ; Thu, 16 Apr 2020 14:55:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kKtMg1qr"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="ysjTGYvQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B13C206A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KJKZo83XZfV1LzA5VbNJRUhdE2/twSmHALI9dHR5tuo=; b=kKtMg1qrcnFrA0 JQQU3Zszil0AkOBwy2qwiw3VWE0/rJNdR8e0+QzvH04l+DOJCtIB1UI1w7MCzlZQy2lA8Ko2uGU5t S1jh1sKdrrJWRhn7C76vs3zfCPEWEyjdrxpRBUfyodpgRXKpuPG4a8gDdyvVXJsZIBl5HmgYO98RI uksTt0c8iZms/RXdcq5sQ/2NxPwsCDQRhhPvc983e5aGdNH+EM5wh00lTMFYdS6V4Sd7MH14maVlq 9VRwE36/2y8gsf6deSA8UDlxvYwex3EVszRbVyF7oTCPRRFUVRTpciYq4nJBOmwa9jQTFUM0JuFhM U1SDPIwnL6LTsya15qyw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP5vV-0000TW-9D; Thu, 16 Apr 2020 14:55:40 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP5vR-0000Qy-MS for linux-arm-kernel@lists.infradead.org; Thu, 16 Apr 2020 14:55:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=2TAsDZORjN9WETPN/SBIZUHlfbmQGXgSEDTiH1aJP70=; b=ysjTGYvQYx1oDZ1Dqr3mKAJqV 3jM/obm2sGWYLsMebRCDuJPjat1kN4gV6S8xFS2Qke6kp404r6xAjPwZ8d3UOu0BIbEKZf1ZZWNg4 Z8pdruWP4dvREPUk0M9zfx9EpclAK5Imj6jdkvTmES4lYu8ZpCMHdfebIN9Ny8d0hnVlRZUTUQwqo FTyiUfo1WfcED5aWEtzaW8iwEmFjEHNWBkEp7Pq3ltiOGsITZGm4Xn+lh4tKnOwaIJyE+MeKUn/9i sgt6jQnl6fUol8d6ApW4baOsOkzTuhhkHo68rte+Zp0+wQ0laHKAy9m5cB1LHMedQsNMV/vkcIDKH 2tyt6zyFw==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:39236) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jP5vC-0004m8-3u; Thu, 16 Apr 2020 15:55:18 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jP5vB-0001yW-A8; Thu, 16 Apr 2020 15:55:17 +0100 Date: Thu, 16 Apr 2020 15:55:17 +0100 From: Russell King - ARM Linux admin To: Robin Murphy Subject: Re: [PATCH RFC 0/6] PWM fan support on Clearfog gt8k Message-ID: <20200416145517.GK25745@shell.armlinux.org.uk> References: <20200329104549.GX25745@shell.armlinux.org.uk> <20200416135039.GL657811@lunn.ch> <5c7cb0ff-bf49-640a-3c4a-ef71495af7b7@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5c7cb0ff-bf49-640a-3c4a-ef71495af7b7@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200416_075533_783977_74068D09 X-CRM114-Status: GOOD ( 12.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Andrew Lunn , Jason Cooper , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linus Walleij , linux-pwm@vger.kernel.org, "open list:GPIO SUBSYSTEM" , Rob Herring , Thierry Reding , Uwe Kleine-Konig , Bartosz Golaszewski , Gregory Clement , Linux ARM , Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 16, 2020 at 03:37:40PM +0100, Robin Murphy wrote: > On 2020-04-16 2:50 pm, Andrew Lunn wrote: > [...] > > Clocking with Marvell devices has always been interesting. Core IP > > like this gets reused between different generations of SoCs. The > > original Orion5x had no clock control at all. Latter SoCs have had > > more and more complex clock trees. So care has to be taken to not > > change old behaviour when adding support for new clocks. > > FWIW, that sounds like a good argument for encoding the clock requirements > of each variant in the of_match_data, so the driver doesn't have to simply > trust the DT and hope. Please read my patches. This is exactly what I'm doing. I'm preserving as closely as possible the current driver behaviour while adding support for the Armada 8040 PWM while keeping compatibility with older DT. And I'm doing that by keying off the match data, exactly as you're suggesting above. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel