All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH 5/5] dlmalloc: remove unit test support in SPL
Date: Thu, 16 Apr 2020 13:00:02 -0400	[thread overview]
Message-ID: <20200416170002.GS12111@bill-the-cat> (raw)
In-Reply-To: <69d1e689-fe48-1f85-ff15-568109215f3b@gmx.de>

On Thu, Apr 16, 2020 at 05:37:56PM +0200, Heinrich Schuchardt wrote:
> On 4/16/20 4:32 AM, Tom Rini wrote:
> > On Wed, Apr 15, 2020 at 06:46:23PM +0200, Heinrich Schuchardt wrote:
> >
> >> We cannot run unit tests in SPL. So remove the unit test support.
> >>
> >> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> >> ---
> >>  common/dlmalloc.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Does this show up as a problem somewhere?  I don't see this resulting in
> > size savings anywhere, thanks.
> >
> 
> pine64-lts_defconfig + CONFIG_UNIT_TEST=y:
> 
> without patch:
> 1487904 spl/u-boot-spl
> 
> with patch:
> 1485712 spl/u-boot-spl
> 
> The difference seems to be in the size of debug sections.

Interesting, what toolchain are you using?  That doesn't show up here.
Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200416/77e46cd4/attachment.sig>

  reply	other threads:[~2020-04-16 17:00 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-15 16:46 [PATCH 0/5] lib: reduce SPL size Heinrich Schuchardt
2020-04-15 16:46 ` [PATCH 1/5] lib: do not build OID registry in SPL Heinrich Schuchardt
2020-04-16  2:32   ` Tom Rini
2020-04-16 15:49     ` Heinrich Schuchardt
2020-04-16 17:00       ` Tom Rini
2020-04-24 17:11   ` Tom Rini
2020-04-15 16:46 ` [PATCH 2/5] lib: date functions " Heinrich Schuchardt
2020-04-16  2:32   ` Tom Rini
2020-04-16 16:30     ` Heinrich Schuchardt
2020-04-16 17:04       ` Tom Rini
2020-04-15 16:46 ` [PATCH 3/5] common: image_sign_info helper " Heinrich Schuchardt
2020-04-16  2:32   ` Tom Rini
2020-04-24 17:11   ` Tom Rini
2020-04-15 16:46 ` [PATCH 4/5] lib: do not provide hexdump " Heinrich Schuchardt
2020-04-16  2:32   ` Tom Rini
2020-04-16 16:27     ` Heinrich Schuchardt
2020-04-16 17:02       ` Tom Rini
2020-04-24 17:11   ` Tom Rini
2020-04-15 16:46 ` [PATCH 5/5] dlmalloc: remove unit test support " Heinrich Schuchardt
2020-04-16  2:32   ` Tom Rini
2020-04-16 15:37     ` Heinrich Schuchardt
2020-04-16 17:00       ` Tom Rini [this message]
2020-04-16 17:19         ` Heinrich Schuchardt
2020-04-24 17:11   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200416170002.GS12111@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.