From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Thu, 16 Apr 2020 13:02:20 -0400 Subject: [PATCH 4/5] lib: do not provide hexdump in SPL In-Reply-To: <2cf97e90-48c7-d5a4-a6ba-fb9c1a6b131a@gmx.de> References: <20200415164623.142908-1-xypron.glpk@gmx.de> <20200415164623.142908-5-xypron.glpk@gmx.de> <20200416023229.GM12111@bill-the-cat> <2cf97e90-48c7-d5a4-a6ba-fb9c1a6b131a@gmx.de> Message-ID: <20200416170220.GU12111@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Apr 16, 2020 at 06:27:00PM +0200, Heinrich Schuchardt wrote: > On 4/16/20 4:32 AM, Tom Rini wrote: > > On Wed, Apr 15, 2020 at 06:46:22PM +0200, Heinrich Schuchardt wrote: > > > >> SPL should not be enlarged by building with CONFIG_HEXDUMP=y. > >> > >> Signed-off-by: Heinrich Schuchardt > >> --- > >> lib/hexdump.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Does this show up as a problem somewhere? I don't see this resulting in > > size savings anywhere, thanks. > > > > I checked for origin/master pine64_defconfig > > with HEXDUMP > 1493728 spl/u-boot-spl > > without HEXDUMP > 1485712 spl/u-boot-spl > > Currently no driver is actually calling the hexdump function is SPL. So > the code seems to be removed in the final binary. OK, thanks. Reviewed-by: Tom Rini -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: