From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8891C352BE for ; Thu, 16 Apr 2020 17:02:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A73CC22244 for ; Thu, 16 Apr 2020 17:02:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587056551; bh=SskQMVRoUuqxTsTT4M+b0jWWskvnCF4LTgOnJX4qCGM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=K0kq8NTSlPQbJ2RQaWIzHejPRvgRPXWBLm11X34powvwpQOa9FfXB37mLabgKZFuI DZWFL9ssE+eiGcSa8za4X5FUxwRswtjJM/8cE36uVVjxQyy3saaPvIT8qgq9BujHNH NUeuTdHddf62icMmK4kIC2KbliJVNVQWssYQtr2U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404251AbgDPRCa (ORCPT ); Thu, 16 Apr 2020 13:02:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:44690 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731604AbgDPRC3 (ORCPT ); Thu, 16 Apr 2020 13:02:29 -0400 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 40830206D9; Thu, 16 Apr 2020 17:02:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587056549; bh=SskQMVRoUuqxTsTT4M+b0jWWskvnCF4LTgOnJX4qCGM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gyN+pTmtScj5UVmLJ5nyPnYvNtKMRbAlFgQ+Tspk+FzvPi1Xh2D4Dtg0Hqtraieph F8+QstZpki8Sl+s5PjSkqqc5LZgflo4EZcTNFZRZ66roYCEsRT8wOjiZ+CgB2TGypn B9iyPcYSGryhblmos08GuemDKcbb2uK9CMmgMS7o= Date: Thu, 16 Apr 2020 18:02:24 +0100 From: Will Deacon To: Matthew Wilcox Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, William Kucharski Subject: Re: [PATCH v2 1/5] mm: Remove definition of clear_bit_unlock_is_negative_byte Message-ID: <20200416170224.GB32685@willie-the-truck> References: <20200416154606.306-1-willy@infradead.org> <20200416154606.306-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200416154606.306-2-willy@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Apr 16, 2020 at 08:46:02AM -0700, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > This local definition hasn't been used since commit 84c6591103db > ("locking/atomics, asm-generic/bitops/lock.h: Rewrite using > atomic_fetch_*()") which provided a default definition. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: William Kucharski > Cc: Will Deacon > --- > mm/filemap.c | 23 ----------------------- > 1 file changed, 23 deletions(-) Ok, for my own curiosity I tried building for Alpha because I couldn't for the life of me figure it out, and behold: mm/filemap.c: In function 'unlock_page': mm/filemap.c:1271:6: error: implicit declaration of function 'clear_bit_unlock_is_negative_byte' [-Werror=implicit-function-declaration] if (clear_bit_unlock_is_negative_byte(PG_locked, &page->flags)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors make[1]: *** [scripts/Makefile.build:267: mm/filemap.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1722: mm] Error 2 make: *** Waiting for unfinished jobs.... I had to enable CONFIG_SMP, so maybe the robot doesn't do that? Anyway, it's somewhat reassuring that it broke, if not unfortunate at the same time! Will