From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CE1EC3815B for ; Thu, 16 Apr 2020 17:04:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69A472083E for ; Thu, 16 Apr 2020 17:04:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732667AbgDPRE0 (ORCPT ); Thu, 16 Apr 2020 13:04:26 -0400 Received: from mga12.intel.com ([192.55.52.136]:7421 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393172AbgDPREY (ORCPT ); Thu, 16 Apr 2020 13:04:24 -0400 IronPort-SDR: H5AgMknRdKdZN0hChy6pcEyS5DRO/u/35BNhhnfDb0TzGoLnexPFfq4xVxajCZpHmqZjGWtdM8 ipvB/Lw0NKKQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2020 10:04:23 -0700 IronPort-SDR: CHlCpPPTn0wP84hCQFbtidgGiD3xrJB8aLRxv3YCNK+vUaNWxQe/io2+hmePQGg7C1FALNcyqo SKp8Y1qqAmWw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,391,1580803200"; d="scan'208";a="277385993" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga008.jf.intel.com with SMTP; 16 Apr 2020 10:04:20 -0700 Received: by stinkbox (sSMTP sendmail emulation); Thu, 16 Apr 2020 20:04:20 +0300 From: Ville Syrjala To: dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org, Laurent Pinchart Subject: [PATCH] drm: Fix page flip ioctl format check Date: Thu, 16 Apr 2020 20:04:20 +0300 Message-Id: <20200416170420.23657-1-ville.syrjala@linux.intel.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Ville Syrjälä Revert back to comparing fb->format->format instead fb->format for the page flip ioctl. This check was originally only here to disallow pixel format changes, but when we changed it to do the pointer comparison we potentially started to reject some (but definitely not all) modifier changes as well. In fact the current behaviour depends on whether the driver overrides the format info for a specific format+modifier combo. Eg. on i915 this now rejects compression vs. no compression changes but does not reject any other tiling changes. That's just inconsistent nonsense. The main reason we have to go back to the old behaviour is to fix page flipping with Xorg. At some point Xorg got its atomic rights taken away and since then we can't page flip between compressed and non-compressed fbs on i915. Currently we get no page flipping for any games pretty much since Mesa likes to use compressed buffers. Not sure how compositors are working around this (don't use one myself). I guess they must be doing something to get non-compressed buffers instead. Either that or somehow no one noticed the tearing from the blit fallback. Looking back at the original discussion on this change we pretty much just did it in the name of skipping a few extra pointer dereferences. However, I've decided not to revert the whole thing in case someone has since started to depend on these changes. None of the other checks are relevant for i915 anyways. Cc: stable@vger.kernel.org Cc: Laurent Pinchart Fixes: dbd4d5761e1f ("drm: Replace 'format->format' comparisons to just 'format' comparisons") Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c index d6ad60ab0d38..f2ca5315f23b 100644 --- a/drivers/gpu/drm/drm_plane.c +++ b/drivers/gpu/drm/drm_plane.c @@ -1153,7 +1153,7 @@ int drm_mode_page_flip_ioctl(struct drm_device *dev, if (ret) goto out; - if (old_fb->format != fb->format) { + if (old_fb->format->format != fb->format->format) { DRM_DEBUG_KMS("Page flip is not allowed to change frame buffer format.\n"); ret = -EINVAL; goto out; -- 2.24.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4E29C2BB55 for ; Thu, 16 Apr 2020 17:04:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A2A2520732 for ; Thu, 16 Apr 2020 17:04:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A2A2520732 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 19BB76E4BB; Thu, 16 Apr 2020 17:04:26 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 89D956E4A5; Thu, 16 Apr 2020 17:04:24 +0000 (UTC) IronPort-SDR: AtwD1cv02VZT5EinOBMNs/HOInwby06hlHwlCIOpP2L4z07JXkTH74RBugRY81RXr1c55nggK2 sFTAl8uOyR3A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2020 10:04:23 -0700 IronPort-SDR: CHlCpPPTn0wP84hCQFbtidgGiD3xrJB8aLRxv3YCNK+vUaNWxQe/io2+hmePQGg7C1FALNcyqo SKp8Y1qqAmWw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,391,1580803200"; d="scan'208";a="277385993" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga008.jf.intel.com with SMTP; 16 Apr 2020 10:04:20 -0700 Received: by stinkbox (sSMTP sendmail emulation); Thu, 16 Apr 2020 20:04:20 +0300 From: Ville Syrjala To: dri-devel@lists.freedesktop.org Subject: [PATCH] drm: Fix page flip ioctl format check Date: Thu, 16 Apr 2020 20:04:20 +0300 Message-Id: <20200416170420.23657-1-ville.syrjala@linux.intel.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Laurent Pinchart , stable@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" RnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KClJl dmVydCBiYWNrIHRvIGNvbXBhcmluZyBmYi0+Zm9ybWF0LT5mb3JtYXQgaW5zdGVhZCBmYi0+Zm9y bWF0IGZvciB0aGUKcGFnZSBmbGlwIGlvY3RsLiBUaGlzIGNoZWNrIHdhcyBvcmlnaW5hbGx5IG9u bHkgaGVyZSB0byBkaXNhbGxvdyBwaXhlbApmb3JtYXQgY2hhbmdlcywgYnV0IHdoZW4gd2UgY2hh bmdlZCBpdCB0byBkbyB0aGUgcG9pbnRlciBjb21wYXJpc29uCndlIHBvdGVudGlhbGx5IHN0YXJ0 ZWQgdG8gcmVqZWN0IHNvbWUgKGJ1dCBkZWZpbml0ZWx5IG5vdCBhbGwpIG1vZGlmaWVyCmNoYW5n ZXMgYXMgd2VsbC4gSW4gZmFjdCB0aGUgY3VycmVudCBiZWhhdmlvdXIgZGVwZW5kcyBvbiB3aGV0 aGVyIHRoZQpkcml2ZXIgb3ZlcnJpZGVzIHRoZSBmb3JtYXQgaW5mbyBmb3IgYSBzcGVjaWZpYyBm b3JtYXQrbW9kaWZpZXIgY29tYm8uCkVnLiBvbiBpOTE1IHRoaXMgbm93IHJlamVjdHMgY29tcHJl c3Npb24gdnMuIG5vIGNvbXByZXNzaW9uIGNoYW5nZXMgYnV0CmRvZXMgbm90IHJlamVjdCBhbnkg b3RoZXIgdGlsaW5nIGNoYW5nZXMuIFRoYXQncyBqdXN0IGluY29uc2lzdGVudApub25zZW5zZS4K ClRoZSBtYWluIHJlYXNvbiB3ZSBoYXZlIHRvIGdvIGJhY2sgdG8gdGhlIG9sZCBiZWhhdmlvdXIg aXMgdG8gZml4IHBhZ2UKZmxpcHBpbmcgd2l0aCBYb3JnLiBBdCBzb21lIHBvaW50IFhvcmcgZ290 IGl0cyBhdG9taWMgcmlnaHRzIHRha2VuIGF3YXkKYW5kIHNpbmNlIHRoZW4gd2UgY2FuJ3QgcGFn ZSBmbGlwIGJldHdlZW4gY29tcHJlc3NlZCBhbmQgbm9uLWNvbXByZXNzZWQKZmJzIG9uIGk5MTUu IEN1cnJlbnRseSB3ZSBnZXQgbm8gcGFnZSBmbGlwcGluZyBmb3IgYW55IGdhbWVzIHByZXR0eSBt dWNoCnNpbmNlIE1lc2EgbGlrZXMgdG8gdXNlIGNvbXByZXNzZWQgYnVmZmVycy4gTm90IHN1cmUg aG93IGNvbXBvc2l0b3JzIGFyZQp3b3JraW5nIGFyb3VuZCB0aGlzIChkb24ndCB1c2Ugb25lIG15 c2VsZikuIEkgZ3Vlc3MgdGhleSBtdXN0IGJlIGRvaW5nCnNvbWV0aGluZyB0byBnZXQgbm9uLWNv bXByZXNzZWQgYnVmZmVycyBpbnN0ZWFkLiBFaXRoZXIgdGhhdCBvcgpzb21laG93IG5vIG9uZSBu b3RpY2VkIHRoZSB0ZWFyaW5nIGZyb20gdGhlIGJsaXQgZmFsbGJhY2suCgpMb29raW5nIGJhY2sg YXQgdGhlIG9yaWdpbmFsIGRpc2N1c3Npb24gb24gdGhpcyBjaGFuZ2Ugd2UgcHJldHR5IG11Y2gK anVzdCBkaWQgaXQgaW4gdGhlIG5hbWUgb2Ygc2tpcHBpbmcgYSBmZXcgZXh0cmEgcG9pbnRlciBk ZXJlZmVyZW5jZXMuCkhvd2V2ZXIsIEkndmUgZGVjaWRlZCBub3QgdG8gcmV2ZXJ0IHRoZSB3aG9s ZSB0aGluZyBpbiBjYXNlIHNvbWVvbmUKaGFzIHNpbmNlIHN0YXJ0ZWQgdG8gZGVwZW5kIG9uIHRo ZXNlIGNoYW5nZXMuIE5vbmUgb2YgdGhlIG90aGVyIGNoZWNrcwphcmUgcmVsZXZhbnQgZm9yIGk5 MTUgYW55d2F5cy4KCkNjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnCkNjOiBMYXVyZW50IFBpbmNo YXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+CkZpeGVzOiBkYmQ0ZDU3NjFl MWYgKCJkcm06IFJlcGxhY2UgJ2Zvcm1hdC0+Zm9ybWF0JyBjb21wYXJpc29ucyB0byBqdXN0ICdm b3JtYXQnIGNvbXBhcmlzb25zIikKU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxs ZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KLS0tCiBkcml2ZXJzL2dwdS9kcm0vZHJtX3BsYW5l LmMgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkK CmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3BsYW5lLmMgYi9kcml2ZXJzL2dwdS9k cm0vZHJtX3BsYW5lLmMKaW5kZXggZDZhZDYwYWIwZDM4Li5mMmNhNTMxNWYyM2IgMTAwNjQ0Ci0t LSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fcGxhbmUuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X3BsYW5lLmMKQEAgLTExNTMsNyArMTE1Myw3IEBAIGludCBkcm1fbW9kZV9wYWdlX2ZsaXBfaW9j dGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKIAlpZiAocmV0KQogCQlnb3RvIG91dDsKIAotCWlm IChvbGRfZmItPmZvcm1hdCAhPSBmYi0+Zm9ybWF0KSB7CisJaWYgKG9sZF9mYi0+Zm9ybWF0LT5m b3JtYXQgIT0gZmItPmZvcm1hdC0+Zm9ybWF0KSB7CiAJCURSTV9ERUJVR19LTVMoIlBhZ2UgZmxp cCBpcyBub3QgYWxsb3dlZCB0byBjaGFuZ2UgZnJhbWUgYnVmZmVyIGZvcm1hdC5cbiIpOwogCQly ZXQgPSAtRUlOVkFMOwogCQlnb3RvIG91dDsKLS0gCjIuMjQuMQoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 768F0C352BE for ; Thu, 16 Apr 2020 17:04:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 557E22078E for ; Thu, 16 Apr 2020 17:04:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 557E22078E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A2E136E4E8; Thu, 16 Apr 2020 17:04:26 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 89D956E4A5; Thu, 16 Apr 2020 17:04:24 +0000 (UTC) IronPort-SDR: AtwD1cv02VZT5EinOBMNs/HOInwby06hlHwlCIOpP2L4z07JXkTH74RBugRY81RXr1c55nggK2 sFTAl8uOyR3A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2020 10:04:23 -0700 IronPort-SDR: CHlCpPPTn0wP84hCQFbtidgGiD3xrJB8aLRxv3YCNK+vUaNWxQe/io2+hmePQGg7C1FALNcyqo SKp8Y1qqAmWw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,391,1580803200"; d="scan'208";a="277385993" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga008.jf.intel.com with SMTP; 16 Apr 2020 10:04:20 -0700 Received: by stinkbox (sSMTP sendmail emulation); Thu, 16 Apr 2020 20:04:20 +0300 From: Ville Syrjala To: dri-devel@lists.freedesktop.org Date: Thu, 16 Apr 2020 20:04:20 +0300 Message-Id: <20200416170420.23657-1-ville.syrjala@linux.intel.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH] drm: Fix page flip ioctl format check X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Laurent Pinchart , stable@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" RnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KClJl dmVydCBiYWNrIHRvIGNvbXBhcmluZyBmYi0+Zm9ybWF0LT5mb3JtYXQgaW5zdGVhZCBmYi0+Zm9y bWF0IGZvciB0aGUKcGFnZSBmbGlwIGlvY3RsLiBUaGlzIGNoZWNrIHdhcyBvcmlnaW5hbGx5IG9u bHkgaGVyZSB0byBkaXNhbGxvdyBwaXhlbApmb3JtYXQgY2hhbmdlcywgYnV0IHdoZW4gd2UgY2hh bmdlZCBpdCB0byBkbyB0aGUgcG9pbnRlciBjb21wYXJpc29uCndlIHBvdGVudGlhbGx5IHN0YXJ0 ZWQgdG8gcmVqZWN0IHNvbWUgKGJ1dCBkZWZpbml0ZWx5IG5vdCBhbGwpIG1vZGlmaWVyCmNoYW5n ZXMgYXMgd2VsbC4gSW4gZmFjdCB0aGUgY3VycmVudCBiZWhhdmlvdXIgZGVwZW5kcyBvbiB3aGV0 aGVyIHRoZQpkcml2ZXIgb3ZlcnJpZGVzIHRoZSBmb3JtYXQgaW5mbyBmb3IgYSBzcGVjaWZpYyBm b3JtYXQrbW9kaWZpZXIgY29tYm8uCkVnLiBvbiBpOTE1IHRoaXMgbm93IHJlamVjdHMgY29tcHJl c3Npb24gdnMuIG5vIGNvbXByZXNzaW9uIGNoYW5nZXMgYnV0CmRvZXMgbm90IHJlamVjdCBhbnkg b3RoZXIgdGlsaW5nIGNoYW5nZXMuIFRoYXQncyBqdXN0IGluY29uc2lzdGVudApub25zZW5zZS4K ClRoZSBtYWluIHJlYXNvbiB3ZSBoYXZlIHRvIGdvIGJhY2sgdG8gdGhlIG9sZCBiZWhhdmlvdXIg aXMgdG8gZml4IHBhZ2UKZmxpcHBpbmcgd2l0aCBYb3JnLiBBdCBzb21lIHBvaW50IFhvcmcgZ290 IGl0cyBhdG9taWMgcmlnaHRzIHRha2VuIGF3YXkKYW5kIHNpbmNlIHRoZW4gd2UgY2FuJ3QgcGFn ZSBmbGlwIGJldHdlZW4gY29tcHJlc3NlZCBhbmQgbm9uLWNvbXByZXNzZWQKZmJzIG9uIGk5MTUu IEN1cnJlbnRseSB3ZSBnZXQgbm8gcGFnZSBmbGlwcGluZyBmb3IgYW55IGdhbWVzIHByZXR0eSBt dWNoCnNpbmNlIE1lc2EgbGlrZXMgdG8gdXNlIGNvbXByZXNzZWQgYnVmZmVycy4gTm90IHN1cmUg aG93IGNvbXBvc2l0b3JzIGFyZQp3b3JraW5nIGFyb3VuZCB0aGlzIChkb24ndCB1c2Ugb25lIG15 c2VsZikuIEkgZ3Vlc3MgdGhleSBtdXN0IGJlIGRvaW5nCnNvbWV0aGluZyB0byBnZXQgbm9uLWNv bXByZXNzZWQgYnVmZmVycyBpbnN0ZWFkLiBFaXRoZXIgdGhhdCBvcgpzb21laG93IG5vIG9uZSBu b3RpY2VkIHRoZSB0ZWFyaW5nIGZyb20gdGhlIGJsaXQgZmFsbGJhY2suCgpMb29raW5nIGJhY2sg YXQgdGhlIG9yaWdpbmFsIGRpc2N1c3Npb24gb24gdGhpcyBjaGFuZ2Ugd2UgcHJldHR5IG11Y2gK anVzdCBkaWQgaXQgaW4gdGhlIG5hbWUgb2Ygc2tpcHBpbmcgYSBmZXcgZXh0cmEgcG9pbnRlciBk ZXJlZmVyZW5jZXMuCkhvd2V2ZXIsIEkndmUgZGVjaWRlZCBub3QgdG8gcmV2ZXJ0IHRoZSB3aG9s ZSB0aGluZyBpbiBjYXNlIHNvbWVvbmUKaGFzIHNpbmNlIHN0YXJ0ZWQgdG8gZGVwZW5kIG9uIHRo ZXNlIGNoYW5nZXMuIE5vbmUgb2YgdGhlIG90aGVyIGNoZWNrcwphcmUgcmVsZXZhbnQgZm9yIGk5 MTUgYW55d2F5cy4KCkNjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnCkNjOiBMYXVyZW50IFBpbmNo YXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+CkZpeGVzOiBkYmQ0ZDU3NjFl MWYgKCJkcm06IFJlcGxhY2UgJ2Zvcm1hdC0+Zm9ybWF0JyBjb21wYXJpc29ucyB0byBqdXN0ICdm b3JtYXQnIGNvbXBhcmlzb25zIikKU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxs ZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KLS0tCiBkcml2ZXJzL2dwdS9kcm0vZHJtX3BsYW5l LmMgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkK CmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3BsYW5lLmMgYi9kcml2ZXJzL2dwdS9k cm0vZHJtX3BsYW5lLmMKaW5kZXggZDZhZDYwYWIwZDM4Li5mMmNhNTMxNWYyM2IgMTAwNjQ0Ci0t LSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fcGxhbmUuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X3BsYW5lLmMKQEAgLTExNTMsNyArMTE1Myw3IEBAIGludCBkcm1fbW9kZV9wYWdlX2ZsaXBfaW9j dGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKIAlpZiAocmV0KQogCQlnb3RvIG91dDsKIAotCWlm IChvbGRfZmItPmZvcm1hdCAhPSBmYi0+Zm9ybWF0KSB7CisJaWYgKG9sZF9mYi0+Zm9ybWF0LT5m b3JtYXQgIT0gZmItPmZvcm1hdC0+Zm9ybWF0KSB7CiAJCURSTV9ERUJVR19LTVMoIlBhZ2UgZmxp cCBpcyBub3QgYWxsb3dlZCB0byBjaGFuZ2UgZnJhbWUgYnVmZmVyIGZvcm1hdC5cbiIpOwogCQly ZXQgPSAtRUlOVkFMOwogCQlnb3RvIG91dDsKLS0gCjIuMjQuMQoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==