From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v3 1/2] drm/tegra: output: Don't leak OF node on error Date: Thu, 16 Apr 2020 20:45:13 +0300 Message-ID: <20200416174513.GT4796@pendragon.ideasonboard.com> References: <20200416172405.5051-1-digetx@gmail.com> <20200416172405.5051-2-digetx@gmail.com> <20200416172727.GN4796@pendragon.ideasonboard.com> <304a2a58-0031-bf88-6290-e72ab025d8c5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <304a2a58-0031-bf88-6290-e72ab025d8c5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Osipenko Cc: Thierry Reding , Sam Ravnborg , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org Hi Dmitry, On Thu, Apr 16, 2020 at 08:30:24PM +0300, Dmitry Osipenko wrote: > 16.04.2020 20:27, Laurent Pinchart пишет: > > On Thu, Apr 16, 2020 at 08:24:04PM +0300, Dmitry Osipenko wrote: > >> The OF node should be put before returning error in tegra_output_probe(), > >> otherwise node's refcount will be leaked. > >> > >> Signed-off-by: Dmitry Osipenko > > > > Reviewed-by: Laurent Pinchart > > Hello Laurent, > > That is the fastest kernel review I ever got, thank you :) I think I'm also guilty for the slowest kernel reviews ever, so maybe in the end it will even out :-) -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC5B8C352BE for ; Thu, 16 Apr 2020 17:45:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 92AAF206F9 for ; Thu, 16 Apr 2020 17:45:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="A3exe/dL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 92AAF206F9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F2BE06E97A; Thu, 16 Apr 2020 17:45:28 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id DA0936E97A for ; Thu, 16 Apr 2020 17:45:26 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4A9AC97D; Thu, 16 Apr 2020 19:45:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1587059125; bh=Si+PzRRws6+4QDc7hynPy3aV2BYGQt/fRSsGgtq8sj0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A3exe/dLkoRkW7lEsQ8BdExFrYDd58/ZG1h8n96EfHkx7BDjk+IrwtvIZezM2z5on 5y5MAj37PUdA2af/qbeQzCtF7HD2GfTrxEy6vypLrXJ4jIPlNNeNY/Mfl0PxRmUYTp sp7agrePntewR5vh0XcIiIjWjIf+Bdq8KH4T6wzw= Date: Thu, 16 Apr 2020 20:45:13 +0300 From: Laurent Pinchart To: Dmitry Osipenko Subject: Re: [PATCH v3 1/2] drm/tegra: output: Don't leak OF node on error Message-ID: <20200416174513.GT4796@pendragon.ideasonboard.com> References: <20200416172405.5051-1-digetx@gmail.com> <20200416172405.5051-2-digetx@gmail.com> <20200416172727.GN4796@pendragon.ideasonboard.com> <304a2a58-0031-bf88-6290-e72ab025d8c5@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <304a2a58-0031-bf88-6290-e72ab025d8c5@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, Thierry Reding , Sam Ravnborg , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkgRG1pdHJ5LAoKT24gVGh1LCBBcHIgMTYsIDIwMjAgYXQgMDg6MzA6MjRQTSArMDMwMCwgRG1p dHJ5IE9zaXBlbmtvIHdyb3RlOgo+IDE2LjA0LjIwMjAgMjA6MjcsIExhdXJlbnQgUGluY2hhcnQg 0L/QuNGI0LXRgjoKPiA+IE9uIFRodSwgQXByIDE2LCAyMDIwIGF0IDA4OjI0OjA0UE0gKzAzMDAs IERtaXRyeSBPc2lwZW5rbyB3cm90ZToKPiA+PiBUaGUgT0Ygbm9kZSBzaG91bGQgYmUgcHV0IGJl Zm9yZSByZXR1cm5pbmcgZXJyb3IgaW4gdGVncmFfb3V0cHV0X3Byb2JlKCksCj4gPj4gb3RoZXJ3 aXNlIG5vZGUncyByZWZjb3VudCB3aWxsIGJlIGxlYWtlZC4KPiA+Pgo+ID4+IFNpZ25lZC1vZmYt Ynk6IERtaXRyeSBPc2lwZW5rbyA8ZGlnZXR4QGdtYWlsLmNvbT4KPiA+IAo+ID4gUmV2aWV3ZWQt Ynk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4K PiAKPiBIZWxsbyBMYXVyZW50LAo+IAo+IFRoYXQgaXMgdGhlIGZhc3Rlc3Qga2VybmVsIHJldmll dyBJIGV2ZXIgZ290LCB0aGFuayB5b3UgOikKCkkgdGhpbmsgSSdtIGFsc28gZ3VpbHR5IGZvciB0 aGUgc2xvd2VzdCBrZXJuZWwgcmV2aWV3cyBldmVyLCBzbyBtYXliZSBpbgp0aGUgZW5kIGl0IHdp bGwgZXZlbiBvdXQgOi0pCgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==