From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DAF8C3815B for ; Thu, 16 Apr 2020 19:55:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 321DC206A2 for ; Thu, 16 Apr 2020 19:55:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729179AbgDPTzj (ORCPT ); Thu, 16 Apr 2020 15:55:39 -0400 Received: from mail.baikalelectronics.com ([87.245.175.226]:53944 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728199AbgDPTzi (ORCPT ); Thu, 16 Apr 2020 15:55:38 -0400 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id F228E80307C5; Thu, 16 Apr 2020 19:55:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q6t9JrujRUgw; Thu, 16 Apr 2020 22:55:33 +0300 (MSK) Date: Thu, 16 Apr 2020 22:56:20 +0300 From: Sergey Semin To: Rob Herring CC: Sebastian Reichel , Mark Rutland , Alexey Malahov , Thomas Bogendoerfer , Paul Burton , Ralf Baechle , "open list:THERMAL" , , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 3/4] dt-bindings: power: reset: Add regmap support to the SYSCON reboot-mode bindings Message-ID: <20200416195620.4q6scqk5rqbonz4s@ubsrv2.baikal.int> References: <20200306130341.9585-1-Sergey.Semin@baikalelectronics.ru> <20200306130402.1F4F0803079F@mail.baikalelectronics.ru> <20200312211438.GA21883@bogus> <20200313130231.wrvvcttm7ofaxbfo@ubsrv2.baikal.int> <20200331195053.dcexmhbsbnbfuabe@ubsrv2.baikal.int> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200331195053.dcexmhbsbnbfuabe@ubsrv2.baikal.int> X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rob, Any comment on my suggestion below? Regards, -Sergey On Tue, Mar 31, 2020 at 10:50:53PM +0300, Sergey Semin wrote: > On Wed, Mar 18, 2020 at 05:14:25PM -0600, Rob Herring wrote: > > On Fri, Mar 13, 2020 at 7:03 AM Sergey Semin > > wrote: > > > > > > On Thu, Mar 12, 2020 at 04:14:38PM -0500, Rob Herring wrote: > > > > On Fri, Mar 06, 2020 at 04:03:40PM +0300, Sergey.Semin@baikalelectronics.ru wrote: > > > > > From: Serge Semin > > > > > > > > > > Optional regmap property will be used to refer to a syscon-controller > > > > > having a reboot tolerant register mapped. > > > > > > > > NAK. It should simply be a child node of the 'syscon-controller'. > > > > > > Hm, It's dilemma. The driver maintainer said ack, while you disagree.) > > > So the code change will be merged while the doc-part won't? Lets discuss then > > > to settle the issue. > > > > > > Why 'syscon-reboot' can be out of syscon-controller node, while > > > 'syscon-reboot-mode' can't? > > > > Look at the history and you will see one was reviewed by DT > > maintainers and one wasn't. > > > > > They both belong to the same usecase: save > > > cause id and reboot. So having similar properties-set and declaring their > > > nodes someplace nearby is natural. > > > > Which is what I'm asking for. Where else in the tree does it make > > sense to locate the 'syscon-reboot-mode' node? Locate nodes where they > > logically belong. > > > > > According to the driver 'syscon-reboot' > > > can't lack the regmap property because it's mandatory, while here you refuse > > > to have even optional support. Additionally in most of the cases the > > > 'syscon-reboot' nodes aren't declared as a child of a system controller > > > node. Why 'syscon-reboot-mode' can't work in a similar way? > > > > There's plenty of bad or "don't follow current best practice" examples > > in the tree for all sorts of things. That is not a reason for doing > > something in a new binding or adding to an existing one. > > > > Rob > > Alright. I see your point. What about I'd provide a sort of opposite > implementation? I could make the "regmap"-phandle reference being optional > in the !"syscon-reboot"! driver instead of adding the regmap-property > support to the "syscon-reboot-mode" driver. So if regmap property isn't > defined in the "syscon-reboot"-compatible node, the driver will try to > get a syscon regmap from the parental node as it's done in the > "syscon-reboot-mode" driver. > > Seeing you think that regmap-property-based design is a bad practice in > this case, I also could mark the property as deprecated in the "syscon-reboot" > dt schema and print a warning from the "syscon-reboot" driver if one is defined. > > What do you think? > > Regards, > -Sergey