From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v3 2/2] drm/tegra: output: rgb: Support LVDS encoder bridge Date: Thu, 16 Apr 2020 22:37:49 +0200 Message-ID: <20200416203749.GA7104@ravnborg.org> References: <20200416172405.5051-1-digetx@gmail.com> <20200416172405.5051-3-digetx@gmail.com> <20200416174112.GS4796@pendragon.ideasonboard.com> <6275bcd3-c0b2-4c1c-1817-9e713d3747c7@gmail.com> <7cf27640-4fdc-8617-01cb-85f4c5847bb8@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <7cf27640-4fdc-8617-01cb-85f4c5847bb8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Osipenko Cc: Laurent Pinchart , Thierry Reding , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org Hi Dimitry. On Thu, Apr 16, 2020 at 11:21:40PM +0300, Dmitry Osipenko wrote: > 16.04.2020 21:52, Dmitry Osipenko пишет: > ... > >> May I also recommend switching to the DRM panel bridge helper ? It will > >> simplify the code. > > > > Could you please clarify what is the "DRM panel bridge helper"? > > > > I think we won't need any additional helpers after switching to the > > bridge connector helper, no? > > Actually, I now see that the panel needs to be manually attached to the > connector. > > Still it's not apparent to me how to get panel out of the bridge. It > looks like there is no such "panel helper" for the bridge API or I just > can't find it. Take a look in bridge/panel.c I think devm_drm_panel_bridge_add() is what you are after. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C89ADC2BA2B for ; Thu, 16 Apr 2020 20:38:01 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A492B206A2 for ; Thu, 16 Apr 2020 20:38:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A492B206A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 03F7E6EB66; Thu, 16 Apr 2020 20:38:01 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 156F96EB66 for ; Thu, 16 Apr 2020 20:37:59 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id B65CA2002B; Thu, 16 Apr 2020 22:37:55 +0200 (CEST) Date: Thu, 16 Apr 2020 22:37:49 +0200 From: Sam Ravnborg To: Dmitry Osipenko Subject: Re: [PATCH v3 2/2] drm/tegra: output: rgb: Support LVDS encoder bridge Message-ID: <20200416203749.GA7104@ravnborg.org> References: <20200416172405.5051-1-digetx@gmail.com> <20200416172405.5051-3-digetx@gmail.com> <20200416174112.GS4796@pendragon.ideasonboard.com> <6275bcd3-c0b2-4c1c-1817-9e713d3747c7@gmail.com> <7cf27640-4fdc-8617-01cb-85f4c5847bb8@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7cf27640-4fdc-8617-01cb-85f4c5847bb8@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=nEArpEn2Zqm_PZ96XV0A:9 a=QEXdDO2ut3YA:10 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, Thierry Reding , Laurent Pinchart , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkgRGltaXRyeS4KCk9uIFRodSwgQXByIDE2LCAyMDIwIGF0IDExOjIxOjQwUE0gKzAzMDAsIERt aXRyeSBPc2lwZW5rbyB3cm90ZToKPiAxNi4wNC4yMDIwIDIxOjUyLCBEbWl0cnkgT3NpcGVua28g 0L/QuNGI0LXRgjoKPiAuLi4KPiA+PiBNYXkgSSBhbHNvIHJlY29tbWVuZCBzd2l0Y2hpbmcgdG8g dGhlIERSTSBwYW5lbCBicmlkZ2UgaGVscGVyID8gSXQgd2lsbAo+ID4+IHNpbXBsaWZ5IHRoZSBj b2RlLgo+ID4gCj4gPiBDb3VsZCB5b3UgcGxlYXNlIGNsYXJpZnkgd2hhdCBpcyB0aGUgIkRSTSBw YW5lbCBicmlkZ2UgaGVscGVyIj8KPiA+IAo+ID4gSSB0aGluayB3ZSB3b24ndCBuZWVkIGFueSBh ZGRpdGlvbmFsIGhlbHBlcnMgYWZ0ZXIgc3dpdGNoaW5nIHRvIHRoZQo+ID4gYnJpZGdlIGNvbm5l Y3RvciBoZWxwZXIsIG5vPwo+IAo+IEFjdHVhbGx5LCBJIG5vdyBzZWUgdGhhdCB0aGUgcGFuZWwg bmVlZHMgdG8gYmUgbWFudWFsbHkgYXR0YWNoZWQgdG8gdGhlCj4gY29ubmVjdG9yLgo+IAo+IFN0 aWxsIGl0J3Mgbm90IGFwcGFyZW50IHRvIG1lIGhvdyB0byBnZXQgcGFuZWwgb3V0IG9mIHRoZSBi cmlkZ2UuIEl0Cj4gbG9va3MgbGlrZSB0aGVyZSBpcyBubyBzdWNoICJwYW5lbCBoZWxwZXIiIGZv ciB0aGUgYnJpZGdlIEFQSSBvciBJIGp1c3QKPiBjYW4ndCBmaW5kIGl0LgoKVGFrZSBhIGxvb2sg aW4gYnJpZGdlL3BhbmVsLmMKSSB0aGluayBkZXZtX2RybV9wYW5lbF9icmlkZ2VfYWRkKCkgaXMg d2hhdCB5b3UgYXJlIGFmdGVyLgoKCVNhbQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCg==