From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14B16C38A29 for ; Sat, 18 Apr 2020 14:53:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA4712072B for ; Sat, 18 Apr 2020 14:53:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587221601; bh=UO9hE+5yzNPSpuvg9uhBYwowJGF7YGQ0bQZtDXJyLHk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=yHcLTFGC2Rv0066H9PD8MDdS+en23YigPy/LK8C7Qnp8dJHBlz5wZdiI5piLb0uPp 3E8hj9vJZbDulP1ciFdOiaoTKYIvum4D6eX8EHyFDgdJtWhoCkvxEn1Okt5BEr3Yyq GayirCbZioGOPBdnD0vViRSyJ1oNjO4DfQPgn5jM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727865AbgDROxT (ORCPT ); Sat, 18 Apr 2020 10:53:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:36822 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728232AbgDROxO (ORCPT ); Sat, 18 Apr 2020 10:53:14 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AA7E520753; Sat, 18 Apr 2020 14:53:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587221593; bh=UO9hE+5yzNPSpuvg9uhBYwowJGF7YGQ0bQZtDXJyLHk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jJwBl5f8kZb+Vjb6gaXMx+rrc2lwQBFHn4Wp6+3JFe7HyvjEiFD8RVV83+7AX5MKg QjTRUl0wdylXFGYyR3ES9F2crDjZUAluMZOYBVRqeNItFdkUZpzA9dMD6jkzpgcuMC QCHNJDlz+0gYBX+jJAK1ayPCJDQ5RjKdfmJSRxZc= Date: Sat, 18 Apr 2020 15:53:08 +0100 From: Jonathan Cameron To: Saravanan Sekar Cc: lee.jones@linaro.org, andy.shevchenko@gmail.com, robh+dt@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, sre@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v10 1/6] dt-bindings: mfd: add document bindings for mp2629 Message-ID: <20200418155308.681df38f@archlinux> In-Reply-To: <20200417085003.6124-2-sravanhome@gmail.com> References: <20200417085003.6124-1-sravanhome@gmail.com> <20200417085003.6124-2-sravanhome@gmail.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Apr 2020 10:49:58 +0200 Saravanan Sekar wrote: > Add device tree binding information for mp2629 mfd driver. > > Signed-off-by: Saravanan Sekar > Reviewed-by: Andy Shevchenko > --- > .../devicetree/bindings/mfd/mps,mp2629.yaml | 61 +++++++++++++++++++ > 1 file changed, 61 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/mps,mp2629.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml b/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml > new file mode 100644 > index 000000000000..b25b29259d67 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml > @@ -0,0 +1,61 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/mps,mp2629.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MP2629 Battery Charger PMIC from Monolithic Power System. > + > +maintainers: > + - Saravanan Sekar > + > +description: | > + MP2629 is a PMIC providing battery charging and power supply for smartphones, > + wireless camera and portable devices. Chip is controlled over I2C. > + > + The battery charge management device handles battery charger controller and > + ADC IIO device for battery, system voltage > + > +properties: > + compatible: > + const: mps,mp2629 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + interrupt-controller: true > + > + "#interrupt-cells": > + const: 2 > + description: > + The first cell is the IRQ number, the second cell is the trigger type. > + > +required: > + - compatible > + - reg > + - interrupts > + - interrupt-controller > + - "#interrupt-cells" > + > +examples: > + - | > + #include > + #include > + i2c@7e205000 { I thought the general trend for i2c devices was to leave the i2c part 'vague'. i2c { #address-cells = <1>; #size-cells = <0>; pmic@4b.. etc Guess it doesn't matter if example contains too much information. Rob? Otherwise looks good to me. Thanks, Jonathan > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x7e205000 0x200>; > + > + pmic@4b { > + compatible = "mps,mp2629"; > + reg = <0x4b>; > + > + interrupt-controller; > + interrupt-parent = <&gpio2>; > + #interrupt-cells = <2>; > + interrupts = <3 IRQ_TYPE_LEVEL_HIGH>; > + }; > + };