From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6661CC38A29 for ; Sat, 18 Apr 2020 20:20:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44BFE2223D for ; Sat, 18 Apr 2020 20:20:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=arista.com header.i=@arista.com header.b="XRxInYXs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728570AbgDRUUc (ORCPT ); Sat, 18 Apr 2020 16:20:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728460AbgDRUUa (ORCPT ); Sat, 18 Apr 2020 16:20:30 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E848C061A0F for ; Sat, 18 Apr 2020 13:20:30 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id f13so7133447wrm.13 for ; Sat, 18 Apr 2020 13:20:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=googlenew; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kRb3VTo9fqqcoDwRC+xUbun5O8A7r81BCz7puwICl3U=; b=XRxInYXsCLMYHbKTV/E3Cf556LBnqifRTu7fOoVg+fnC+wo8bx+cCx/MD25ZMVoyaP 75h7/7nJC4+2cehTfUN8ct6vyQySP9aRuzXPaDBDbd7HhC5dSoTUyhBtzVnT9P8MHVmu feMagN6JAAguvLTuITE3t6tOebcj0eZX4VttVo9qC4IWKmaIQOUceit+UyUkbd1B5cTH EpLxpP1P0xvSMp7khLb1Td954oetNnG0TlHQdqRKDMFL2CsPb0Wat+lpLOv26znzHgMY HZi13AKU74dFtg4sVEjBldWKY1lA3/GGUrVy83854a32VC1jFVd+vxFK8uLU9jMV2hM1 UrAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kRb3VTo9fqqcoDwRC+xUbun5O8A7r81BCz7puwICl3U=; b=jKl7T/podohfN0T/kzVv19XA2X1HW6yo18MDbmswFpk3cyc/ip0C6BCBFG7VjEWfGK OuzamcB5PLpdyi2IQeTM/gXj3d1cINbrrSPHcjqNAYY5OEBxP3BvokdvLhLedysZChz4 Ami1FFxUbPg96gdr/sAayTV5SsszMDlmJbmLhdYRYT5awZsy3Ue7vKDwuj8MQv9SfklV yv6cgZwFj/d9Nm4RMh8Y5XpQY65cNO0Ok7cjTuOwgpifkeGcB6QJydGOL4rqoSeGtbjK EtY+Edmrjf6+Ov66eK+3ghDT2GctBBQYBVMkxJ6tTlvabhK7XeXPcQ51II4sKhoUOqQG lxmA== X-Gm-Message-State: AGi0PuZOAO/5YIOOuvrZjU3dMYp9x8WaaJhVfNaeavshZ4erkGv+ndbh GowPzQ9BGSxphE0dfqfbMqHtuv6nls4= X-Google-Smtp-Source: APiQypIBHNdaEr/YVaqDAJWyXWNiZxi8CYpb8zsUkWtfwA+UFh16npqb12pWxbpFTmfmiSj23d14bw== X-Received: by 2002:adf:dd8a:: with SMTP id x10mr9457721wrl.308.1587241228309; Sat, 18 Apr 2020 13:20:28 -0700 (PDT) Received: from localhost.localdomain ([2a02:8084:e84:2480:228:f8ff:fe6f:83a8]) by smtp.gmail.com with ESMTPSA id m1sm31735255wro.64.2020.04.18.13.20.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Apr 2020 13:20:27 -0700 (PDT) From: Dmitry Safonov To: linux-kernel@vger.kernel.org Cc: Dmitry Safonov <0x7f454c46@gmail.com>, Dmitry Safonov , Andrew Morton , Greg Kroah-Hartman , Ingo Molnar , Jiri Slaby , Petr Mladek , Sergey Senozhatsky , Steven Rostedt , Tetsuo Handa , Christian Borntraeger , Heiko Carstens , Vasily Gorbik , linux-s390@vger.kernel.org Subject: [PATCHv3 28/50] s390: Add show_stack_loglvl() Date: Sat, 18 Apr 2020 21:19:22 +0100 Message-Id: <20200418201944.482088-29-dima@arista.com> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200418201944.482088-1-dima@arista.com> References: <20200418201944.482088-1-dima@arista.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently, the log-level of show_stack() depends on a platform realization. It creates situations where the headers are printed with lower log level or higher than the stacktrace (depending on a platform or user). Furthermore, it forces the logic decision from user to an architecture side. In result, some users as sysrq/kdb/etc are doing tricks with temporary rising console_loglevel while printing their messages. And in result it not only may print unwanted messages from other CPUs, but also omit printing at all in the unlucky case where the printk() was deferred. Introducing log-level parameter and KERN_UNSUPPRESSED [1] seems an easier approach than introducing more printk buffers. Also, it will consolidate printings with headers. Introduce show_stack_loglvl(), that eventually will substitute show_stack(). Cc: Christian Borntraeger Cc: Heiko Carstens Cc: Vasily Gorbik Cc: linux-s390@vger.kernel.org [1]: https://lore.kernel.org/lkml/20190528002412.1625-1-dima@arista.com/T/#u Signed-off-by: Dmitry Safonov --- arch/s390/kernel/dumpstack.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/arch/s390/kernel/dumpstack.c b/arch/s390/kernel/dumpstack.c index 2c122d8bab93..887a054919fc 100644 --- a/arch/s390/kernel/dumpstack.c +++ b/arch/s390/kernel/dumpstack.c @@ -126,18 +126,24 @@ int get_stack_info(unsigned long sp, struct task_struct *task, return -EINVAL; } -void show_stack(struct task_struct *task, unsigned long *stack) +void show_stack_loglvl(struct task_struct *task, unsigned long *stack, + const char *loglvl) { struct unwind_state state; - printk("Call Trace:\n"); + printk("%sCall Trace:\n", loglvl); unwind_for_each_frame(&state, task, NULL, (unsigned long) stack) - printk(state.reliable ? " [<%016lx>] %pSR \n" : - "([<%016lx>] %pSR)\n", - state.ip, (void *) state.ip); + printk(state.reliable ? "%s [<%016lx>] %pSR \n" : + "%s([<%016lx>] %pSR)\n", + loglvl, state.ip, (void *) state.ip); debug_show_held_locks(task ? : current); } +void show_stack(struct task_struct *task, unsigned long *stack) +{ + show_stack_loglvl(task, stack, KERN_DEFAULT); +} + static void show_last_breaking_event(struct pt_regs *regs) { printk("Last Breaking-Event-Address:\n"); -- 2.26.0