All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lubomir Rintel <lkundrak@v3.sk>
To: soc@kernel.org
Cc: Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Daniel Mack <daniel@zonque.org>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	linux-kernel@vger.kernel.org, Lubomir Rintel <lkundrak@v3.sk>,
	stable@vger.kernel.org
Subject: [PATCH 15/15] ARM: dts: mmp3-dell-ariel: Fix the SPI devices
Date: Sun, 19 Apr 2020 19:11:57 +0200	[thread overview]
Message-ID: <20200419171157.672999-16-lkundrak@v3.sk> (raw)
In-Reply-To: <20200419171157.672999-1-lkundrak@v3.sk>

I've managed to get about everything wrong while digging these out of
OEM's board file.

Correct the bus numbers, the exact model of the NOR flash, polarity of
the chip selects and align the SPI frequency with the data sheet.

Tested that it works now, with a slight fix to the PXA SSP driver.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Cc: <stable@vger.kernel.org>
---
 arch/arm/boot/dts/mmp3-dell-ariel.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/mmp3-dell-ariel.dts b/arch/arm/boot/dts/mmp3-dell-ariel.dts
index 15449c72c042b..b0ec14c421641 100644
--- a/arch/arm/boot/dts/mmp3-dell-ariel.dts
+++ b/arch/arm/boot/dts/mmp3-dell-ariel.dts
@@ -98,19 +98,19 @@ &twsi4 {
 	status = "okay";
 };
 
-&ssp3 {
+&ssp1 {
 	status = "okay";
-	cs-gpios = <&gpio 46 GPIO_ACTIVE_HIGH>;
+	cs-gpios = <&gpio 46 GPIO_ACTIVE_LOW>;
 
 	firmware-flash@0 {
-		compatible = "st,m25p80", "jedec,spi-nor";
+		compatible = "winbond,w25q32", "jedec,spi-nor";
 		reg = <0>;
-		spi-max-frequency = <40000000>;
+		spi-max-frequency = <104000000>;
 		m25p,fast-read;
 	};
 };
 
-&ssp4 {
-	cs-gpios = <&gpio 56 GPIO_ACTIVE_HIGH>;
+&ssp2 {
+	cs-gpios = <&gpio 56 GPIO_ACTIVE_LOW>;
 	status = "okay";
 };
-- 
2.26.0


  parent reply	other threads:[~2020-04-19 17:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-19 17:11 [PATCH 00/15] ARM: dts: Marvell SoC Device Tree updates (for 5.8) Lubomir Rintel
2020-04-19 17:11 ` [PATCH 01/15] ARM: dts: kirkwood: Fix interrupt controller node name Lubomir Rintel
2020-04-19 17:11 ` [PATCH 02/15] ARM: dts: dove: " Lubomir Rintel
2020-04-19 17:11 ` [PATCH 03/15] ARM: dts: pxa168: Add missing address/size cells to i2c nodes Lubomir Rintel
2020-04-19 17:11 ` [PATCH 04/15] ARM: dts: pxa168: Fix the gpio interrupt cell number Lubomir Rintel
2020-04-19 17:11 ` [PATCH 05/15] ARM: dts: pxa3xx: Fix up encoding of the /gpio interrupts property Lubomir Rintel
2020-04-19 17:11 ` [PATCH 06/15] ARM: dts: pxa910: Fix the gpio interrupt cell number Lubomir Rintel
2020-04-19 17:11 ` [PATCH 07/15] ARM: dts: pxa*: Fix up encoding of the /rtc interrupts property Lubomir Rintel
2020-04-19 17:11 ` [PATCH 08/15] ARM: dts: mmp*: " Lubomir Rintel
2020-04-19 17:11 ` [PATCH 09/15] ARM: dts: mmp3: Fix L2 cache controller node name Lubomir Rintel
2020-04-19 17:11 ` [PATCH 10/15] ARM: dts: mmp3: Fix USB & USB PHY node names Lubomir Rintel
2020-04-19 17:11 ` [PATCH 11/15] ARM: dts: berlin*: Fix up the SDHCI " Lubomir Rintel
2020-04-19 17:11 ` [PATCH 12/15] ARM: dts: mmp3: Add the fifth SD HCI Lubomir Rintel
2020-04-19 17:11 ` [PATCH 13/15] ARM: dts: mmp3: Drop usb-nop-xceiv from HSIC phy Lubomir Rintel
2020-04-19 17:11 ` [PATCH 14/15] ARM: dts: mmp3: Use the MMP3 compatible string for /clocks Lubomir Rintel
2020-04-19 17:11 ` Lubomir Rintel [this message]
2020-04-20 15:35 ` [PATCH 00/15] ARM: dts: Marvell SoC Device Tree updates (for 5.8) Arnd Bergmann
2020-04-20 15:35   ` Arnd Bergmann
2020-04-23 22:29   ` Lubomir Rintel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200419171157.672999-16-lkundrak@v3.sk \
    --to=lkundrak@v3.sk \
    --cc=arnd@arndb.de \
    --cc=daniel@zonque.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=robert.jarzmik@free.fr \
    --cc=soc@kernel.org \
    --cc=stable@vger.kernel.org \
    --subject='Re: [PATCH 15/15] ARM: dts: mmp3-dell-ariel: Fix the SPI devices' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.