All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lubomir Rintel <lkundrak@v3.sk>
To: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, Lubomir Rintel <lkundrak@v3.sk>
Subject: [PATCH 02/10] clk: mmp: frac: Allow setting bits other than the numerator/denominator
Date: Sun, 19 Apr 2020 19:27:34 +0200	[thread overview]
Message-ID: <20200419172742.674717-3-lkundrak@v3.sk> (raw)
In-Reply-To: <20200419172742.674717-1-lkundrak@v3.sk>

For the I2S fractional clocks, there are more bits that need to be set
for the clock to run. Their actual meaning is unknown.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 drivers/clk/mmp/clk-frac.c | 3 +++
 drivers/clk/mmp/clk.h      | 1 +
 2 files changed, 4 insertions(+)

diff --git a/drivers/clk/mmp/clk-frac.c b/drivers/clk/mmp/clk-frac.c
index ed9928f5bdc7f..48f592bd633df 100644
--- a/drivers/clk/mmp/clk-frac.c
+++ b/drivers/clk/mmp/clk-frac.c
@@ -148,7 +148,10 @@ static int clk_factor_init(struct clk_hw *hw)
 		val &= ~(masks->den_mask << masks->den_shift);
 		val |= (factor->ftbl[0].den & masks->den_mask) <<
 			masks->den_shift;
+	}
 
+	if (!(val & masks->enable_mask) || i >= factor->ftbl_cnt) {
+		val |= masks->enable_mask;
 		writel(val, factor->base);
 	}
 
diff --git a/drivers/clk/mmp/clk.h b/drivers/clk/mmp/clk.h
index 971b4d6d992fb..0efd5b0b2f01b 100644
--- a/drivers/clk/mmp/clk.h
+++ b/drivers/clk/mmp/clk.h
@@ -16,6 +16,7 @@ struct mmp_clk_factor_masks {
 	unsigned int den_mask;
 	unsigned int num_shift;
 	unsigned int den_shift;
+	unsigned int enable_mask;
 };
 
 struct mmp_clk_factor_tbl {
-- 
2.26.0


  parent reply	other threads:[~2020-04-19 17:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-19 17:27 [PATCH 00/10] clk: mmp2: Enable Audio and GPU on MMP2 and MMP3 Lubomir Rintel
2020-04-19 17:27 ` [PATCH 01/10] clk: mmp: frac: Do not lose last 4 digits of precision Lubomir Rintel
2020-04-19 17:27 ` Lubomir Rintel [this message]
2020-04-19 17:27 ` [PATCH 03/10] dt-bindings: marvell,mmp2: Add clock id for the I2S clocks Lubomir Rintel
2020-04-30 14:12   ` Rob Herring
2020-04-19 17:27 ` [PATCH 04/10] dt-bindings: marvell,mmp2: Add clock id for the Audio clock Lubomir Rintel
2020-04-30 14:12   ` Rob Herring
2020-04-19 17:27 ` [PATCH 05/10] clk: mmp2: Move thermal register defines up a bit Lubomir Rintel
2020-04-19 17:27 ` [PATCH 06/10] clk: mmp2: Rename mmp2_pll_init() to mmp2_main_clk_init() Lubomir Rintel
2020-04-19 17:27 ` [PATCH 07/10] clk: mmp2: Add the I2C clocks Lubomir Rintel
2020-04-19 17:27 ` [PATCH 08/10] clk: mmp2: Add the audio clock Lubomir Rintel
2020-04-19 17:27 ` [PATCH 09/10] dt-bindings: marvell,mmp2: Add ids for the power domains Lubomir Rintel
2020-04-30 14:13   ` Rob Herring
2020-04-19 17:27 ` [PATCH 10/10] clk: mmp2: Add support for power islands Lubomir Rintel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200419172742.674717-3-lkundrak@v3.sk \
    --to=lkundrak@v3.sk \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.