From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Joshua Kinard <kumba@gentoo.org>
Cc: linux-mips@vger.kernel.org
Subject: Re: [PATCH] Add missing ifdefs to SGI Platform files for IP22, IP32
Date: Mon, 20 Apr 2020 09:22:57 +0200 [thread overview]
Message-ID: <20200420072257.GE4627@alpha.franken.de> (raw)
In-Reply-To: <f4c06481-7fa3-d84c-5aa9-f991daef058c@gentoo.org>
On Thu, Apr 16, 2020 at 07:18:35PM -0400, Joshua Kinard wrote:
> On 4/16/2020 12:30, Thomas Bogendoerfer wrote:
> > On Mon, Mar 30, 2020 at 11:25:52PM -0400, Joshua Kinard wrote:
> >> The attached patch fixes the SGI-specific Platform files to only be
> >> included when their specific platform is actually built. Both the
> >> IP27 and IP30 Platform files already have such ifdefs in place. This
> >> patch adds the same to the IP22 and IP32 Platform files.
> >
> > looking at all other Platform files, I fail to see why this is needed.
> > It looks like removing the ifdefs from IP27 and IP30 is the way to
> > go. What do I miss here ?
> >
> > Thomas.
>
> I ran into an issue long ago where an IP32 kernel tried dragging in some of
> the directives in IP30 because of the missing ifdef checks, thus causing the
> build to fail.
do you still see this problem ? If yes, I'd like to understand why first.
If no, what about dropping this patch ?
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2020-04-20 7:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 3:25 [PATCH] Add missing ifdefs to SGI Platform files for IP22, IP32 Joshua Kinard
2020-04-16 16:30 ` Thomas Bogendoerfer
2020-04-16 23:18 ` Joshua Kinard
2020-04-20 7:22 ` Thomas Bogendoerfer [this message]
2020-04-21 6:13 ` Joshua Kinard
2020-04-22 17:14 ` Maciej W. Rozycki
2020-05-06 16:36 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420072257.GE4627@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=kumba@gentoo.org \
--cc=linux-mips@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.