All of lore.kernel.org
 help / color / mirror / Atom feed
From: Murphy Zhou <jencce.kernel@gmail.com>
To: linux-crypto@vger.kernel.org, Hadar Gat <hadar.gat@arm.com>
Cc: linux-next@vger.kernel.org
Subject: [PATCH] [linux-next] hwrng: cctrng - fix missing fips header
Date: Mon, 20 Apr 2020 17:13:18 +0800	[thread overview]
Message-ID: <20200420091318.bj533ppmetonqygn@xzhoux.usersys.redhat.com> (raw)

In linux-next tree, this is causing build error:

drivers/char/hw_random/cctrng.c: In function ‘cc_trng_compwork_handler’:
drivers/char/hw_random/cctrng.c:334:49: error: ‘fips_enabled’ undeclared (first use in this function); did you mean ‘nx_enabled’?
  if (CC_REG_FLD_GET(RNG_ISR, CRNGT_ERR, isr) && fips_enabled) {
                                                 ^~~~~~~~~~~~
                                                 nx_enabled
drivers/char/hw_random/cctrng.c:334:49: note: each undeclared identifier is reported only once for each function it appears in
drivers/char/hw_random/cctrng.c:335:3: error: implicit declaration of function ‘fips_fail_notify’; did you mean ‘sysfs_notify’?
[-Werror=implicit-function-declaration]
   fips_fail_notify();
   ^~~~~~~~~~~~~~~~
   sysfs_notify
cc1: some warnings being treated as errors

Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com>
---
 drivers/char/hw_random/cctrng.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/char/hw_random/cctrng.c b/drivers/char/hw_random/cctrng.c
index bdcd56243104..e82716c12c3a 100644
--- a/drivers/char/hw_random/cctrng.c
+++ b/drivers/char/hw_random/cctrng.c
@@ -15,6 +15,7 @@
 #include <linux/completion.h>
 #include <linux/of.h>
 #include <linux/bitfield.h>
+#include <linux/fips.h>
 
 #include "cctrng.h"
 
-- 
2.18.1

             reply	other threads:[~2020-04-20  9:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-20  9:13 Murphy Zhou [this message]
2020-04-20 15:26 ` [PATCH] [linux-next] hwrng: cctrng - fix missing fips header Hadar Gat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200420091318.bj533ppmetonqygn@xzhoux.usersys.redhat.com \
    --to=jencce.kernel@gmail.com \
    --cc=hadar.gat@arm.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.