All of lore.kernel.org
 help / color / mirror / Atom feed
From: Karthik B S <karthik.b.s@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: paulo.r.zanoni@intel.com
Subject: [Intel-gfx] [PATCH v2 6/6] drm/i915: Do not call drm_crtc_arm_vblank_event in async flips
Date: Mon, 20 Apr 2020 15:17:46 +0530	[thread overview]
Message-ID: <20200420094746.20409-7-karthik.b.s@intel.com> (raw)
In-Reply-To: <20200420094746.20409-1-karthik.b.s@intel.com>

Since the flip done event will be sent in the flip_done_handler,
no need to add the event to the list and delay it for later.

v2: -Moved the async check above vblank_get as it
     was causing issues for PSR.

Signed-off-by: Karthik B S <karthik.b.s@intel.com>
---
 drivers/gpu/drm/i915/display/intel_sprite.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c
index 0000ec7055f7..9b9f29768336 100644
--- a/drivers/gpu/drm/i915/display/intel_sprite.c
+++ b/drivers/gpu/drm/i915/display/intel_sprite.c
@@ -205,7 +205,7 @@ void intel_pipe_update_end(struct intel_crtc_state *new_crtc_state)
 	 * Would be slightly nice to just grab the vblank count and arm the
 	 * event outside of the critical section - the spinlock might spin for a
 	 * while ... */
-	if (new_crtc_state->uapi.event) {
+	if (new_crtc_state->uapi.event && !new_crtc_state->uapi.async_flip) {
 		drm_WARN_ON(&dev_priv->drm,
 			    drm_crtc_vblank_get(&crtc->base) != 0);
 
-- 
2.22.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2020-04-20  9:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-20  9:47 [Intel-gfx] [PATCH v2 0/6] Asynchronous flip implementation for i915 Karthik B S
2020-04-20  9:47 ` [Intel-gfx] [PATCH v2 1/6] drm/i915: Add enable/disable flip done and flip done handler Karthik B S
2020-04-24 17:44   ` Paulo Zanoni
2020-05-29  4:06     ` Karthik B S
2020-04-20  9:47 ` [Intel-gfx] [PATCH v2 2/6] drm/i915: Add support for async flips in I915 Karthik B S
2020-04-20  9:47 ` [Intel-gfx] [PATCH v2 3/6] drm/i915: Enable async flips in i915 Karthik B S
2020-04-20 18:04   ` Paulo Zanoni
2020-05-29  4:10     ` Karthik B S
2020-04-20  9:47 ` [Intel-gfx] [PATCH v2 4/6] drm/i915: Make commit call blocking in case of async flips Karthik B S
2020-04-24 17:46   ` Paulo Zanoni
2020-05-29  4:24     ` Karthik B S
2020-04-20  9:47 ` [Intel-gfx] [PATCH v2 5/6] drm/i915: Add checks specific to " Karthik B S
2020-04-20 17:58   ` Paulo Zanoni
2020-05-29  4:50     ` Karthik B S
2020-04-20  9:47 ` Karthik B S [this message]
2020-04-20 10:06 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Asynchronous flip implementation for i915 (rev2) Patchwork
2020-04-20 10:30 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-04-20 15:47 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200420094746.20409-7-karthik.b.s@intel.com \
    --to=karthik.b.s@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.