From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D9BFC54FCB for ; Mon, 20 Apr 2020 11:37:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 331E02078C for ; Mon, 20 Apr 2020 11:37:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587382647; bh=Xv91P5BFptk8v+4mIKZ+00d8+7F5VJtrztWk8yf18OE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=touj8VZTqOZN+SndoPRvKuZrbOPTjuZbnebvCweMPKZOUUTyaNNqAE3bcVaVySgo9 oem+0Kd+XfViZmRlkYOpd0G4PgShH+54xNCIvRsPvmIiVxBOTV0lzpk+CRWcs9xm+S SJU9MBSdGF1iGet7FeCLAA8u+TAGcieoraRYTJXk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726209AbgDTLh0 (ORCPT ); Mon, 20 Apr 2020 07:37:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:34622 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726091AbgDTLh0 (ORCPT ); Mon, 20 Apr 2020 07:37:26 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A8506206D4; Mon, 20 Apr 2020 11:37:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587382646; bh=Xv91P5BFptk8v+4mIKZ+00d8+7F5VJtrztWk8yf18OE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tOrmDT5lwCv65vrxCr9jX+FR3MiROr1B0tBeLYOqXE1JoBeM2AKzaJw2H3qogzh5I Ol0OzyvuedbPW5V9FmjfELaa2Pfxl4OCdHXOXA246WAhHVbHk23Z/IS3z1Dw8SizOO syR02sCdoPudeAcz5kEXxvhow0oZCgJhtEi6OGO8= Date: Mon, 20 Apr 2020 13:37:24 +0200 From: Greg KH To: Bart Van Assche Cc: Luis Chamberlain , axboe@kernel.dk, viro@zeniv.linux.org.uk, rostedt@goodmis.org, mingo@redhat.com, jack@suse.cz, ming.lei@redhat.com, nstange@suse.de, akpm@linux-foundation.org, mhocko@suse.com, yukuai3@huawei.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 07/10] blktrace: move debugfs file creation to its own function Message-ID: <20200420113724.GB3906674@kroah.com> References: <20200419194529.4872-1-mcgrof@kernel.org> <20200419194529.4872-8-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Sun, Apr 19, 2020 at 03:55:15PM -0700, Bart Van Assche wrote: > On 4/19/20 12:45 PM, Luis Chamberlain wrote: > > +static int blk_trace_create_debugfs_files(struct blk_user_trace_setup *buts, > > + struct dentry *dir, > > + struct blk_trace *bt) > > +{ > > + int ret = -EIO; > > + > > + bt->dropped_file = debugfs_create_file("dropped", 0444, dir, bt, > > + &blk_dropped_fops); > > + > > + bt->msg_file = debugfs_create_file("msg", 0222, dir, bt, &blk_msg_fops); > > + > > + bt->rchan = relay_open("trace", dir, buts->buf_size, > > + buts->buf_nr, &blk_relay_callbacks, bt); > > + if (!bt->rchan) > > + return ret; > > + > > + return 0; > > +} > > How about adding IS_ERR() checks for the debugfs_create_file() return > values? No, please no, I have been removing all of that nonsense from the kernel for the past 3-4 releases. You should never care about the return value from that call, just save it off and move on. as it is, this is correct. greg k-h