From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74D46C3815B for ; Mon, 20 Apr 2020 15:11:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49A4220775 for ; Mon, 20 Apr 2020 15:11:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587395490; bh=RXNvQ/cT/QXAv1L+OKmfuU3SIQOPNVZkqtALMcYuwlY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=rV+2J4Bf+BLuh81lYAyKVK0VEjnk0QdAYFIt16GVb3YwRmjHXr9FRfU9DBxIf84Kx pdaxN/zoXG4xB/lDcykVfdwF4+L7KFRMjv2EhLCw2+FE3vsi6TIw9x847Hl/AbQs1S P63jajCLe7jQRPi2/mhHorg4y3dWFy7UNU3hLuFw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727009AbgDTPL3 (ORCPT ); Mon, 20 Apr 2020 11:11:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:55370 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726847AbgDTPL3 (ORCPT ); Mon, 20 Apr 2020 11:11:29 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9235A2074F; Mon, 20 Apr 2020 15:11:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587395489; bh=RXNvQ/cT/QXAv1L+OKmfuU3SIQOPNVZkqtALMcYuwlY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2smS0g43TYqTnx15JG3CPj4oMnLK73YOdPJxNOmyLSr7JlB1lYZT0E3gpXVgU/Uq/ TPIN+eiajGu1YU+h6ju7XTXvyFpZzZCwIOvYmBCl6QzOjZdzd9uYvZkhRogIG6uHrW eO3fMIq9nF95P48pXe02UFG7pLjOQ5ERFSfzDd4k= From: Leon Romanovsky To: Doug Ledford , Jason Gunthorpe Cc: Leon Romanovsky , linux-rdma@vger.kernel.org, Maor Gottlieb Subject: [PATCH rdma-next 05/18] RDMA/mlx5: Avoid setting redundant NULL for XRC QPs Date: Mon, 20 Apr 2020 18:10:52 +0300 Message-Id: <20200420151105.282848-6-leon@kernel.org> X-Mailer: git-send-email 2.25.2 In-Reply-To: <20200420151105.282848-1-leon@kernel.org> References: <20200420151105.282848-1-leon@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Leon Romanovsky There is no need to set NULL in recv_cq and send_cq, they are already set to NULL by the IB/core logic. Reviewed-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/qp.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c index 6a025153cb93..2039f5391e20 100644 --- a/drivers/infiniband/hw/mlx5/qp.c +++ b/drivers/infiniband/hw/mlx5/qp.c @@ -2771,14 +2771,8 @@ struct ib_qp *mlx5_ib_create_qp(struct ib_pd *pd, } } - if (init_attr->qp_type == IB_QPT_XRC_TGT) { - init_attr->recv_cq = NULL; + if (init_attr->qp_type == IB_QPT_XRC_TGT) xrcdn = to_mxrcd(init_attr->xrcd)->xrcdn; - init_attr->send_cq = NULL; - } - - if (init_attr->qp_type == IB_QPT_XRC_INI) - init_attr->recv_cq = NULL; err = create_qp_common(dev, pd, init_attr, udata, qp); if (err) { -- 2.25.2