From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DA9CC3815B for ; Mon, 20 Apr 2020 15:33:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2151320575 for ; Mon, 20 Apr 2020 15:33:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727830AbgDTPdt (ORCPT ); Mon, 20 Apr 2020 11:33:49 -0400 Received: from correo.us.es ([193.147.175.20]:52064 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726214AbgDTPds (ORCPT ); Mon, 20 Apr 2020 11:33:48 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id DAA5CE16E4 for ; Mon, 20 Apr 2020 17:33:46 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id C9128100A42 for ; Mon, 20 Apr 2020 17:33:46 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id BED121007B4; Mon, 20 Apr 2020 17:33:46 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id B111C10078C; Mon, 20 Apr 2020 17:33:44 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Mon, 20 Apr 2020 17:33:44 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 905CF42EF42B; Mon, 20 Apr 2020 17:33:44 +0200 (CEST) Date: Mon, 20 Apr 2020 17:33:44 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Bodong Wang Cc: netfilter-devel@vger.kernel.org, ozsh@mellanox.com, paulb@mellanox.com Subject: Re: [nf-next] netfilter: nf_conntrack, add IPS_HW_OFFLOAD status bit Message-ID: <20200420153344.c2tjwmohirlnd4cj@salvia> References: <20200420145810.11035-1-bodong@mellanox.com> <20200420151525.qk764gfgydbip6u2@salvia> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="5kc3hbej2qr5bpax" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org --5kc3hbej2qr5bpax Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 20, 2020 at 10:28:00AM -0500, Bodong Wang wrote: > On 4/20/2020 10:15 AM, Pablo Neira Ayuso wrote: > > On Mon, Apr 20, 2020 at 09:58:10AM -0500, Bodong Wang wrote: > > [...] > > > @@ -796,6 +799,16 @@ static void flow_offload_work_stats(struct flow_offload_work *offload) > > > FLOW_OFFLOAD_DIR_REPLY, > > > stats[1].pkts, stats[1].bytes); > > > } > > > + > > > + /* Clear HW_OFFLOAD immediately when lastused stopped updating, this can > > > + * happen in two scenarios: > > > + * > > > + * 1. TC rule on a higher level device (e.g. vxlan) was offloaded, but > > > + * HW driver is unloaded. > > > + * 2. One of the shared block driver is unloaded. > > > + */ > > > + if (!lastused) > > > + clear_bit(IPS_HW_OFFLOAD_BIT, &offload->flow->ct->status); > > > } > > Better inconditionally clear off the flag after the entry is removed > > from hardware instead of relying on the lastused field? > > Functionality wise, it should work. Current way is more for containing the > set/clear in the same domain, and no need to ask each vendor to take care of > this bit. No need to ask each vendor, what I mean is to deal with this from flow_offload_work_del(), see attached patch. --5kc3hbej2qr5bpax Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="x.patch" diff --git a/net/netfilter/nf_flow_table_offload.c b/net/netfilter/nf_flow_table_offload.c index e3b099c14eff..593fefd52ef7 100644 --- a/net/netfilter/nf_flow_table_offload.c +++ b/net/netfilter/nf_flow_table_offload.c @@ -763,6 +763,7 @@ static void flow_offload_work_del(struct flow_offload_work *offload) flow_offload_tuple_del(offload, FLOW_OFFLOAD_DIR_ORIGINAL); flow_offload_tuple_del(offload, FLOW_OFFLOAD_DIR_REPLY); set_bit(NF_FLOW_HW_DEAD, &offload->flow->flags); + clear_bit(IPS_HW_OFFLOAD_BIT, &offload->flow->ct->status); } static void flow_offload_tuple_stats(struct flow_offload_work *offload, --5kc3hbej2qr5bpax--