All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Porter <mporter@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH] board: add InnoComm i.MX8MM WB15EVK
Date: Mon, 20 Apr 2020 17:09:48 -0400	[thread overview]
Message-ID: <20200420210948.GB29919@bacon.ohporter.com> (raw)
In-Reply-To: <CAOMZO5BjqKHMTtWEKF=YGh4pAPjYgbL6hxHwfY-3=zEMscR2Ag@mail.gmail.com>

On Thu, Apr 16, 2020 at 02:33:17PM -0300, Fabio Estevam wrote:
> Hi Matt,

Hi Fabio, thanks for the review!

> On Thu, Apr 9, 2020 at 6:51 PM Matt Porter <mporter@konsulko.com> wrote:
> 
> Hopefully this dts will be sent upstream.

Yes, this just made it out first. Updating both accordingly below.

> 
> > +/ {
> > +       model = "InnoComm i.MX8MM WB15EVK";
> > +       compatible = "fsl,imx8mm-wb15evk", "fsl,imx8mm";
> 
> Should be "innocomm,imx8mm-wb15evk", "fsl,imx8mm" instead, since the
> board manufacturer is InnoComm.

Oops, yeah, will fix that.

> 
> > +&gpio1 {
> > +       phy_en {
> > +               gpio-hog;
> > +               gpios = <10 GPIO_ACTIVE_HIGH>;
> > +               output-high;
> > +               pinctrl-names = "default";
> > +               pinctrl-0 = <&pinctrl_phy_en>;
> > +       };
> 
> Shouldn't this be modelled as a phy-supply GPIO controlled regulator instead?

Yes, converting it to a regulator will be better.

> > +CONFIG_SPL_SYS_ICACHE_OFF=y
> > +CONFIG_SPL_SYS_DCACHE_OFF=y

> Can't we work with caches enabled by now?

Yes, I verified we're fine with cache on so I'll fix that.

> > +/* USDHC */
> > +#define CONFIG_FSL_USDHC
> 
> Better put it in the defconfig instead.

Ok.
> 
> > +#define CONFIG_FEC_XCV_TYPE             RGMII
> > +#define FEC_QUIRK_ENET_MAC
> 
> Shouldn't this be moved to a SoC header instead of each board file?

It does look like it should be moved to imx-regs.h like imx6/7 do.

> > +
> > +#define IMX_FEC_BASE                    0x30BE0000
> 
> Not needed as you are using FEC DM.

Ok.

-Matt

      reply	other threads:[~2020-04-20 21:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-09 21:51 [PATCH] board: add InnoComm i.MX8MM WB15EVK Matt Porter
2020-04-16 17:33 ` Fabio Estevam
2020-04-20 21:09   ` Matt Porter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200420210948.GB29919@bacon.ohporter.com \
    --to=mporter@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.