From: Andrew Morton <akpm@linux-foundation.org>
To: Minchan Kim <minchan@kernel.org>
Cc: linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>, Jan Kara <jack@suse.cz>,
Matthew Wilcox <willy@infradead.org>,
Josef Bacik <josef@toxicpanda.com>,
Johannes Weiner <hannes@cmpxchg.org>, Robert Stupp <snazy@gmx.de>
Subject: Re: [PATCH 2/3] mm: fix long time stall from mm_populate
Date: Mon, 20 Apr 2020 21:12:55 -0700 [thread overview]
Message-ID: <20200420211255.55bb6e1275cf90f9dc292238@linux-foundation.org> (raw)
In-Reply-To: <20200212221614.215302-2-minchan@kernel.org>
On Wed, 12 Feb 2020 14:16:13 -0800 Minchan Kim <minchan@kernel.org> wrote:
> Basically, fault handler releases mmap_sem before requesting readahead
> and then it is supposed to retry lookup the page from page cache with
> FAULT_FLAG_TRIED so that it avoids the live lock of infinite retry.
>
> However, what happens if the fault handler find a page from page
> cache and the page has readahead marker but are waiting under
> writeback? Plus one more condition, it happens under mm_populate
> which repeats faulting unless it encounters error. So let's assemble
> conditions below.
>
> __mm_populate
> for (...)
> get_user_pages(faluty_address)
> handle_mm_fault
> filemap_fault
> find a page form page(PG_uptodate|PG_readahead|PG_writeback)
> it will return VM_FAULT_RETRY
> continue with faulty_address
>
> IOW, it will repeat fault retry logic until the page will be written
> back in the long run. It makes big spike latency of several seconds.
>
> This patch solves the issue by turning off fault retry logic in second
> trial.
I guess a resend would be helpful, to refresh memories.
Please mention in the changelog whether this "long time stall" has been
observed in practice. If so, under what conditions, how often and how
long was it? etcetera.
next prev parent reply other threads:[~2020-04-21 4:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 22:16 [PATCH 1/3] mm: Don't bother dropping mmap_sem for zero size readahead Minchan Kim
2020-02-12 22:16 ` [PATCH 2/3] mm: fix long time stall from mm_populate Minchan Kim
2020-04-21 4:12 ` Andrew Morton [this message]
2020-02-12 22:16 ` [PATCH 3/3] mm: make PageReadahead more strict Minchan Kim
2020-02-17 9:31 ` Jan Kara
2020-02-18 22:28 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420211255.55bb6e1275cf90f9dc292238@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=snazy@gmx.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.