From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A94F0C54FCC for ; Tue, 21 Apr 2020 17:41:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7181C206D9 for ; Tue, 21 Apr 2020 17:41:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="d0zRglxz"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="3RMhhTQT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725963AbgDURll (ORCPT ); Tue, 21 Apr 2020 13:41:41 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:49583 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725870AbgDURlj (ORCPT ); Tue, 21 Apr 2020 13:41:39 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CBFF75C010B; Tue, 21 Apr 2020 13:41:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 21 Apr 2020 13:41:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=c6NUfIcL8iEd3sc6cWM51EfZOhT g3PneqfBlYaWah6A=; b=d0zRglxzWfSBxl7kaZjRHxl255hrRjrz/RJOSOx+Ph2 0LODjWzcQMw2mFND43GG3al+2qfvMhSJ7yB10VV+RQ+AxkxcLbS+LzVlsndEvsEK JE/d5MeTFDfdzwe82ZkHzj7DO6opX96cA7QAVsmIUw9Tbvl7wFnGwh/iCVAAA1Bz dwCLiQ2WYJWXJwUfzx3rduQ5C9VaQaWPudwPs2R/g69zxx+BnHutjFlumwOf5rZg QjBGXp733Sz1LC61NBRRez0F7yp90XZ50fNLdtQwQyOGazAe9jrkDHAArkopTFuT b3Gg0rUXPmBnJOiy5hoKIKc3c4x6duTOnJfT1YV1w4A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=c6NUfI cL8iEd3sc6cWM51EfZOhTg3PneqfBlYaWah6A=; b=3RMhhTQT7XjQ66rKUVAc7U Q9B2HLMs5BAKp+BfBXc6MRWCNdJJ1dtcVt8I+zYMGHa/K8ZHSKo08BGbE+/gX8Es Df1PUuFxf8MN8rbR6+dBaH6mf7IWmPPjozhp62vJxG5oNeCJQx4hdyQ2dscY27Rm m2tlVtZ2hsoyW8CJPJRMkkNW9nSfNY608VsxVhh8RScq3aSwxGGTMYAojPEhgpVy UJA5/CxMz+5ux4AViNGDthnLyJGg3UMV8GDl0lSvkCtRZ9/250XUV7vcaf5CzLiP KtMR3h8a9qd/IfcSFJF1JqwpF9z6EszJlFbrZE9WKHg38ELw0r51LmV9oqRGp6MA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrgeehgdduudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucfkphepkeefrdekiedrkeelrddutd ejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhr vghgsehkrhhorghhrdgtohhm X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 53B6E3065C88; Tue, 21 Apr 2020 13:41:38 -0400 (EDT) Date: Tue, 21 Apr 2020 19:41:36 +0200 From: Greg KH To: Lee Jones Cc: stable@vger.kernel.org, Subash Abhinov Kasiviswanathan , "David S . Miller" Subject: Re: [PATCH 4.14 15/24] net: qualcomm: rmnet: Fix casting issues Message-ID: <20200421174136.GB1307291@kroah.com> References: <20200421124017.272694-1-lee.jones@linaro.org> <20200421124017.272694-16-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200421124017.272694-16-lee.jones@linaro.org> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Apr 21, 2020 at 01:40:08PM +0100, Lee Jones wrote: > From: Subash Abhinov Kasiviswanathan > > [ Upstream commit 6e010dd9b16b1a320bbf8312359ac294d7e1d9a8 ] > > Fix warnings which were reported when running with sparse > (make C=1 CF=-D__CHECK_ENDIAN__) > > drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c:81:15: > warning: cast to restricted __be16 > drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:271:37: > warning: incorrect type in assignment (different base types) > expected unsigned short [unsigned] [usertype] pkt_len > got restricted __be16 [usertype] > drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:287:29: > warning: incorrect type in assignment (different base types) > expected unsigned short [unsigned] [usertype] pkt_len > got restricted __be16 [usertype] > drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:310:22: > warning: cast to restricted __be16 > drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:319:13: > warning: cast to restricted __be16 > drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c:49:18: > warning: cast to restricted __be16 > drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c:50:18: > warning: cast to restricted __be32 > drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c:74:21: > warning: cast to restricted __be16 > > Signed-off-by: Subash Abhinov Kasiviswanathan > Signed-off-by: David S. Miller > Signed-off-by: Lee Jones > --- > drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h > index ce2302c25b128..41fa881e4540e 100644 > --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h > +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h > @@ -23,8 +23,8 @@ struct rmnet_map_control_command { > struct { > u16 ip_family:2; > u16 reserved:14; > - u16 flow_control_seq_num; > - u32 qos_id; > + __be16 flow_control_seq_num; > + __be32 qos_id; > } flow_control; > u8 data[0]; > }; > @@ -53,7 +53,7 @@ struct rmnet_map_header { > u8 reserved_bit:1; > u8 cd_bit:1; > u8 mux_id; > - u16 pkt_len; > + __be16 pkt_len; Again, a nice patch, but doesn't actually fix a bug, so not needed for stable. thanks, greg k-h