All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Maor Gottlieb <maorg@mellanox.com>
Cc: davem@davemloft.net, jgg@mellanox.com, dledford@redhat.com,
	j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net,
	kuba@kernel.org, jiri@mellanox.com, dsahern@kernel.org,
	leonro@mellanox.com, saeedm@mellanox.com,
	linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
	alexr@mellanox.com
Subject: Re: [PATCH V3 mlx5-next 09/15] bonding: Implement ndo_get_xmit_slave
Date: Tue, 21 Apr 2020 21:49:56 +0200	[thread overview]
Message-ID: <20200421194956.GH6581@nanopsycho.orion> (raw)
In-Reply-To: <20200421102844.23640-10-maorg@mellanox.com>

Tue, Apr 21, 2020 at 12:28:38PM CEST, maorg@mellanox.com wrote:
>Add implementation of ndo_get_xmit_slave. When user set all_slaves
>to true, the xmit slave result is based on the hash, then the slave
>will be selected from the array of all the slaves.

Reading this sentence multiple times, does not make sense to me :/ Could
you rephrase please?

The code looks fine.

  reply	other threads:[~2020-04-21 19:50 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-21 10:28 [PATCH V3 mlx5-next 00/15] Add support to get xmit slave Maor Gottlieb
2020-04-21 10:28 ` [PATCH V3 mlx5-next 01/15] net/core: Introduce master_get_xmit_slave Maor Gottlieb
2020-04-21 15:05   ` Jiri Pirko
2020-04-21 10:28 ` [PATCH V3 mlx5-next 02/15] bonding: Export skip slave logic to function Maor Gottlieb
2020-04-21 15:50   ` Jiri Pirko
2020-04-21 10:28 ` [PATCH V3 mlx5-next 03/15] bonding: Rename slave_arr to usable_slaves Maor Gottlieb
2020-04-21 15:52   ` Jiri Pirko
2020-04-21 10:28 ` [PATCH V3 mlx5-next 04/15] bonding/alb: Add helper functions to get the xmit slave Maor Gottlieb
2020-04-21 16:02   ` Jiri Pirko
2020-04-21 10:28 ` [PATCH V3 mlx5-next 05/15] bonding: Add helper function to get the xmit slave based on hash Maor Gottlieb
2020-04-21 16:10   ` Jiri Pirko
2020-04-21 10:28 ` [PATCH V3 mlx5-next 06/15] bonding: Add helper function to get the xmit slave in rr mode Maor Gottlieb
2020-04-21 16:30   ` Jiri Pirko
2020-04-21 10:28 ` [PATCH V3 mlx5-next 07/15] bonding: Add function to get the xmit slave in active-backup mode Maor Gottlieb
2020-04-21 18:02   ` Jiri Pirko
2020-04-21 10:28 ` [PATCH V3 mlx5-next 08/15] bonding: Add array of all salves Maor Gottlieb
2020-04-21 19:47   ` Jiri Pirko
2020-04-21 20:33   ` Jay Vosburgh
2020-04-21 10:28 ` [PATCH V3 mlx5-next 09/15] bonding: Implement ndo_get_xmit_slave Maor Gottlieb
2020-04-21 19:49   ` Jiri Pirko [this message]
2020-04-21 10:28 ` [PATCH V3 mlx5-next 10/15] RDMA/core: Add LAG functionality Maor Gottlieb
2020-04-21 10:28 ` [PATCH V3 mlx5-next 11/15] RDMA/core: Get xmit slave for LAG Maor Gottlieb
2020-04-21 10:28 ` [PATCH V3 mlx5-next 12/15] net/mlx5: Change lag mutex lock to spin lock Maor Gottlieb
2020-04-21 10:28 ` [PATCH V3 mlx5-next 13/15] net/mlx5: Add support to get lag physical port Maor Gottlieb
2020-04-21 10:28 ` [PATCH V3 mlx5-next 14/15] RDMA/mlx5: Refactor affinity related code Maor Gottlieb
2020-04-21 10:28 ` [PATCH V3 mlx5-next 15/15] RDMA/mlx5: Set lag tx affinity according to slave Maor Gottlieb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200421194956.GH6581@nanopsycho.orion \
    --to=jiri@resnulli.us \
    --cc=alexr@mellanox.com \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=dledford@redhat.com \
    --cc=dsahern@kernel.org \
    --cc=j.vosburgh@gmail.com \
    --cc=jgg@mellanox.com \
    --cc=jiri@mellanox.com \
    --cc=kuba@kernel.org \
    --cc=leonro@mellanox.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=maorg@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@mellanox.com \
    --cc=vfalico@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.