From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5438BC54FC9 for ; Tue, 21 Apr 2020 19:54:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39B8B206D9 for ; Tue, 21 Apr 2020 19:54:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726335AbgDUTyH (ORCPT ); Tue, 21 Apr 2020 15:54:07 -0400 Received: from mga17.intel.com ([192.55.52.151]:48553 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725987AbgDUTyG (ORCPT ); Tue, 21 Apr 2020 15:54:06 -0400 IronPort-SDR: sRFZdjmZfWE7GSX/iJccG5wnFLZ7P7RogLTw2PqqGmD5QJRmfs09PcS0NBvv9u65R8zfnCZULW /+A0MGGDAdUA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2020 12:54:06 -0700 IronPort-SDR: u0PucUAwlTW5D/vEtBMVccgXiyEn4WGQVAczLuFaWatEh/EbMdaAfn9ZmlhHEG39aYysNO3bSz gxfIScmQTOqg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,411,1580803200"; d="scan'208";a="247264606" Received: from mnchalux-mobl2.gar.corp.intel.com (HELO localhost) ([10.252.44.234]) by fmsmga008.fm.intel.com with ESMTP; 21 Apr 2020 12:54:04 -0700 Date: Tue, 21 Apr 2020 22:54:03 +0300 From: Jarkko Sakkinen To: Hans de Goede Cc: linux-integrity@vger.kernel.org, stable@vger.kernel.org, Peter Huewe , Jason Gunthorpe , Arnd Bergmann , Greg Kroah-Hartman , open list Subject: Re: [PATCH v2] tpm/tpm_tis: Free IRQ if probing fails Message-ID: <20200421195403.GA46589@linux.intel.com> References: <20200416160751.180791-1-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 21, 2020 at 03:23:19PM +0200, Hans de Goede wrote: > Hi, > > On 4/16/20 6:07 PM, Jarkko Sakkinen wrote: > > Call disable_interrupts() if we have to revert to polling in order not to > > unnecessarily reserve the IRQ for the life-cycle of the driver. > > > > Cc: stable@vger.kernel.org # 4.5.x > > Reported-by: Hans de Goede > > Fixes: e3837e74a06d ("tpm_tis: Refactor the interrupt setup") > > Signed-off-by: Jarkko Sakkinen > > I can confirm that this fixes the "irq 31 nobody cared" oops for me: > > Tested-by: Hans de Goede Hi, thanks a lot! Unfortunately I already put this out given the criticality of the issue: https://lkml.org/lkml/2020/4/20/1544 Sincere apologies that I couldn't include your tested-by but the most important thing is to know that it works now. /Jarkko