Re: [RFC PATCH 5/6] firmware: stratix10: use SMCCC v1.0 helper functions

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5170 bytes --]

Hi Etienne,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on linus/master]
[also build test ERROR on v5.7-rc2 next-20200421]
[cannot apply to xlnx/master linux/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Etienne-Carriere/firmware-conduit-method-helpers-for-SMCCC-v1-0-calls/20200421-144120
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git ae83d0b416db002fe95601e7f97f64b59514d936
config: arm64-defconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project a9b137f9ffba8cb25dfd7dd1fb613e8aac121b37)
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/firmware/stratix10-svc.c:911:6: error: implicit declaration of function 'arm_smccc_1_0_set_device_conduit' [-Werror,-Wimplicit-function-declaration]
           if (arm_smccc_1_0_set_device_conduit(&pdev->dev))
               ^
   drivers/firmware/stratix10-svc.c:911:6: note: did you mean 'arm_smccc_1_0_set_conduit'?
   include/linux/arm-smccc.h:440:5: note: 'arm_smccc_1_0_set_conduit' declared here
   int arm_smccc_1_0_set_conduit(enum arm_smccc_conduit);
       ^
   1 error generated.

vim +/arm_smccc_1_0_set_device_conduit +911 drivers/firmware/stratix10-svc.c

   897	
   898	static int stratix10_svc_drv_probe(struct platform_device *pdev)
   899	{
   900		struct device *dev = &pdev->dev;
   901		struct stratix10_svc_controller *controller;
   902		struct stratix10_svc_chan *chans;
   903		struct gen_pool *genpool;
   904		struct stratix10_svc_sh_memory *sh_memory;
   905		struct stratix10_svc *svc;
   906	
   907		size_t fifo_size;
   908		int ret;
   909	
   910		/* get SMC or HVC conduit */
 > 911		if (arm_smccc_1_0_set_device_conduit(&pdev->dev))
   912			return -EINVAL;
   913	
   914		sh_memory = devm_kzalloc(dev, sizeof(*sh_memory), GFP_KERNEL);
   915		if (!sh_memory)
   916			return -ENOMEM;
   917	
   918		ret = svc_get_sh_memory(pdev, sh_memory);
   919		if (ret)
   920			return ret;
   921	
   922		genpool = svc_create_memory_pool(pdev, sh_memory);
   923		if (!genpool)
   924			return -ENOMEM;
   925	
   926		/* allocate service controller and supporting channel */
   927		controller = devm_kzalloc(dev, sizeof(*controller), GFP_KERNEL);
   928		if (!controller)
   929			return -ENOMEM;
   930	
   931		chans = devm_kmalloc_array(dev, SVC_NUM_CHANNEL,
   932					   sizeof(*chans), GFP_KERNEL | __GFP_ZERO);
   933		if (!chans)
   934			return -ENOMEM;
   935	
   936		controller->dev = dev;
   937		controller->num_chans = SVC_NUM_CHANNEL;
   938		controller->num_active_client = 0;
   939		controller->chans = chans;
   940		controller->genpool = genpool;
   941		controller->task = NULL;
   942		init_completion(&controller->complete_status);
   943	
   944		fifo_size = sizeof(struct stratix10_svc_data) * SVC_NUM_DATA_IN_FIFO;
   945		ret = kfifo_alloc(&controller->svc_fifo, fifo_size, GFP_KERNEL);
   946		if (ret) {
   947			dev_err(dev, "failed to allocate FIFO\n");
   948			return ret;
   949		}
   950		spin_lock_init(&controller->svc_fifo_lock);
   951	
   952		chans[0].scl = NULL;
   953		chans[0].ctrl = controller;
   954		chans[0].name = SVC_CLIENT_FPGA;
   955		spin_lock_init(&chans[0].lock);
   956	
   957		chans[1].scl = NULL;
   958		chans[1].ctrl = controller;
   959		chans[1].name = SVC_CLIENT_RSU;
   960		spin_lock_init(&chans[1].lock);
   961	
   962		list_add_tail(&controller->node, &svc_ctrl);
   963		platform_set_drvdata(pdev, controller);
   964	
   965		/* add svc client device(s) */
   966		svc = devm_kzalloc(dev, sizeof(*svc), GFP_KERNEL);
   967		if (!svc)
   968			return -ENOMEM;
   969	
   970		svc->stratix10_svc_rsu = platform_device_alloc(STRATIX10_RSU, 0);
   971		if (!svc->stratix10_svc_rsu) {
   972			dev_err(dev, "failed to allocate %s device\n", STRATIX10_RSU);
   973			return -ENOMEM;
   974		}
   975	
   976		ret = platform_device_add(svc->stratix10_svc_rsu);
   977		if (ret) {
   978			platform_device_put(svc->stratix10_svc_rsu);
   979			return ret;
   980		}
   981		dev_set_drvdata(dev, svc);
   982	
   983		pr_info("Intel Service Layer Driver Initialized\n");
   984	
   985		return ret;
   986	}
   987	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 48834 bytes --]